From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFB203BE175 for ; Tue, 21 Jul 2026 08:46:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784623574; cv=none; b=fv8y2FpggcOhxolYazWehzndQwm4mwVCv6Iz7IMh8KxY9XlwMKQEhsFnWU9Y9nitFbPZTL8rOW3phd0a1k+VQDjsOB8DEywgLPrFKRtFZ+Mh+bU1rY1IRJgOOH3HYGmXZKnal3/Qr7gxOWMBtS1b8+KXwg2vW4S4SzX2nkZONs8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784623574; c=relaxed/simple; bh=YuamI1BxG38RiHIYx/SIZEAvWsuh5tk+e8yJqhhWbvg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aXzjAAqvg2YxyMQyQEA9uhrR9FUGUd6jvu+tWPF0sABzt9eP+lZk5fHLisrkuG6NWSThFdKkf7Qr++tSm4+8McywRHE0jRhaxhxpWGXsvjvKlQmBl3LCbCmJopAQngvMmJB23QNJUA93DvxpMpfFy/zDK7HNJ45wQRHEYcymYgU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ICJSko3a; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=W3Ly2wwo; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ICJSko3a"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="W3Ly2wwo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784623569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j1h/8U8rGpm6km9e/8IbvCjZFi5T4w4REAp5AhAlIpE=; b=ICJSko3ax9oDOQ4UCJ236jp41OBwXMyp8t9/njji9e5vei0rKVaqOHD47ugZ094eCVFfdr HAkif5OgR8OtIA8CJmehPnFQnRG0Hkfpa5Tjjeg1f/DQNXrw8Fd72IXb6uUkYU497w3Dri A3rgwkIfowF6JrF4rYT3wZmqAoAy5E4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-106-szWn16UOMrqwSN1QnUkzlw-1; Tue, 21 Jul 2026 04:46:07 -0400 X-MC-Unique: szWn16UOMrqwSN1QnUkzlw-1 X-Mimecast-MFC-AGG-ID: szWn16UOMrqwSN1QnUkzlw_1784623567 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4926fa2cb17so33281305e9.1 for ; Tue, 21 Jul 2026 01:46:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784623566; x=1785228366; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=j1h/8U8rGpm6km9e/8IbvCjZFi5T4w4REAp5AhAlIpE=; b=W3Ly2wwooicru2zoLyt+mIu9plU5QtHLTq4vhGYoypG4d8IVmd4nagqhuJ1+f4zVeh AFHBr+KzzsTfcV4SLNgBww/6Lrfp2jQwIfwjoaQKosFgWxZU509pfRinRXFpwVX46RSL IEGphSXqSywsIErBm2zmXVXeLBaplLTCgb6UGkMI2iVKCZA6VMgmT4M5CR9CVZx5ENvU w9vsP2AS65Hm1QWrY+pk/8HTUS+j0WM3+AMkqQqfuGikfHuvElZPTm+VbWMFBWwaVC6z W0dt5G+MdZ73nsmIpJc2Qt0/UHBg/qscD7kZHbPCtCLIg8HRM2uK06FjM799KoX3Odck qorg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784623566; x=1785228366; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=j1h/8U8rGpm6km9e/8IbvCjZFi5T4w4REAp5AhAlIpE=; b=sKVxyP/cp4bu/wJUcRuVHmOj5eMKzniHCo0glYxDXewNtLs2R8Kgg8jCi7+Zw/pZsx CjV9ujijwjNcMvay0tDsepBA/D8VKfGFS+FZ/8MnOVcIQzA2h3yT4SO3PntvXCuxeCN/ 7rV5v9uEM4sA8G98/4Fgj0+HuVLdb7jDOJbDfutwNu2PksyegbUh46/OWM8urpe2KFp5 3UJN2rE7epoZuTOLxtNPz1Ms6cEqssasgOInf/12wy1rTRq3CyRFQL4TxsR7/Zep+2fI mCWpiqTYQTFvddVbrnQig8EghulDSXfbcHPMxDPJVdbUMHvcz2MYyy/iZE1JGaJ61gGS gOVw== X-Forwarded-Encrypted: i=1; AHgh+RqJInkvzhW2vCNQKHx4Xk8+gl/ALM3M+vdnCyIPghSeaxAdZ5OZU1yMRzhpGtn/mUZc9Vii1gUdOQyCRxg=@vger.kernel.org X-Gm-Message-State: AOJu0YyUco8sj7JU37kMVvam3QqbH2CSNbtFssOMPvUx+Wd71a+LOick Rkn4UY6nBnZVY7hdadtA1FyLKmBVoKbr6DowjpPf8KJFH8UdGvbl1vRejSsYqKWkaXFVoOehjti wR3WGsswWHkd6oUdYHS6UfL6rpwL8QGG2q0U/FmmtbMaOOlA9TyxCLXTQEsDj2Qtxiw== X-Gm-Gg: AfdE7cmFwN01iAU8DwmY3kwPe1pwEHOJ9flmY4N3LVGXg3zzkT+H4ooPEV0kDOmmSpq 0gfeO09YbBUKhWf8MJ2Y8s6K4NmNqVjr5PQU76IYOEfuWYrjCrZZsp+EwxkDbHK8YTt/eiEMZ85 45jiUc1VsYOsThDt9QbBhDfeJ9ad2v4XNCfjViTwdeB8QNYLdOlmmz3sXe25YQj8gvXrystiJuf Vr94QHEHd2D9aHAXclklBWctMGZtjP7wO4FNO5hZv7i0oYybPGc7Xm9CsQHqQWcp3mBLZ1imeZ/ juuRM0hnEJIPy53e06ZWJwsIUCgm4mmCVV1UCVyFK/RDHgtlK5LSLAxTxM4PC4YVCbUCoJFsK0D eWD8+99XywAJP85Mm2ExO6CxMx4qsCO3RTLhaFsnz63WmRGTwmwoPlRdfDOUCl+c5NzuAsKIQ/Z b30w== X-Received: by 2002:a05:600c:3485:b0:495:6193:c6c0 with SMTP id 5b1f17b1804b1-49561a30bb3mr70804945e9.18.1784623566644; Tue, 21 Jul 2026 01:46:06 -0700 (PDT) X-Received: by 2002:a05:600c:3485:b0:495:6193:c6c0 with SMTP id 5b1f17b1804b1-49561a30bb3mr70804755e9.18.1784623566185; Tue, 21 Jul 2026 01:46:06 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:58fd:68f:7756:389d? ([2a0d:3344:5521:6b10:58fd:68f:7756:389d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-495499d1d4asm227108515e9.2.2026.07.21.01.46.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 01:46:05 -0700 (PDT) Message-ID: <4793400b-958d-429d-b2db-d39b7d757338@redhat.com> Date: Tue, 21 Jul 2026 10:46:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 10/13] net: phy: add generic helpers for direct C45 MMD access To: Selvamani Rajagopal , "ciprian.regus@analog.com" , Parthiban Veerasooran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , Jonathan Corbet , Shuah Khan , Andrew Lunn , Heiner Kallweit , Russell King , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , "devicetree@vger.kernel.org" References: <20260708-adin1140-driver-v5-0-4aca7b51a58b@analog.com> <20260708-adin1140-driver-v5-10-4aca7b51a58b@analog.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/9/26 4:29 AM, Selvamani Rajagopal wrote: > >> +int genphy_read_mmd_c45(struct phy_device *phydev, int devnum, u16 regnum) >> +{ >> + struct mii_bus *bus = phydev->mdio.bus; >> + int addr = phydev->mdio.addr; > > You may want to insert the lockdep_assert here. That'll ensure that read/write APIs are called > after the mdio-lock is taken. Andrew's suggestion. > > lockdep_assert_held(&bus->mdio_lock) Since this looks like the only pending item and has no functional implication, I think it's better handled as a (separate) follow-up. /P