From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A22D10940 for ; Thu, 5 Dec 2024 00:44:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733359481; cv=none; b=QX5YLooL4+bOiCp7PQHYaytzNCRUKmJ1uhDwbtqZ0xDuaEAYyaw0V38jr+BLoz+7MN10f+qbSxMeQnvroODLSm3YlduC1Xdx96ojPqmkiifXuAuuw5/3CYrr8sH4L42UTDLDia7eoB0znHF01OhJF/SnCzLXIxbOOWaXU7E+Rjw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733359481; c=relaxed/simple; bh=RfWODQeCQ92PKzUdEskZeQY10PlkpbDGFWN1YWWpNow=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=ZLDpQaD98Ze6wiYetzLyNuuDvwDwoAiymBHllzQUwJP3MV2L0+7/iQZknzfOblHydwzQl5k867tVIHo+P/j2N/MyJDVnaNW4FhxRmZ/5YfwuGQiBid/qLOfE9TI3/hKurkQXN+7J2UThHQzoN2NIAw7ODO5NdZhabKHw6myy3pk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=CgL5lU4P; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="CgL5lU4P" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3ea33a922afso135808b6e.3 for ; Wed, 04 Dec 2024 16:44:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1733359478; x=1733964278; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=rZU+yuC4IUNNrcZsdQdOWRd6MVYrt80tZt42Hj7Odpo=; b=CgL5lU4PiFH3Zh26mHpXbCWV5ZZSDsnjORx5YEo+8k2N6k9OsjCNHSvqy1c1oONKNc jKW7Gur/n4/TqbytgUX7dJ5PTLUtIzI0GLYJWJkpTevZsz9X+01/+yeZesMkmiyf+Uph JXWXpQMzOabtoRCIQabrIXeT8DGG6uTJGZpLuwkFlCPzWiZb1yozEtAGg67efINQ/cUT fgIokJKF9jK8SZVDw/gIffl+0TaySIYZiGHQ3gZzAhGrNOAqd5WzwdrdcY5/Gk1vlFDP e+4SbMkopRQxKVNEdkfDjoWktt/hKfzNYW5LwGKnhcfG4HW0I2EU/mEXEQ+lFX9mLpMV zriA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733359478; x=1733964278; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rZU+yuC4IUNNrcZsdQdOWRd6MVYrt80tZt42Hj7Odpo=; b=cDl2NMIYE3ZXd9KBiA3WA9eMm3TorBTy359ESKfv3ckx91t1UPKZFVdtHyaFl2sPI4 bDYb763DdHqd7LY6nlul0Ibh9UuktlhjRMGxfboexUCfwJP6h2OlfVW76AGRKY6k/NoI YTksATeVgXCMI/XS/1yHtqpScSSaj2N8F3qunjxE5LOObd1eYizNlYQb3IpP5BfGvKUE 7XzSXOQWfuwf6awr3JBgPZqsvPsZbC3h28zPq0AUZM/BShemgVecj1f/rVPFky7i//9X 222ldIIArpAjGnHYzIECrnLGIzRL0uYdAwPZZUIRl6wglqjVMlerQUDZwRkHWS17kzSI Mdbg== X-Forwarded-Encrypted: i=1; AJvYcCWQYsCiRoXOhnaDclDMh96g8TBZy9OExNcD+56QKiLJdqYDQ83q+HIopGE1RmFYY63Wo/4adCDVgYePDj4=@vger.kernel.org X-Gm-Message-State: AOJu0YyN6pgr7YeIaIhUjBSefhH/3gMF8u41LjoIWRNu1orb+vl+P7/o G1WmeSo8hXVfKlQSPl93PSjeofFAi3gcj96jTKw/btBbYz1soqtwaBTbhJmZcBo= X-Gm-Gg: ASbGnctB3lYZODAx6i20Y3W8/rSOfCjXpPBspD0iQEpWDNp1r2phRR48WL/qqS7OcrY 7wG1fOHVv4UaCBVYNhJr3DN77l27StQC2OYZvxCS+PP081fui/aZd9QKUDLYfQzwx8rm1V0JsbH 5uxJjNqY0Pnifvx7ujtdWxkxTHKMw3afWDo/2DQJ5f5AzDoUtTVNLawJpH592mtoLH0xEMQ2vK8 6qZVRQHqqNzylJ5mQpuhlzpMJEVDKMXJabG/QJ98XxUMp6bs1p/sCFtPjQWtVjniEwYkn8r3dDB rLWjmIJtyGs= X-Google-Smtp-Source: AGHT+IHaFElNJBo9YhzTZTzxYaqVWuPDKa7rUFNx4+15yLQ0Bvjs2W04jhZERCIQ6ow85bmA48lGYg== X-Received: by 2002:a05:6830:6516:b0:718:16c8:3c02 with SMTP id 46e09a7af769-71dad6f0756mr5814100a34.29.1733359478045; Wed, 04 Dec 2024 16:44:38 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-29f56945d20sm104623fac.35.2024.12.04.16.44.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2024 16:44:36 -0800 (PST) Message-ID: <4795d5b2-2d6d-4d81-a57b-dc28d217aacf@baylibre.com> Date: Wed, 4 Dec 2024 18:44:34 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 3/8] iio: backend: add API for oversampling To: Antoniu Miclaus , jic23@kernel.org, robh@kernel.org, conor+dt@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org References: <20241129153546.63584-1-antoniu.miclaus@analog.com> <20241129153546.63584-4-antoniu.miclaus@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <20241129153546.63584-4-antoniu.miclaus@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/29/24 9:35 AM, Antoniu Miclaus wrote: > Add backend support for enabling/disabling oversampling. > > Signed-off-by: Antoniu Miclaus > --- > changes in v7: > - implement 2 callbacks > iio_backend_oversampling_enable() > iio_backend_oversampling_disable() I think Jonathan's suggestion from a previous review to pass the oversampling ratio instead of enable/disable seems like a good idea for making this more generic. int iio_backend_set_oversampling_ratio(struct iio_backend *back, u32 ratio); To answer Jonathan's question [1] about why does the backend need to know if oversampling is enabled or not... In this case, it looks like it changes some timing (the conversion quiet time) on the LVDS/CMOS serial data lines depending on if oversampling is enabled or not. [1]: https://lore.kernel.org/linux-iio/20241123160559.56c57fc7@jic23-huawei/