From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73A19C2ED; Tue, 26 Nov 2024 01:42:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732585324; cv=none; b=uumhB0kIwawHlZEu/N+s/DXITsNLWF4PrYE+sZ+QNtxY31UJMDaGiNM1ESvhLVlwY4m1gtW/6OcdmRSalxK8T+w+NwaCfohzCE0uqYBeuShSpx9vWq3os37eRwI+6OnyEx7PYi93G6CkoD6zGW1u9GgpVHX43nGQGt05RxAZars= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732585324; c=relaxed/simple; bh=V9JLCV0CQPqPzHFk9aNIcJW65kUbABH0A/OJEthAq3M=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=Lnh2K1mZ72Ls87wpHvglZNM3xes6k2gEE8jBjWXw2uKO2htBmGD9/jGsfrcRilaSlnakjhMnHe7eGKB6S+A7KjSQqb7+FBpcx3x8idsrey7nhe+HGQQu5iVKseE2A8tx2yzU3t6MCKOJCshJ9lnHxSs2PVi8d9/s42twHqC30G8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=aKRynTBf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="aKRynTBf" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4APEAii4000996; Tue, 26 Nov 2024 01:41:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xC8LsOhOKhtFlMr6+pMsh3+JxF3b8PDqZdseL10V6ZQ=; b=aKRynTBfoT6iH0sM v5hNSualczhiSzOepHrWJ7jwL4gkAAnlodb3Tg+S31ukec611nTXGF2KsgfFVIAG A9UGiVToooRuPbCnGtvsDiD32rpwFictuDxyyDETX4ZMGMVXCftxrZVNQgn2tUJK XB3lIaKq/6hlAdFh6IaOEOMaK6iBIM9ZcybUeYAxYDB+zjmu7kH2xrGu5mXAN2ZB XtvWNmEb4QCh/OTtT+t1kKyFC8zawUfusOuEH8RqNhjGOzAeWHSLrxcFgZBDsNrn 3s6EWsyROxUThOnI8GyS4Z0OyUFvZIQ587c+pS0XXf5qjfvfsm3UgPnzOWqqejnm nAJ4Ug== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 434ts1hdv8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Nov 2024 01:41:42 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4AQ1fgLO030259 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Nov 2024 01:41:42 GMT Received: from [10.64.16.151] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 25 Nov 2024 17:41:35 -0800 Message-ID: <4799eab5-2238-41d4-bb55-9dd63080e604@quicinc.com> Date: Tue, 26 Nov 2024 09:41:32 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/9] drm/msm/dsi: Add support for SM6150 To: Dmitry Baryshkov CC: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , "Krishna Manikandan" , Bjorn Andersson , Konrad Dybcio , "Catalin Marinas" , Will Deacon , Li Liu , Xiangxu Yin , , , , , , References: <20241122-add-display-support-for-qcs615-platform-v3-0-35252e3a51fe@quicinc.com> <20241122-add-display-support-for-qcs615-platform-v3-7-35252e3a51fe@quicinc.com> Content-Language: en-US From: fange zhang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: CzQG4YMlEQ62zgJOgVX6sVpjEHlUdVWt X-Proofpoint-ORIG-GUID: CzQG4YMlEQ62zgJOgVX6sVpjEHlUdVWt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 mlxlogscore=999 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 phishscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411260013 On 2024/11/26 6:11, Dmitry Baryshkov wrote: > On Mon, 25 Nov 2024 at 04:31, fange zhang wrote: >> >> >> >> On 2024/11/22 18:10, Dmitry Baryshkov wrote: >>> On Fri, Nov 22, 2024 at 05:56:50PM +0800, Fange Zhang wrote: >>>> From: Li Liu >>>> >>>> Add support for DSI 2.3.1 (block used on SM6150). >>>> >>>> Signed-off-by: Li Liu >>>> Signed-off-by: Fange Zhang >>>> --- >>>> drivers/gpu/drm/msm/dsi/dsi_cfg.c | 4 +++- >>>> drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + >>>> 2 files changed, 4 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c >>>> index 10ba7d153d1cfc9015f527c911c4658558f6e29e..fe02724bddf69c2e8d6816589f4ea410fa666e5b 100644 >>>> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c >>>> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c >>>> @@ -171,7 +171,7 @@ static const struct msm_dsi_config sdm845_dsi_cfg = { >>>> .num_bus_clks = ARRAY_SIZE(dsi_v2_4_clk_names), >>>> .io_start = { >>>> { 0xae94000, 0xae96000 }, /* SDM845 / SDM670 */ >>>> - { 0x5e94000 }, /* QCM2290 / SM6115 / SM6125 / SM6375 */ >>>> + { 0x5e94000 }, /* QCM2290 / SM6115 / SM6125 / SM6150 / SM6375 */ >>> >>> Not true >> Should I remove it or add it behind the SDM670? > > You should not be sending patches which provide false information. Why > did you add it to the wrong line in the first place? sorry i missed it, will remove it in next patch > >>> >>>> }, >>>> }; >>>> >>>> @@ -286,6 +286,8 @@ static const struct msm_dsi_cfg_handler dsi_cfg_handlers[] = { >>>> &sdm845_dsi_cfg, &msm_dsi_6g_v2_host_ops}, >>>> {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_3_0, >>>> &sdm845_dsi_cfg, &msm_dsi_6g_v2_host_ops}, >>>> + {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_3_1, >>>> + &sdm845_dsi_cfg, &msm_dsi_6g_v2_host_ops}, >>>> {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_4_0, >>>> &sdm845_dsi_cfg, &msm_dsi_6g_v2_host_ops}, >>>> {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_4_1, >>>> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.h b/drivers/gpu/drm/msm/dsi/dsi_cfg.h >>>> index 4c9b4b37681b066dbbc34876c38d99deee24fc82..120cb65164c1ba1deb9acb513e5f073bd560c496 100644 >>>> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.h >>>> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.h >>>> @@ -23,6 +23,7 @@ >>>> #define MSM_DSI_6G_VER_MINOR_V2_2_0 0x20000000 >>>> #define MSM_DSI_6G_VER_MINOR_V2_2_1 0x20020001 >>>> #define MSM_DSI_6G_VER_MINOR_V2_3_0 0x20030000 >>>> +#define MSM_DSI_6G_VER_MINOR_V2_3_1 0x20030001 >>>> #define MSM_DSI_6G_VER_MINOR_V2_4_0 0x20040000 >>>> #define MSM_DSI_6G_VER_MINOR_V2_4_1 0x20040001 >>>> #define MSM_DSI_6G_VER_MINOR_V2_5_0 0x20050000 >>>> >>>> -- >>>> 2.34.1 >>>> >>> >> > >