From: Steven Toth <stoth@linuxtv.org>
To: Adrian Bunk <bunk@kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Steven Toth <stoth@hauppauge.com>,
v4l-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org
Subject: Re: [v4l-dvb-maintainer] [2.6 patch] dvb/frontends/xc5000.c: make a struct static
Date: Mon, 28 Jan 2008 17:38:17 -0500 [thread overview]
Message-ID: <479E5959.1010601@linuxtv.org> (raw)
In-Reply-To: <20080128221030.GP8767@does.not.exist>
Adrian Bunk wrote:
> struct XC5000_Standard[] can become static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Reviewed-by: Steven Toth <stoth@hauppauge.com>
Thanks Adrian.
Mauro, please merge.
- Steve
>
> ---
> e1f9c8304c807ecce026156ee2185925295fe835
> diff --git a/drivers/media/dvb/frontends/xc5000.c b/drivers/media/dvb/frontends/xc5000.c
> index f642ca2..a5094b7 100644
> --- a/drivers/media/dvb/frontends/xc5000.c
> +++ b/drivers/media/dvb/frontends/xc5000.c
> @@ -151,7 +151,7 @@ typedef struct {
> #define FM_Radio_INPUT2 21
> #define FM_Radio_INPUT1 22
>
> -XC_TV_STANDARD XC5000_Standard[MAX_TV_STANDARD] = {
> +static XC_TV_STANDARD XC5000_Standard[MAX_TV_STANDARD] = {
> {"M/N-NTSC/PAL-BTSC", 0x0400, 0x8020},
> {"M/N-NTSC/PAL-A2", 0x0600, 0x8020},
> {"M/N-NTSC/PAL-EIAJ", 0x0440, 0x8020},
>
>
> _______________________________________________
> v4l-dvb-maintainer mailing list
> v4l-dvb-maintainer@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer
prev parent reply other threads:[~2008-01-28 23:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 22:10 Adrian Bunk
2008-01-28 22:38 ` Steven Toth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479E5959.1010601@linuxtv.org \
--to=stoth@linuxtv.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=stoth@hauppauge.com \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome