From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Willy Tarreau <w@1wt.eu>
Cc: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>,
Ingo Molnar <mingo@elte.hu>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/7] X86: Fix trailing statements should be on next line
Date: Tue, 29 Jan 2008 13:43:21 +0100 [thread overview]
Message-ID: <479F1F69.5000206@s5r6.in-berlin.de> (raw)
In-Reply-To: <20080128230746.GL8953@1wt.eu>
Willy Tarreau wrote:
> Hi Paolo,
>
> On Tue, Jan 29, 2008 at 12:07:44AM +0100, Paolo Ciarrocchi wrote:
>> Fix trailing statements should be on next line
>
>> -if ( partial_status & SW_C3 ) printk("SW: condition bit 3\n");
...
>> +if ( partial_status & SW_Backward )
>> +printk("SW: backward compatibility\n");
...
>
> Well, IMHO, the code was more readable and checkable in the initial
> version. I think this is one example of exceptions where code appearance
> is more important than style correctness.
Besides, the proposed style "fix" itself violates CodingStyle in at
least two obvious ways.
--
Stefan Richter
-=====-==--- ---= ===-=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2008-01-29 12:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 23:07 Paolo Ciarrocchi
2008-01-28 23:07 ` Willy Tarreau
2008-01-29 12:43 ` Stefan Richter [this message]
2008-02-01 16:21 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479F1F69.5000206@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paolo.ciarrocchi@gmail.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome