From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 7/7] fix lines over 80 characters
Date: Tue, 29 Jan 2008 13:46:04 +0100 [thread overview]
Message-ID: <479F200C.1020709@s5r6.in-berlin.de> (raw)
In-Reply-To: <20080129000810.42d0d6f0@paolo-desktop>
Paolo Ciarrocchi wrote:
> --- a/arch/x86/math-emu/errors.c
> +++ b/arch/x86/math-emu/errors.c
> @@ -75,7 +75,8 @@ void FPU_printall(void)
> FPU_get_user(FPU_modrm, 1 + (u_char __user *) address);
>
> if (FPU_modrm >= 0300)
> - printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8, FPU_modrm & 7);
> + printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8,
> + FPU_modrm & 7);
> else
> printk(KERN_ERR " /%d, mod=%d rm=%d\n",
> (FPU_modrm >> 3) & 7, (FPU_modrm >> 6) & 3, FPU_modrm & 7);
> @@ -309,7 +310,8 @@ asmlinkage void FPU_exception(int n)
> printk(KERN_ERR "FPU emulator: Unknown Exception: 0x%04x!\n", n);
>
> if (n == EX_INTERNAL) {
> - printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n", int_type);
> + printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n",
> + int_type);
> FPU_printall();
> }
> #ifdef PRINT_MESSAGES
The "fix" is still not conforming to CodingStyle.
Besides, why don't you leave these lines as they are? There is no
important information hidden behind the 80th column in the existing code.
--
Stefan Richter
-=====-==--- ---= ===-=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2008-01-29 12:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 23:08 Paolo Ciarrocchi
2008-01-29 12:46 ` Stefan Richter [this message]
2008-01-31 22:54 ` Paolo Ciarrocchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479F200C.1020709@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paolo.ciarrocchi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®