mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Oliver Neukum <oliver@neukum.org>, Greg KH <greg@kroah.com>,
	Matthew Dharm <mdharm-usb@one-eyed-alien.net>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-scsi@vger.kernel.org
Subject: Re: [BUG] 2.6.24-git usb reset problems
Date: Tue, 29 Jan 2008 21:09:59 +0200	[thread overview]
Message-ID: <479F7A07.8080204@panasas.com> (raw)
In-Reply-To: <20080129183910.GI15220@kernel.dk>

On Tue, Jan 29 2008 at 20:39 +0200, Jens Axboe <jens.axboe@oracle.com> wrote:
> On Tue, Jan 29 2008, Jens Axboe wrote:
>> On Tue, Jan 29 2008, Oliver Neukum wrote:
>>> Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe:
>>>> On Tue, Jan 29 2008, Boaz Harrosh wrote:
>>>>> On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <jens.axboe@oracle.com> wrote:
>>>>>> On Tue, Jan 29 2008, Boaz Harrosh wrote:
>>>>>>> Greg KH wrote:
>>>  
>>>>>> No difference, still just a lot of resets.
>>>>>>
>>>>> Where you able to figure out which usb storage transport is used?
>>>>>
>>>>> in drivers/usb/storage/usb.c you have get_protocol() and get_transport()
>>>>> functions. I'm not sure if these get stored in sysfs perhaps. This will
>>>>> pinpoint better where to look. Let me research a bit. 
>>>> Did the quick'n easy and dumped it. Protocol is 'Transparent SCSI' and
>>>> transport is 'Bulk'
>>> You can recompile your kernel with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG
>>> That should tell the reason for the resets.
>> Sure, I'll do that. Will post the results tonight.
> 
> OK, fresh boot with CONFIG_USB_DEBUG and CONFIG_STORAGE_DEBUG. Plugged
> in the device, waited 10 seconds or so and pulled it out. These are the
> messages.
> 
> It all looks good until the MODE_SENSE command, where it only transfers
> 4 of 192 bytes.
> 
<snip>
> usb-storage: Command MODE_SENSE (6 bytes)
> usb-storage:  1a 00 3f 00 c0 00
> usb-storage: Bulk Command S 0x43425355 T 0x4 L 192 F 128 Trg 0 LUN 0 CL 6
> usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes
> usb-storage: Status code 0; transferred 31/31
> usb-storage: -- transfer complete
> usb-storage: Bulk command transfer result=0
> usb-storage: usb_stor_bulk_transfer_sglist: xfer 192 bytes, 1 entries
> usb-storage: Status code -121; transferred 4/192
> usb-storage: -- short read transfer
> usb-storage: Bulk data transfer result 0x1
> usb-storage: Attempting to get CSW...
<snip>

I get something similar but better:
usb-storage: Command MODE_SENSE (6 bytes)
usb-storage:  1a 00 3f 00 c0 00
usb-storage: Bulk Command S 0x43425355 T 0x6 L 192 F 128 Trg 0 LUN 0 CL 6
usb-storage: usb_stor_bulk_transfer_buf: xfer 31 bytes
usb-storage: Status code 0; transferred 31/31
usb-storage: -- transfer complete
usb-storage: Bulk command transfer result=0
usb-storage: usb_stor_bulk_transfer_sglist: xfer 192 bytes, 1 entries
usb-storage: Status code -121; transferred 36/192
usb-storage: -- short read transfer
usb-storage: Bulk data transfer result 0x1
usb-storage: Attempting to get CSW...

So I get 36 bytes, then code goes on into one reset, and every thing is then
fine.

Could you put us out of our mesery and revert that patch:
[SCSI] usb: transport - convert to accessors and !use_sg code path removal
(6d416e6173394defda5933e419e805b696681b7e)

to make sure this is it. I hate to do this to you, but I cannot reproduce the
failure down here. If it works please send a log with the debugs on perhaps
we can compare.

You will need to configure out the CONFIG_USB_STORAG_* they will not compile
you should have only have CONFIG_USB_STORAGE & CONFIG_USB_STORAGE_DEBUG. it should
support your HW.


Thanks Jens
Boaz



  reply	other threads:[~2008-01-29 19:10 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-28 20:49 Jens Axboe
2008-01-28 21:21 ` Greg KH
2008-01-29  7:48   ` Jens Axboe
2008-01-29 12:15   ` Boaz Harrosh
2008-01-29 13:54     ` Jens Axboe
2008-01-29 14:06       ` Boaz Harrosh
2008-01-29 14:11         ` Jens Axboe
2008-01-29 14:14           ` Boaz Harrosh
2008-01-29 14:31           ` Oliver Neukum
2008-01-29 14:31             ` Jens Axboe
2008-01-29 18:39               ` Jens Axboe
2008-01-29 19:09                 ` Boaz Harrosh [this message]
2008-01-29 19:10                 ` Matthew Dharm
2008-01-29 19:15                   ` Jens Axboe
2008-01-29 19:26                     ` Jens Axboe
2008-01-29 19:37                     ` Matthew Dharm
2008-01-29 19:33                   ` James Bottomley
2008-01-29 19:35                     ` Jens Axboe
2008-01-29 19:45                       ` Jens Axboe
2008-01-29 19:58                         ` Boaz Harrosh
2008-01-29 20:03                           ` Jens Axboe
2008-01-29 20:04                             ` James Bottomley
2008-01-29 20:06                               ` Jens Axboe
2008-01-29 20:24                                 ` James Bottomley
2008-01-29 20:53                                   ` Boaz Harrosh
2008-01-29 20:09                           ` Boaz Harrosh
2008-01-29 20:13                             ` Jens Axboe
2008-01-29 20:26                               ` Boaz Harrosh
2008-01-30 10:27                         ` Geert Uytterhoeven
2008-01-30 10:38                           ` Jens Axboe
2008-01-30 14:38                             ` James Bottomley
2008-01-30 18:06                               ` Jens Axboe
2008-01-30 19:07                                 ` Jens Axboe
2008-01-29 15:50             ` Boaz Harrosh
2008-01-29 17:42               ` Oliver Neukum
2008-01-29 14:13         ` Boaz Harrosh
2008-01-29 15:00     ` Matthew Dharm
2008-01-29 15:36     ` Alan Stern
2008-01-29 15:54       ` Boaz Harrosh
2008-01-29 16:34       ` James Bottomley
2008-01-29 18:27         ` Boaz Harrosh
2008-01-29 18:48           ` James Bottomley
2008-01-29 18:58             ` Boaz Harrosh
2008-01-29 19:17               ` James Bottomley
2008-01-29 19:28                 ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=479F7A07.8080204@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=greg@kroah.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mdharm-usb@one-eyed-alien.net \
    --cc=oliver@neukum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome