From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BE0419AD8B for ; Fri, 11 Jul 2025 16:15:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752250561; cv=none; b=usH3Gbds+Rur8/z53TvcnGrio+jFA/k24ULZXPLfnp/QJEEJ7Ota13lQXQHyAiMS4EKUUljhqPqE+795mghi5Bdl0uJ1LakqxgbsaNEzaAUaLwjMjsdHoRCxunQuj0FX8is2b/84Y02W1Rkl7HvBbXRrqvpWIJAVxqXhWShnx+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752250561; c=relaxed/simple; bh=GaTXTSHhNy3zov9cV9sYYuEC/xhj+9jFrbDYc2p4QMU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mYw8s+ye0vC3DUPLn4gqYognk712kiAdlvQGO2ssJ/RAf3JM+oGFXE0rFwRdFo/58lvkAdhW4VkT5bbBPfmcU82wAFcHChsLKKNXVr13gAFWqupmJknRzyU95M9GM2a5WhwizWo8TzU2GV1CIKM6ZxbawGOASbPL+tPXJh+NA9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TSvrJguq; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TSvrJguq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752250557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=B4PdbUTlAoNvyMFKR6OePMk99FSDqKOEu6bezLg3CZ0=; b=TSvrJguq8OScg/QqQqOLgPS3rcai0efWVL8s7Ygn7X0Fy77U5QxlkgkyeCJaFyU64DmC2S kZarP+Kp9UwPKaSnhYuH6XtEe/kT9EIKGCK3KCjMu1xarbShukqzI0s+e7hMckxOw67mcC Xrg3tlbeaWe3EqEGvf4C+1zZZnHvnuc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-qaULdDRYMs6JjsUJWtxL1g-1; Fri, 11 Jul 2025 12:15:56 -0400 X-MC-Unique: qaULdDRYMs6JjsUJWtxL1g-1 X-Mimecast-MFC-AGG-ID: qaULdDRYMs6JjsUJWtxL1g_1752250555 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4538f375e86so18157495e9.3 for ; Fri, 11 Jul 2025 09:15:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752250555; x=1752855355; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=B4PdbUTlAoNvyMFKR6OePMk99FSDqKOEu6bezLg3CZ0=; b=XUMQN8UXCOOAm3VS4jlLpJ9VgE2U4G2suxv4swmA9eKhBYOhxIRM3dfZrdk+UrwZh3 AqlVkG0E63KlcnV82zsYnWlNEKnilAfNKbTTqMhUg/5WZp/d6dwgiERxKz7jDrHp64b0 a71C3wmOSrmuy7VJ2GhnM6c0wfRoCbB6loDujioe7mncQFkTri+InTodfEmt9NfNaJn0 kwN+snWFufRNfnUNmtWgiICvrGQSxh3r8RBg1Dd3MiAcvozK9IKry/JkDDn6jMTcaXz2 ezWjW1N3b/82Vn++OWhzTXK3A0ASaCz1lXIK6oCamI4PyTwVtetyIuoTTACrp33cnGww VI3g== X-Forwarded-Encrypted: i=1; AJvYcCXHJkvHkhZD8KWE8L34wrk3ZJXmXX9u6lMh2C564hko0ABuDrQlC7q9dVXhlHPXKCB96aErVyq/MBeuHfk=@vger.kernel.org X-Gm-Message-State: AOJu0YyRXp5Q3fyY8dvltnKIG6WfctCcVLGB8cRhZSAV7MR/Ml3ke09Q 72gj0cy/cVnX1Rh/skiGSsJvPn+BX8SyDSJKVxR1I1hQsfrJGXf/uqHexUf7Nzwf6NHdTFT8TKU wnNcLk+F/jETq5CcTAuKkDsKNwJ2KYIwRS16M7U11AYugFqXTNy+0D+L8PtMzUviwcwldPWQeCw Wl X-Gm-Gg: ASbGncvcNVJ+Ii+dijNuT0+CzdX3zIjduomR4jEBAjsofF5iUAvDZejF/iSoGxGZjB9 M3SQ1gPEneh18EhSoskyTZAMjm6O0J75Py9HGwAeMpqsIEdNvSPnWf1uDE2O97NiLudzlOvAZjr sEMQf4/KNm6f33YLCESKbqnu/QO9mZaHdUoY691v2hKUHozQsy9ffodvCN9M2hRymAUa+wl/PMn nOd0lJogOggNiulmitxu9cJ2XynyUhmWbaI+as39RmQuYuKnsvj8WjgszfD2//XD97sGzEDdpVf JQunYq3hqunW3rKvzpMTfx97/ejHl8fWycXSfV8cO68bl8iPmPePeHwd+uDdoQ0FOzKBRFWqQ7w pqdzcsaBIJbtVIIlqppNBdtzQfzAeDO1CBXPJ+3C2FT2pGhUH75fmJBKWqJx2TfAucQo= X-Received: by 2002:a05:600c:4684:b0:442:f97f:8174 with SMTP id 5b1f17b1804b1-454ec276b88mr40690185e9.18.1752250554849; Fri, 11 Jul 2025 09:15:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE1a5E76BIpgezsbveDVnmxTjzk9mC3/6Cc7fl4zhaGnS7tXf6VRuARN3jKkYuVE7SAT26gyA== X-Received: by 2002:a05:600c:4684:b0:442:f97f:8174 with SMTP id 5b1f17b1804b1-454ec276b88mr40689655e9.18.1752250554433; Fri, 11 Jul 2025 09:15:54 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:3a00:5662:26b3:3e5d:438e? (p200300d82f3c3a00566226b33e5d438e.dip0.t-ipconnect.de. [2003:d8:2f3c:3a00:5662:26b3:3e5d:438e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8e0d5f5sm4888486f8f.56.2025.07.11.09.15.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jul 2025 09:15:54 -0700 (PDT) Message-ID: <479b493c-92c4-424a-a5c0-1c29a4325d15@redhat.com> Date: Fri, 11 Jul 2025 18:15:52 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] readahead: Use folio_nr_pages() instead of shift operation To: Chi Zhiling , willy@infradead.org, akpm@linux-foundation.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chi Zhiling , Ryan Roberts References: <20250710060451.3535957-1-chizhiling@163.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250710060451.3535957-1-chizhiling@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10.07.25 08:04, Chi Zhiling wrote: > From: Chi Zhiling > > folio_nr_pages() is faster helper function to get the number of pages > when NR_PAGES_IN_LARGE_FOLIO is enabled. > > Signed-off-by: Chi Zhiling > --- > mm/readahead.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/readahead.c b/mm/readahead.c > index 95a24f12d1e7..406756d34309 100644 > --- a/mm/readahead.c > +++ b/mm/readahead.c > @@ -649,7 +649,7 @@ void page_cache_async_ra(struct readahead_control *ractl, > * Ramp up sizes, and push forward the readahead window. > */ > expected = round_down(ra->start + ra->size - ra->async_size, > - 1UL << folio_order(folio)); > + folio_nr_pages(folio)); > if (index == expected) { > ra->start += ra->size; > /* This should probably get squashed in Ryans commit? LGTM -- Cheers, David / dhildenb