From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Christoph Hellwig <hch@infradead.org>,
"Christopher M. Riedl" <cmr@codefail.de>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH 1/8] powerpc/uaccess: Add unsafe_copy_from_user
Date: Fri, 16 Oct 2020 15:18:08 +0200 [thread overview]
Message-ID: <479b67b8-0caf-ebcb-433d-5739d71bdadf@csgroup.eu> (raw)
In-Reply-To: <20201016065403.GA9343@infradead.org>
Le 16/10/2020 à 08:54, Christoph Hellwig a écrit :
> On Thu, Oct 15, 2020 at 10:01:52AM -0500, Christopher M. Riedl wrote:
>> Implement raw_copy_from_user_allowed() which assumes that userspace read
>> access is open. Use this new function to implement raw_copy_from_user().
>> Finally, wrap the new function to follow the usual "unsafe_" convention
>> of taking a label argument. The new raw_copy_from_user_allowed() calls
>> __copy_tofrom_user() internally, but this is still safe to call in user
>> access blocks formed with user_*_access_begin()/user_*_access_end()
>> since asm functions are not instrumented for tracing.
>
> Please also add a fallback unsafe_copy_from_user to linux/uaccess.h
> so this can be used as a generic API.
>
I guess this can be done in a separate patch independant of that series ?
Christophe
next prev parent reply other threads:[~2020-10-16 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201015150159.28933-1-cmr@codefail.de>
[not found] ` <20201015150159.28933-2-cmr@codefail.de>
2020-10-16 6:54 ` Christoph Hellwig
2020-10-16 13:18 ` Christophe Leroy [this message]
[not found] ` <20201015150159.28933-4-cmr@codefail.de>
2020-10-16 6:56 ` [PATCH 3/8] powerpc: Mark functions called inside uaccess blocks w/ 'notrace' Christoph Hellwig
2020-10-16 9:41 ` Peter Zijlstra
2020-10-20 7:34 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479b67b8-0caf-ebcb-433d-5739d71bdadf@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=cmr@codefail.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®