From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C0D9CE79BF for ; Wed, 20 Sep 2023 10:15:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234145AbjITKPK (ORCPT ); Wed, 20 Sep 2023 06:15:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233999AbjITKPH (ORCPT ); Wed, 20 Sep 2023 06:15:07 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C2F4AD for ; Wed, 20 Sep 2023 03:15:00 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-986d8332f50so918927266b.0 for ; Wed, 20 Sep 2023 03:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695204899; x=1695809699; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9mZqf86pDWOD/601uuBDOEbjatLYGf0C2OZfOrIlKtE=; b=kmXu4C8kZ0hGAg1DeVAt7O2XiyWjG3Z16TRyluuSySQJ0sxmuLRTdOJAdK4BRBevyc gNLxDRSGpe1I7ERvpHUzNMVEbsNiKM0qPb8Ut4MNdHp+bZEpFas9FvGpGLqBmcYoetmm DrZom8VzBqvSWRTMxf0iJgTfaj0vQ1oEc9HmJ3d1FB1rbQKz6Oz7adGx5iSJF9SCd67H tkYKRLN+XdPL+BKkNvkzWr4GExQiluuBItwNmocJaIxHQis2vn3oxtSK/lHRvfe0g2BJ XV2NrCpEWa3gQwfMU12DO5Mb5yHATdwk+TvW5C4/T2dWWRh0i5sPYkBiVmK5sXvLpjwJ gw+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695204899; x=1695809699; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9mZqf86pDWOD/601uuBDOEbjatLYGf0C2OZfOrIlKtE=; b=Zew98ofaRcjF73UHV1KZilRSePpAVe9tpXiodQY5EPdsUvz+6wHBjWMje+7muCPA/r T2VC0crTnkRIDFa9+rrAFdLUPsec8qaq76cU0rBq6tdCpw0eRTED5zFVOtZxq3VUB7SS z54NkJi0e1w62V3Krw0mr1pkNLF2sxkXbLlc7NxVnE1Tv10s9++2bJ4MJnrAinddDbjT j/rVphzKBGWq2j0M5rhDR9pdhBL1ap24I2yIlf9XuEhxPkHqceW8fq7ED83mWwU4DfA0 ZkBWhS6Iy8eh/7nzGrSJXfEDy9QlCRDAGy423d6bj2yR44Ci8T+2XEPACRA3cxVNCj+O VVaA== X-Gm-Message-State: AOJu0YzYdYWQgJfXOTGAJH5Vo8RO1XDTzXAuMF8T+o4QMz1WUhjD9dnO jgTl274Z2Vd+Eyf0HcN6bqTeNg== X-Google-Smtp-Source: AGHT+IErDzQjZ+K58/UpSu8O8qdmGRhWMWecc+OmIf04JHEc3evawqV8aeI1xjeHIg0cpLMPHURYYw== X-Received: by 2002:a17:907:a0c6:b0:9a1:688f:cf2d with SMTP id hw6-20020a170907a0c600b009a1688fcf2dmr1475764ejc.39.1695204898449; Wed, 20 Sep 2023 03:14:58 -0700 (PDT) Received: from [172.20.86.172] (static-212-193-78-212.thenetworkfactory.nl. [212.78.193.212]) by smtp.gmail.com with ESMTPSA id re20-20020a170906d8d400b0099bc8bd9066sm9199112ejb.150.2023.09.20.03.14.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Sep 2023 03:14:58 -0700 (PDT) Message-ID: <479ce1da-10e5-589d-cb98-e7fef98c5543@linaro.org> Date: Wed, 20 Sep 2023 12:14:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v3 2/5] arm64: dts: qcom: sm4450: Add apps_rsc and cmd_db node Content-Language: en-US To: Tengfei Fan , agross@kernel.org, andersson@kernel.org, tglx@linutronix.de, maz@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org Cc: geert+renesas@glider.be, arnd@arndb.de, neil.armstrong@linaro.org, nfraprado@collabora.com, rafal@milecki.pl, peng.fan@nxp.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, quic_tsoni@quicinc.com, quic_shashim@quicinc.com, quic_kaushalk@quicinc.com, quic_tdas@quicinc.com, quic_tingweiz@quicinc.com, quic_aiquny@quicinc.com, quic_ajipan@quicinc.com, kernel@quicinc.com References: <20230920065459.12738-1-quic_tengfan@quicinc.com> <20230920065459.12738-3-quic_tengfan@quicinc.com> From: Konrad Dybcio In-Reply-To: <20230920065459.12738-3-quic_tengfan@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/20/23 08:54, Tengfei Fan wrote: > From: Ajit Pandey > > Add apps_rsc node and cmd_db memory region for sm4450. > > Signed-off-by: Ajit Pandey > Signed-off-by: Tengfei Fan > --- > arch/arm64/boot/dts/qcom/sm4450.dtsi | 35 ++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm4450.dtsi b/arch/arm64/boot/dts/qcom/sm4450.dtsi > index c4e5b33f5169..3d9d3b5e9510 100644 > --- a/arch/arm64/boot/dts/qcom/sm4450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm4450.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > / { > interrupt-parent = <&intc>; > @@ -328,6 +329,18 @@ > }; > }; > > + reserved_memory: reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + aop_cmd_db_mem: cmd-db@80860000 { > + compatible = "qcom,cmd-db"; > + reg = <0x0 0x80860000 0x0 0x20000>; > + no-map; > + }; > + }; > + > soc: soc@0 { > #address-cells = <2>; > #size-cells = <2>; > @@ -419,6 +432,28 @@ > status = "disabled"; > }; > }; > + > + apps_rsc: rsc@17a00000 { > + compatible = "qcom,rpmh-rsc"; > + reg = <0 0x17a00000 0 0x10000>, > + <0 0x17a10000 0 0x10000>, > + <0 0x17a20000 0 0x10000>; 0x0 for consistency > + reg-names = "drv-0", "drv-1", "drv-2"; > + interrupts = , > + , > + ; > + label = "apps_rsc"; > + qcom,tcs-offset = <0xd00>; > + qcom,drv-id = <2>; > + qcom,tcs-config = , , > + , ; You haven't addressed Bjorn's comment about the number of CONTROL_TCSes, are you sure 0 is correct? Konrad