From: Gavin Shan <gshan@redhat.com>
To: Zenghui Yu <yuzenghui@huawei.com>, maz@kernel.org
Cc: Haibin Wang <wanghaibin.wang@huawei.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: arm/arm64: vgic: Drop the kvm_vgic_register_mmio_region()
Date: Mon, 20 Jan 2020 09:47:57 +1100 [thread overview]
Message-ID: <479f2e5f-80c4-37e1-8f3a-2f1197fddd51@redhat.com> (raw)
In-Reply-To: <20200119090604.398-1-yuzenghui@huawei.com>
On 1/19/20 8:06 PM, Zenghui Yu wrote:
> kvm_vgic_register_mmio_region() was introduced in commit 4493b1c4866a
> ("KVM: arm/arm64: vgic-new: Add MMIO handling framework") but never
> used, and even never implemented. Remove it to avoid confusing readers.
>
> Reported-by: Haibin Wang <wanghaibin.wang@huawei.com>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
Reviewed-by: Gavin Shan <gshan@redhat.com>
> virt/kvm/arm/vgic/vgic-mmio.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/virt/kvm/arm/vgic/vgic-mmio.h b/virt/kvm/arm/vgic/vgic-mmio.h
> index 836f418f1ee8..5af2aefad435 100644
> --- a/virt/kvm/arm/vgic/vgic-mmio.h
> +++ b/virt/kvm/arm/vgic/vgic-mmio.h
> @@ -98,11 +98,6 @@ extern struct kvm_io_device_ops kvm_io_gic_ops;
> .uaccess_write = uwr, \
> }
>
> -int kvm_vgic_register_mmio_region(struct kvm *kvm, struct kvm_vcpu *vcpu,
> - struct vgic_register_region *reg_desc,
> - struct vgic_io_device *region,
> - int nr_irqs, bool offset_private);
> -
> unsigned long vgic_data_mmio_bus_to_host(const void *val, unsigned int len);
>
> void vgic_data_host_to_mmio_bus(void *buf, unsigned int len,
>
prev parent reply other threads:[~2020-01-19 22:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 9:06 Zenghui Yu
2020-01-19 22:47 ` Gavin Shan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479f2e5f-80c4-37e1-8f3a-2f1197fddd51@redhat.com \
--to=gshan@redhat.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=wanghaibin.wang@huawei.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®