mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Thomas Dahlmann" <thomas.dahlmann@amd.com>
To: "Roel Kluin" <12o3l@tiscali.nl>
Cc: info-linux@geode.amd.com, "lkml" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][drivers/usb/gadget/amd5536udc.c] duplicate use_dma_ppb_du => 2nd use_dma_ppb
Date: Thu, 31 Jan 2008 11:30:13 +0100	[thread overview]
Message-ID: <47A1A335.9090400@amd.com> (raw)
In-Reply-To: <47A08FD5.20105@tiscali.nl>

This fix is correct.

Thanks,
Thomas

Roel Kluin wrote:
> Untested patch below, please confirm it's the right fix.
> --
> duplicate use_dma_ppb_du, 2nd should be use_dma_ppb
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
> index c72e962..fbc10f9 100644
> --- a/drivers/usb/gadget/amd5536udc.c
> +++ b/drivers/usb/gadget/amd5536udc.c
> @@ -205,7 +205,7 @@ static void print_regs(struct udc *dev)
>  		DBG(dev, "DMA mode       = PPBNDU (packet per buffer "
>  			"WITHOUT desc. update)\n");
>  		dev_info(&dev->pdev->dev, "DMA mode (%s)\n", "PPBNDU");
> -	} else if (use_dma && use_dma_ppb_du && use_dma_ppb_du) {
> +	} else if (use_dma && use_dma_ppb && use_dma_ppb_du) {
>  		DBG(dev, "DMA mode       = PPBDU (packet per buffer "
>  			"WITH desc. update)\n");
>  		dev_info(&dev->pdev->dev, "DMA mode (%s)\n", "PPBDU");
>
>
>   




      reply	other threads:[~2008-01-31 10:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30 14:55 Roel Kluin
2008-01-31 10:30 ` Thomas Dahlmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47A1A335.9090400@amd.com \
    --to=thomas.dahlmann@amd.com \
    --cc=12o3l@tiscali.nl \
    --cc=info-linux@geode.amd.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome