From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760224AbYBNQ3k (ORCPT ); Thu, 14 Feb 2008 11:29:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755097AbYBNQ3b (ORCPT ); Thu, 14 Feb 2008 11:29:31 -0500 Received: from rtr.ca ([76.10.145.34]:3374 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753329AbYBNQ33 (ORCPT ); Thu, 14 Feb 2008 11:29:29 -0500 Message-ID: <47B46C68.6050904@rtr.ca> Date: Thu, 14 Feb 2008 11:29:28 -0500 From: Mark Lord Organization: Real-Time Remedies Inc. User-Agent: Thunderbird 2.0.0.9 (X11/20071031) MIME-Version: 1.0 To: Tejun Heo Cc: Andrew Morton , jeff@garzik.org, linux-ide@vger.kernel.org, jengelh@computergmbh.de, matthew@wil.cx, randy.dunlap@oracle.com, daniel.ritz-ml@swissonline.ch, linux-kernel@vger.kernel.org Subject: Re: [PATCHSET] printk: implement printk_header() and merging printk, take #3 References: <12028937731333-git-send-email-htejun@gmail.com> <20080213155701.48871761.akpm@linux-foundation.org> <47B38E13.1060503@gmail.com> In-Reply-To: <47B38E13.1060503@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tejun Heo wrote: >.. > * For timeouts, result TF isn't available and thus res printout is > misleading. res shouldn't be printed after timeouts. This would > require allocating yest another temp buf and separating out res printing > into separate snprintf. .. And snprintf() is buggy, by the way. It does not always seem to return the correct character fill counts. I've given up trying to use it here for anything in kernelspace that *must* work. Someday I'll go back and try to figure out where it's screwing up. I think it is doing so in the cases where it runs out of space in the buffer. -ml