Re: Geode GX/LX watchdog timer (RESEND)

[Arnd Hannemann <hannemann@i4.informatik.rwth-aachen.de>]

Iain Paton schrieb:
> Adrian Bunk wrote:
>> On Sun, Feb 17, 2008 at 03:46:01PM +0100, Arnd Hannemann wrote:
>>> Never tried to built it as a module.
>>> Probably there are issues with that. If I remember correctly I saw a
>>> patch in 2.6.25-rc which
>>> mentioned that using mfgpt in modules won't work. Does this apply to
>>> 2.6.24 as well?
>>
>> For using code from modules it must be explicitely
>> EXPORT_SYMBOL{,GPL}'ed.
>>
>> Adding
>>   EXPORT_SYMBOL_GPL(geode_mfgpt_toggle_event);
>> and
>>   EXPORT_SYMBOL_GPL(geode_mfgpt_alloc_timer);
>> below the respective functions in mfgpt_32.c should fix this issue.
> 
> I couldn't find the patch Arnd mentioned on lkml or in Linus git tree,
> but adding the lines suggested by Adrian gets me a working module.


I meant commit fa28e067c3b8af96c79c060e163b1387c172ae75 in linus git, but seems
I misinterpreted it.

>     x86: GEODE: MFGPT: drop module owner usage from MFGPT API
>     
>     We had planned to use the 'owner' field for allowing re-allocation of
>     MFGPTs; however, doing it by module owner name isn't flexible enough.  So,
>     drop this for now.  If it turns out that we need timers in modules, we'll
>     need to come up with a scheme that matches the write-once fields of the
>     MFGPTx_SETUP register, and drops ponies from the sky.
>     
>     Signed-off-by: Andres Salomon <dilinger@debian.org>
>     Signed-off-by: Jordan Crouse <jordan.crouse@amd.com>
>     Signed-off-by: Ingo Molnar <mingo@elte.hu>
>     Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Best regards,
Arnd