mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Paul Mackerras <paulus@samba.org>
Cc: Ingo Molnar <mingo@elte.hu>, Shi Weihua <shiwh@cn.fujitsu.com>,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Roland McGrath <roland@redhat.com>,
	torvalds@linux-foundation.org
Subject: Re: [PATCH 1/5] signal(x86_32): Improve the signal stack overflow check
Date: Tue, 19 Feb 2008 15:25:12 -0800	[thread overview]
Message-ID: <47BB6558.4020201@zytor.com> (raw)
In-Reply-To: <18363.25743.402510.695150@cargo.ozlabs.ibm.com>

Paul Mackerras wrote:
> Ingo Molnar writes:
>> * Shi Weihua <shiwh@cn.fujitsu.com> wrote:
>>
>>> We need to check for stack overflow only when the signal is on stack. 
>>> So we can improve the patch "http://lkml.org/lkml/2007/11/27/101" as 
>>> following.
>> thanks, applied.
> 
> These patches change the behaviour of programs that longjmp out of a
> signal handler on an alternate stack, don't they?
> 
> I'm interested to know what gave you confidence that changing that
> behaviour won't break existing working programs.
> 

Shouldn't such programs use sigsetjmp/siglongjmp, which should reset the 
signal stack state?

	-hpa

  reply	other threads:[~2008-02-19 23:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-18 10:22 Shi Weihua
2008-02-18 13:47 ` Ingo Molnar
2008-02-19  0:58   ` Shi Weihua
2008-02-19 18:50     ` Roland McGrath
2008-02-20  0:49       ` Shi Weihua
2008-02-20  1:18         ` Roland McGrath
2008-02-20  1:35           ` Shi Weihua
2008-02-20  1:44             ` Roland McGrath
2008-02-20  2:23               ` Shi Weihua
2008-02-20  2:49                 ` Roland McGrath
2008-02-20  2:59                   ` Shi Weihua
2008-02-20  5:54                   ` Harvey Harrison
2008-02-20  7:59                     ` Roland McGrath
2008-02-20 10:27                   ` Ingo Molnar
2008-02-18 18:05 ` Valdis.Kletnieks
2008-02-19  2:11   ` Shi Weihua
2008-02-19  2:19 ` Shi Weihua
2008-02-19 11:05   ` Ingo Molnar
2008-02-19 23:21     ` Paul Mackerras
2008-02-19 23:25       ` H. Peter Anvin [this message]
2008-02-20  0:03         ` Roland McGrath
2008-02-20  0:04       ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47BB6558.4020201@zytor.com \
    --to=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=roland@redhat.com \
    --cc=shiwh@cn.fujitsu.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome