Dave Young ¾´ ±Û: > On Mon, Feb 25, 2008 at 5:28 PM, Louis JANG wrote: > >> > I ever asked marcel about the coding style. please see following thread: >> > http://lkml.org/lkml/2008/1/22/91 >> > >> > I think the style problem marcel said is >> > 1. using kernel codeing style >> > 2. marcel's style >> > container_of or get_user_data calls at the top of the variable declaration >> > using the empty lines to seperate code blocks >> > >> > Please rework your patch and resend if you fixed them. >> > >> > BTW, please use the new bluetooth mailing list for kerne issue. >> > linux-bluetooth@vger.kernel.org >> > >> > (Thanks for andrew and davem) >> > >> > Regards >> > dave >> > >> > Regards >> > dave >> > >> > >> >> Hi all, >> >> I adjusted indentation of the patches >> > > Not enough. > > Please first read Documentation/CodingStyle, fix them, and > then use scripts/checkpatch.pl to check your patch. > I fixed all of errors except 80 characters warning. Thanks Louis JANG