From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: benh@kernel.crashing.org
Cc: Kristian Hoegsberg <krh@bitplanet.net>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
sparclinux@vger.kernel.org,
linux1394-devel@lists.sourceforge.net,
Sam Ravnborg <sam@ravnborg.org>,
Harvey Harrison <harvey.harrison@gmail.com>
Subject: Re: [PATCH 1/2] firewire: endianess fix
Date: Thu, 28 Feb 2008 09:41:20 +0100 [thread overview]
Message-ID: <47C673B0.2070705@s5r6.in-berlin.de> (raw)
In-Reply-To: <1204166506.15052.336.camel@pasglop>
Benjamin Herrenschmidt wrote:
> Do we have the workaround for the old Apple UniNorth in the new FW OHCI
> driver (for selfID swapping iirc ?)
According to ohci1394.c, it selfIDs and headers of incoming packets are
not byte-swapped by the old Apple Uninorth FireWire part. And no,
firewire-ohci doesn't have the workaround yet.
It should be trivial to copy'n'paste ohci1394's workaround into fw-ohci,
but it would be good if someone could test before and after.
BTW, since that code is touched everytime a packet is received, we
should enclose such a workaround in #ifdef CONFIG_PPC_PMAC &&
CONFIG_PPC32, shouldn't we? (As a second step after adding the workaround.)
--
Stefan Richter
-=====-==--- --=- ===--
http://arcgraph.de/sr/
next prev parent reply other threads:[~2008-02-28 8:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 22:03 sparse - make __CHECK_ENDIAN__ default enabled? Sam Ravnborg
2008-02-20 22:18 ` Harvey Harrison
2008-02-23 11:23 ` [PATCH 0/2] firewire: endinaness warnings (was Re: sparse - make __CHECK_ENDIAN__ default enabled?) Stefan Richter
2008-02-23 11:24 ` [PATCH 1/2] firewire: endianess fix Stefan Richter
2008-02-23 11:36 ` Stefan Richter
2008-02-23 12:12 ` Stefan Richter
2008-03-01 12:36 ` Stefan Richter
2008-02-27 19:58 ` Jarod Wilson
2008-02-27 20:08 ` Stefan Richter
2008-02-27 20:21 ` Jarod Wilson
2008-02-28 2:40 ` Benjamin Herrenschmidt
2008-02-28 3:21 ` Jarod Wilson
2008-02-28 6:25 ` Benjamin Herrenschmidt
2008-02-28 18:42 ` Jarod Wilson
2008-02-28 23:26 ` Benjamin Herrenschmidt
2008-02-29 5:48 ` Jarod Wilson
2008-02-29 6:00 ` Benjamin Herrenschmidt
2008-02-29 11:26 ` Paul Mackerras
2008-02-29 11:52 ` Stefan Richter
2008-02-29 21:49 ` Benjamin Herrenschmidt
2008-02-29 15:34 ` Jarod Wilson
2008-03-03 9:19 ` Gabriel Paubert
2008-03-03 14:35 ` Stefan Richter
2008-03-05 22:59 ` Gabriel Paubert
2008-03-05 23:26 ` Stefan Richter
2008-03-06 20:23 ` Gabriel Paubert
2008-02-28 3:33 ` Jarod Wilson
2008-02-28 2:41 ` Benjamin Herrenschmidt
2008-02-28 8:41 ` Stefan Richter [this message]
2008-02-23 11:24 ` [PATCH 2/2] firewire: endianess annotations Stefan Richter
2008-03-01 5:23 ` [PATCH 0/2] firewire: endinaness warnings (was Re: sparse - make __CHECK_ENDIAN__ default enabled?) Jarod Wilson
2008-02-20 22:39 ` sparse - make __CHECK_ENDIAN__ default enabled? Harvey Harrison
2008-02-20 22:51 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C673B0.2070705@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=benh@kernel.crashing.org \
--cc=harvey.harrison@gmail.com \
--cc=krh@bitplanet.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®