From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>, Pavel Emelyanov <xemul@openvz.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH rc5-mm1 1/3] mm-have-zonelist: fix memcg ooms
Date: Wed, 12 Mar 2008 13:08:11 +0530 [thread overview]
Message-ID: <47D78863.101@linux.vnet.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0803112108470.17067@blonde.site>
Hugh Dickins wrote:
> Memcgroups up against their limit were OOMing unjustifiably on x86_32
> with highmem: pages ripe for freeing were not being found.
>
> It's because the zonelist changes in vmscan.c now derive zone from gfp_mask,
> and the gfp mask being passed into try_to_free_mem_cgroup_pages is atuned
> to allocating a struct page_cgroup (__GFP_HIGHMEM masked off), whereas here
> we need to be scanning highmem zones.
>
Very good catch. I see a high_zoneidx field being derived from gfp_mask -mm.
I've been looking at mainline code too often.
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
next prev parent reply other threads:[~2008-03-12 7:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-11 21:12 Hugh Dickins
2008-03-11 21:14 ` [PATCH rc5-mm1 2/3] just return do_try_to_free_pages Hugh Dickins
2008-03-12 13:58 ` Mel Gorman
2008-03-11 21:16 ` [PATCH rc5-mm1 3/3] do_try_to_free_pages gfp_mask redundant Hugh Dickins
2008-03-12 14:04 ` Mel Gorman
2008-03-12 7:38 ` Balbir Singh [this message]
2008-03-12 12:29 ` [PATCH rc5-mm1 1/3] mm-have-zonelist: fix memcg ooms Mel Gorman
2008-03-12 13:34 ` Hugh Dickins
2008-03-12 13:55 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D78863.101@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®