From: Pavel Emelyanov <xemul@openvz.org>
To: Andre Noll <maan@systemlinux.org>,
"David S. Miller" <davem@davemloft.net>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
LKML <linux-kernel@vger.kernel.org>,
Benjamin Thery <benjamin.thery@bull.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Fix permissions of /proc/net
Date: Thu, 20 Mar 2008 10:56:31 +0300 [thread overview]
Message-ID: <47E218AF.2030402@openvz.org> (raw)
In-Reply-To: <20080319115135.GM32242@skl-net.de>
Andre Noll wrote:
> commit f205a545ee62e0f0f797c1e2b0bd2062d96414b3
> Author: Andre Noll <maan@congo.fml.local>
> Date: Wed Mar 19 11:39:55 2008 +0100
>
> From: Andre Noll <maan@systemlinux.org>
>
> commit e9720ac ([NET]: Make /proc/net a symlink on /proc/self/net (v3))
> broke ganglia and probably other applications that read /proc/net/dev.
This also broke the postfix, as it was reported in bug #10286
and described in detail by Benjamin.
> This is due to the change of permissions of /proc/net that was
> introduced in that commit.
>
> Before: dr-xr-xr-x 5 root root 0 Mar 19 11:30 /proc/net
> After: dr-xr--r-- 5 root root 0 Mar 19 11:29 /proc/self/net
>
> This patch restores the permissions to the old value which makes ganglia
> happy again.
And it fixes the problem reported by Benjamin.
Thanks, Andre!
> Signed-off-by: Andre Noll <maan@systemlinux.org>
Acked-by: Pavel Emelyanov <xemul@openvz.org>
> diff --git a/fs/proc/base.c b/fs/proc/base.c
> index 8a10f6f..81d7d14 100644
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -2290,7 +2290,7 @@ static const struct pid_entry tgid_base_stuff[] = {
> DIR("fd", S_IRUSR|S_IXUSR, fd),
> DIR("fdinfo", S_IRUSR|S_IXUSR, fdinfo),
> #ifdef CONFIG_NET
> - DIR("net", S_IRUGO|S_IXUSR, net),
> + DIR("net", S_IRUGO|S_IXUGO, net),
> #endif
> REG("environ", S_IRUSR, environ),
> INF("auxv", S_IRUSR, pid_auxv),
next prev parent reply other threads:[~2008-03-20 7:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 11:51 Andre Noll
2008-03-20 7:56 ` Pavel Emelyanov [this message]
2008-03-20 22:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E218AF.2030402@openvz.org \
--to=xemul@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=benjamin.thery@bull.net \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maan@systemlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome