mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: "Artem S. Tashkinov" <birdie@permonline.ru>
Cc: Jan Engelhardt <jengelh@computergmbh.de>, linux-kernel@vger.kernel.org
Subject: Re: GIT commit description flag(s)
Date: Thu, 20 Mar 2008 12:06:40 +0100	[thread overview]
Message-ID: <47E24540.4050804@s5r6.in-berlin.de> (raw)
In-Reply-To: <47E09F53.5020201@permonline.ru>

Artem S. Tashkinov wrote:
> I quite agree with you that the description is already there, but such 
> flags could help easily review or grep commits in order to identify your 
> areas of interest.
> 
> Even your example has ambiguity: "Wire up new timerfd syscalls" - It's 
> not easy to understand whether this particular commit is a bugfix, or it 
> speeds up things, or the old code which has been cleaned up, etc.

The fundamental problems
  - people sometimes chose bad summaries,
  - we can't always predict the full impact of the patch,
  - what's important for me isn't for you
cannot be solved by your proposed flags.

They can only be solved by
  - reviewing patches WRT good changelogs,
  - writing up extra summary release notes for areas of interest
    after the fact.

>>> It would be nice if [kernel] git commits had a flag [a char] (or a
>>> combination of) describing their main purpose which could be the
>>> following:
>>>
>>> bug Fix [F]
>>> Speed up/Performance [S]
>>> Revert [R]
>>> New functionality [N]

New bug [B]
Attempted bug fix which doesn't really work, a.k.a. nice Try [T]
Performance regression, a.k.a Downgrade [D]
-- 
Stefan Richter
-=====-==--- --== =-=--
http://arcgraph.de/sr/

      reply	other threads:[~2008-03-20 11:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-15 21:35 Artem S. Tashkinov
2008-03-16 10:09 ` Johannes Weiner
2008-03-18 16:58 ` Jan Engelhardt
2008-03-19  5:06   ` Artem S. Tashkinov
2008-03-20 11:06     ` Stefan Richter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47E24540.4050804@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=birdie@permonline.ru \
    --cc=jengelh@computergmbh.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®