From: Roel Kluin <12o3l@tiscali.nl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: nickpiggin@yahoo.com.au, lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH -mm] likely_prof: update to test_and_set_bit_lock / clear_bit_unlock
Date: Fri, 04 Apr 2008 13:27:41 +0200 [thread overview]
Message-ID: <47F610AD.8070202@tiscali.nl> (raw)
Because the _lock routines are faster and provide a better example to follow.
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
As suggested by Nick Piggin. To be applied after Daniels likeliness patches
and my previous likeliness-accounting-change-and-cleanup.patch,
The patch was checkpatch.pl, compile, sparse and run tested (uml).
diff --git a/lib/likely_prof.c b/lib/likely_prof.c
index c9a8d1d..0da3181 100644
--- a/lib/likely_prof.c
+++ b/lib/likely_prof.c
@@ -36,7 +36,7 @@ int do_check_likely(struct likeliness *likeliness, unsigned int ret)
* disable and it was a bit cleaner then using internal __raw
* spinlock calls.
*/
- if (!test_and_set_bit(0, &likely_lock)) {
+ if (!test_and_set_bit_lock(0, &likely_lock)) {
if (likeliness->label & LP_UNSEEN) {
likeliness->label &= (~LP_UNSEEN);
likeliness->next = likeliness_head;
@@ -44,8 +44,7 @@ int do_check_likely(struct likeliness *likeliness, unsigned int ret)
likeliness->caller = (unsigned long)
__builtin_return_address(0);
}
- smp_mb__before_clear_bit();
- clear_bit(0, &likely_lock);
+ clear_bit_unlock(0, &likely_lock);
}
}
reply other threads:[~2008-04-04 11:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F610AD.8070202@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome