From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E42EBC432C0 for ; Mon, 25 Nov 2019 10:47:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C362C20740 for ; Mon, 25 Nov 2019 10:47:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727857AbfKYKrK (ORCPT ); Mon, 25 Nov 2019 05:47:10 -0500 Received: from ozlabs.org ([203.11.71.1]:38755 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727830AbfKYKrH (ORCPT ); Mon, 25 Nov 2019 05:47:07 -0500 Received: by ozlabs.org (Postfix, from userid 1034) id 47M3d43gCcz9sRD; Mon, 25 Nov 2019 21:47:04 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 77693a5fb57be4606a6024ec8e3076f9499b906b In-Reply-To: To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , npiggin@gmail.com, hch@infradead.org From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/4] powerpc/fixmap: Use __fix_to_virt() instead of fix_to_virt() Message-Id: <47M3d43gCcz9sRD@ozlabs.org> Date: Mon, 25 Nov 2019 21:47:04 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-09-12 at 13:49:42 UTC, Christophe Leroy wrote: > Modify back __set_fixmap() to using __fix_to_virt() instead > of fix_to_virt() otherwise the following happens because it > seems GCC doesn't see idx as a builtin const. > > CC mm/early_ioremap.o > In file included from ./include/linux/kernel.h:11:0, > from mm/early_ioremap.c:11: > In function ‘fix_to_virt’, > inlined from ‘__set_fixmap’ at ./arch/powerpc/include/asm/fixmap.h:87:2, > inlined from ‘__early_ioremap’ at mm/early_ioremap.c:156:4: > ./include/linux/compiler.h:350:38: error: call to ‘__compiletime_assert_32’ declared with attribute error: BUILD_BUG_ON failed: idx >= __end_of_fixed_addresses > _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) > ^ > ./include/linux/compiler.h:331:4: note: in definition of macro ‘__compiletime_assert’ > prefix ## suffix(); \ > ^ > ./include/linux/compiler.h:350:2: note: in expansion of macro ‘_compiletime_assert’ > _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) > ^ > ./include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’ > #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) > ^ > ./include/linux/build_bug.h:50:2: note: in expansion of macro ‘BUILD_BUG_ON_MSG’ > BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) > ^ > ./include/asm-generic/fixmap.h:32:2: note: in expansion of macro ‘BUILD_BUG_ON’ > BUILD_BUG_ON(idx >= __end_of_fixed_addresses); > ^ > > Signed-off-by: Christophe Leroy > Fixes: 4cfac2f9c7f1 ("powerpc/mm: Simplify __set_fixmap()") Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/77693a5fb57be4606a6024ec8e3076f9499b906b cheers