From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A70C819B5B1 for ; Sat, 8 Aug 2026 05:18:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786166310; cv=none; b=I5GlPWhJVwiZQZr4keslQI3QqUG+/nFJ0Qn2YyiIM9gvkOVFsi7NcJ359D+JQ3T3A4rWtQb/PiZNbdtfmKwQ9uyFPqp8vzODsPuLdOKp4UbOnWFh929RTYwMUx+fr+Pt2Is4h6JFmnmpZ4rBHIY8J+2LWZSQ+/kiI/VqQhW8Hno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786166310; c=relaxed/simple; bh=e1KD8zoraLjog2njrsX2zkpMHC24yAUgHxLM38jjGf4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U5VD0KNuE95LJKNIjvGc4qpNj5wkIh2vpNYJZpJCIPbniMy8qQCjFVmlV1FXH4zbiRE89YBsn1NHICkHj5phTzaaUPSlwkQTFPtpto7OBEgiRfFs0JB7og7/cq45gQSJ3EdLjnTv15tivKO8NdDi2tjLwIVARRrymLugd34dRYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Hd8XNQBg; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Hd8XNQBg" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4995b0343c1so1967975e9.3 for ; Fri, 07 Aug 2026 22:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786166306; x=1786771106; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JJhvRbAgbyNO89YM7BEIHxWEebN9b6RcPSHpLs6/nDU=; b=Hd8XNQBgA8USILsrl89vmRmywInuKKhJFpnIabcdauiMq9OMYOoCBJAB9FFmySF4Kn Uk0vFkVXG9w95lziIYL+ja2dkFR3nROP88+OhZUWHYW/pXgmMNzaUjVFm6XrvWYlsTBw Whrjpbq/AVX0N5kHibW20gNKvkdt5gcUe5rhyNHcPDeIwGrRaJ2wsH2sp2LG8fb7Vu5M sVPiNEip+iocy6WKSSvjVisYKGHcZt1AuiNcBKe7EbRS9470BtGG/H4p0qrHVSd/bwyB 7SSfklPoXje1Sb//Wjttz7QAt0WUegHRbogVxg0xyuf7cZgSdLP2uOQrkgqHpc7TcE3M CfXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786166306; x=1786771106; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JJhvRbAgbyNO89YM7BEIHxWEebN9b6RcPSHpLs6/nDU=; b=Gv54GHNOx944CQsaQL682mNGY3jWUrHgSzorOeJsZuxoc093Ryh8HW8zI8JbdLkBYS o6c1L1J8ayYerIFDKfl2yIKkggvHI1kKMAB+Y4gzecMLBxdH182I9WoxdUL2tDn5Y5WE Jc7yrFQQtJjkMgRCrC0SN/3OmHSjOYMMiQ8wO0i4R78lP8rb0ygPLC+432VGp2SfeRiu V1mqGr0OgChLlODECQXiyOYSFf+JnUYM3GKIcAckY8umSBGKUEaNdkNRwgENEewb2Pgv yeR0wRcCvOH+oPT2P2OorSNZcoui83WI48xXxdOtYCetJgx4A9Wc6ePl/JKTE3D0z9Tp +E3A== X-Forwarded-Encrypted: i=1; AHgh+Rqku6SqR2xRyGmWJ6xFqn3g51EIwmQJ8aRklRbqjxAGRnm95K3qWv6amgAAVYXsw+seWF2SpLQpBxKn9Gg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1XQFg/TIJLl00nxpvqFV07S4su+XvCVG0a7cvltYwq5NiIPxn /4NIE0Dm0rfJ9ssK+XBCFJf1N4dXqBmxjY4gXAEClecaWj4DmgJB1SxyEeWwrEhbj/8= X-Gm-Gg: AR+sD12udhQag+/VFw8RXILA8ITgcQXyYmPL4nMTshYOu+KFYoHWlASe9ACmT6uj4sl L7eY2yE3/oyNLj0dqWowH+rUAviCiL4SaSDowtxCWFU4U/78dwq65jQ69oyM+Z5Y7+2zV2ZKEco lZkAuKMn7uR7gDVQpLYjXEh0k5uiM4aTFTXl1ijJ20fZFjEIh6m8BdgYzmI7BpejHJhJy9iKSC4 mb0Ha2sZyJ/eRSPqjhZfZMsX+/BB5e4VwLv8N7kLu/I9HVaGcLUUnnR++T44/Tx5NsYzdQ6RsZW QpopxnPBEWnhu1cHksOXjfzCu9Y0K7HFaKf0b6Zdeaub6v0u/kIwS+hkLIVtrzDvS1tv5aT+2F8 jrkyt/C4eTz7b/TQXLIRt7trNoMW+1sRgQ7WqUHC/HD99WhHkb4IRUd5Hc85TrzdmqjOZskTH0v UQCzG1KZG3IvCl7FMdQErP6xTo//JtG/FqmpTZWuFcVEeUcYRY97gwlITcC4qdxMyL1w== X-Received: by 2002:a05:600c:4594:b0:499:5f7a:7ea2 with SMTP id 5b1f17b1804b1-4995f7a7ec4mr97873255e9.12.1786166305870; Fri, 07 Aug 2026 22:18:25 -0700 (PDT) Received: from [172.16.0.229] ([159.196.52.54]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315bec2ec20sm16808385eec.28.2026.08.07.22.18.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2026 22:18:24 -0700 (PDT) Message-ID: <47a4dbfb-906c-440c-999c-d6dba7981232@suse.com> Date: Sat, 8 Aug 2026 14:48:19 +0930 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] btrfs: free unlinked replace target on initialization failure To: Guanghui Yang <3497809730@qq.com>, Chris Mason , David Sterba Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Qu Wenruo Autocrypt: addr=wqu@suse.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNGFF1IFdlbnJ1byA8d3F1QHN1c2UuY29tPsLAlAQTAQgAPgIbAwULCQgHAgYVCAkKCwIE FgIDAQIeAQIXgBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXVgBQkQ/lqxAAoJEMI9kfOh Jf6o+jIH/2KhFmyOw4XWAYbnnijuYqb/obGae8HhcJO2KIGcxbsinK+KQFTSZnkFxnbsQ+VY fvtWBHGt8WfHcNmfjdejmy9si2jyy8smQV2jiB60a8iqQXGmsrkuR+AM2V360oEbMF3gVvim 2VSX2IiW9KERuhifjseNV1HLk0SHw5NnXiWh1THTqtvFFY+CwnLN2GqiMaSLF6gATW05/sEd V17MdI1z4+WSk7D57FlLjp50F3ow2WJtXwG8yG8d6S40dytZpH9iFuk12Sbg7lrtQxPPOIEU rpmZLfCNJJoZj603613w/M8EiZw6MohzikTWcFc55RLYJPBWQ+9puZtx1DopW2jOwE0EWdWB rwEIAKpT62HgSzL9zwGe+WIUCMB+nOEjXAfvoUPUwk+YCEDcOdfkkM5FyBoJs8TCEuPXGXBO Cl5P5B8OYYnkHkGWutAVlUTV8KESOIm/KJIA7jJA+Ss9VhMjtePfgWexw+P8itFRSRrrwyUf E+0WcAevblUi45LjWWZgpg3A80tHP0iToOZ5MbdYk7YFBE29cDSleskfV80ZKxFv6koQocq0 vXzTfHvXNDELAuH7Ms/WJcdUzmPyBf3Oq6mKBBH8J6XZc9LjjNZwNbyvsHSrV5bgmu/THX2n g/3be+iqf6OggCiy3I1NSMJ5KtR0q2H2Nx2Vqb1fYPOID8McMV9Ll6rh8S8AEQEAAcLAfAQY AQgAJgIbDBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXWBBQkQ/lrSAAoJEMI9kfOhJf6o cakH+QHwDszsoYvmrNq36MFGgvAHRjdlrHRBa4A1V1kzd4kOUokongcrOOgHY9yfglcvZqlJ qfa4l+1oxs1BvCi29psteQTtw+memmcGruKi+YHD7793zNCMtAtYidDmQ2pWaLfqSaryjlzR /3tBWMyvIeWZKURnZbBzWRREB7iWxEbZ014B3gICqZPDRwwitHpH8Om3eZr7ygZck6bBa4MU o1XgbZcspyCGqu1xF/bMAY2iCDcq6ULKQceuKkbeQ8qxvt9hVxJC2W3lHq8dlK1pkHPDg9wO JoAXek8MF37R8gpLoGWl41FIUb3hFiu3zhDDvslYM4BmzI18QgQTQnotJH8= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2026/8/8 14:12, Guanghui Yang 写道: > btrfs_init_dev_replace_tgtdev() allocates the replacement target before > looking up its dev_t and initializing its zoned device information. If > either lookup_bdev() or btrfs_get_dev_zone_info() fails, the device has > not been linked into fs_devices->devices yet, but the error path only > drops the block device file reference. > > Free the allocated device on this error path to release its name, > allocation state, zone info, and the device itself. > > Signed-off-by: Guanghui Yang <3497809730@qq.com> I have a very strong feeling that you're using LLM hunting down bugs. In that case, be responsible and disclose the usage of LLM. > --- > fs/btrfs/dev-replace.c | 4 ++++ > fs/btrfs/volumes.c | 2 +- > fs/btrfs/volumes.h | 1 + > 3 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c > index 318ddb790..3c17481c9 100644 > --- a/fs/btrfs/dev-replace.c > +++ b/fs/btrfs/dev-replace.c > @@ -240,6 +240,7 @@ static int btrfs_init_dev_replace_tgtdev(struct btrfs_fs_info *fs_info, > struct block_device *bdev; > u64 devid = BTRFS_DEV_REPLACE_DEVID; > int ret = 0; > + bool device_allocated = false; You can just initialize @device to NULL, and use that pointer to determine if the device is properly allocated. > > *device_out = NULL; > if (srcdev->fs_devices->seeding) { > @@ -287,6 +288,7 @@ static int btrfs_init_dev_replace_tgtdev(struct btrfs_fs_info *fs_info, > ret = PTR_ERR(device); > goto error; > } > + device_allocated = true; > > ret = lookup_bdev(device_path, &device->devt); > if (ret) > @@ -327,6 +329,8 @@ static int btrfs_init_dev_replace_tgtdev(struct btrfs_fs_info *fs_info, > return 0; > > error: > + if (device_allocated) > + btrfs_free_device(device); > bdev_fput(bdev_file); > return ret; > } > diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c > index a8e27db8e..c479f268a 100644 > --- a/fs/btrfs/volumes.c > +++ b/fs/btrfs/volumes.c > @@ -402,7 +402,7 @@ static struct btrfs_fs_devices *alloc_fs_devices(const u8 *fsid) > return fs_devs; > } > > -static void btrfs_free_device(struct btrfs_device *device) > +void btrfs_free_device(struct btrfs_device *device) > { > WARN_ON(!list_empty(&device->post_commit_list)); > /* > diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h > index eaf23c0dc..ecab3ce3c 100644 > --- a/fs/btrfs/volumes.h > +++ b/fs/btrfs/volumes.h > @@ -795,6 +795,7 @@ int btrfs_run_dev_stats(struct btrfs_trans_handle *trans); > void btrfs_rm_dev_replace_remove_srcdev(struct btrfs_device *srcdev); > void btrfs_rm_dev_replace_free_srcdev(struct btrfs_device *srcdev); > void btrfs_destroy_dev_replace_tgtdev(struct btrfs_device *tgtdev); > +void btrfs_free_device(struct btrfs_device *device); > unsigned long btrfs_full_stripe_len(struct btrfs_fs_info *fs_info, > u64 logical); > u64 btrfs_calc_stripe_length(const struct btrfs_chunk_map *map);