mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Winiarska, Iwona" <iwona.winiarska@intel.com>
To: "robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"linux@roeck-us.net" <linux@roeck-us.net>,
	"changhuang.liang@starfivetech.com"
	<changhuang.liang@starfivetech.com>
Cc: "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 3/6] peci: Add support for PECI CC 0x83 retry condition
Date: Thu, 17 Sep 2026 20:47:59 +0000	[thread overview]
Message-ID: <47a9f001f9c0f9e2be2254289c5ba3f7d64cef05.camel@intel.com> (raw)
In-Reply-To: <20260903133408.110847-4-changhuang.liang@starfivetech.com>

On Thu, 2026-09-03 at 06:34 -0700, Changhuang Liang wrote:
> Some PECI client devices may return completion code 0x83 (CMD_TIMEOUT)
> under certain conditions, which is not currently handled by the driver.

This completion code means that a command response is in progress.
It wasn't defined on older platforms.

> 
> Add PECI_CC_CMD_TIMEOUT definition and map it to -EAGAIN so that the

The definition name should be more related to the exact CC meaning, e.g.
PECI_CC_RESP_IN_PROGRESS?

Thanks
-Iwona

> request will be retried appropriately, similar to other retryable
> completion codes (0x80, 0x81, 0x82).
> 
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> ---
>  drivers/peci/request.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/peci/request.c b/drivers/peci/request.c
> index db2cc30a42a4..2bf8b6a255d4 100644
> --- a/drivers/peci/request.c
> +++ b/drivers/peci/request.c
> @@ -71,6 +71,7 @@
>  #define PECI_CC_NEED_RETRY			0x80
>  #define PECI_CC_OUT_OF_RESOURCE			0x81
>  #define PECI_CC_UNAVAIL_RESOURCE		0x82
> +#define PECI_CC_CMD_TIMEOUT			0x83
>  #define PECI_CC_INVALID_REQ			0x90
>  #define PECI_CC_MCA_ERROR			0x91
>  #define PECI_CC_CATASTROPHIC_MCA_ERROR		0x93
> @@ -112,6 +113,7 @@ int peci_request_status(struct peci_request *req)
>  	case PECI_CC_NEED_RETRY:
>  	case PECI_CC_OUT_OF_RESOURCE:
>  	case PECI_CC_UNAVAIL_RESOURCE:
> +	case PECI_CC_CMD_TIMEOUT:
>  		return -EAGAIN;
>  	case PECI_CC_INVALID_REQ:
>  		return -EINVAL;

  reply	other threads:[~2026-09-17 20:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 13:34 [PATCH v1 0/6] Add StarFive JHB100 PECI support Changhuang Liang
2026-09-03 13:34 ` [PATCH v1 1/6] dt-bindings: peci: Add StarFive JHB100 PECI controller Changhuang Liang
2026-09-03 16:35   ` Conor Dooley
2026-09-03 13:34 ` [PATCH v1 2/6] peci: controller: Add StarFive JHB100 PECI driver Changhuang Liang
2026-09-17 20:47   ` Winiarska, Iwona
2026-09-18  2:30     ` Changhuang Liang
2026-09-03 13:34 ` [PATCH v1 3/6] peci: Add support for PECI CC 0x83 retry condition Changhuang Liang
2026-09-17 20:47   ` Winiarska, Iwona [this message]
2026-09-18  2:32     ` Changhuang Liang
2026-09-03 13:34 ` [PATCH v1 4/6] peci: cpu: Add Intel Granite Rapids support Changhuang Liang
2026-09-03 13:34 ` [PATCH v1 5/6] hwmon: (peci/cputemp) Add support for Granite Rapids (GNR) Changhuang Liang
2026-09-12 14:58   ` Guenter Roeck
2026-09-12 15:13   ` Guenter Roeck
2026-09-13  3:36     ` Changhuang Liang
2026-09-17 20:49       ` Winiarska, Iwona
2026-09-17 20:48   ` Winiarska, Iwona
2026-09-18  2:33     ` Changhuang Liang
2026-09-03 13:34 ` [PATCH v1 6/6] hwmon: (peci/dimmtemp) " Changhuang Liang
2026-09-12 15:10   ` Guenter Roeck
2026-09-13  4:07     ` Changhuang Liang
2026-09-13  4:16       ` Guenter Roeck
2026-09-16  0:57         ` Changhuang Liang
2026-09-17 20:50       ` Winiarska, Iwona

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47a9f001f9c0f9e2be2254289c5ba3f7d64cef05.camel@intel.com \
    --to=iwona.winiarska@intel.com \
    --cc=changhuang.liang@starfivetech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=openbmc@lists.ozlabs.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®