From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DF621DE3DB
	for <linux-kernel@vger.kernel.org>; Fri, 20 Mar 2026 14:14:08 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1774016048; cv=none; b=gM5EAru7gjRDHk9YVkHDgQmQDf7S7mGwXoLkZ3838T6S3bGYI8mo/wYHJS2WrnBpHyuCqLbaUh3q+V1cDekAsiLc7be6qnlEeJ5WDyVQnmf9yc0ZC6xt1Gd4LEF3xUoFjiw6isa2OgF/5xLkyAzKyMLk5p7Hk1uz0QxWDC03xhg=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1774016048; c=relaxed/simple;
	bh=VLxnhPhI+BqFW3m4AViBRfkcw3Wc1Miamnuz2Hh3MGU=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=NtC9EYWOCx/rZSvR6gO8aw0PC84GWj3xNU8pWOVf9qSUQILZXkYaAnz7ssgJxki9KsQgt0bbHn8kbB/fP0hnkj/GqISBwmaqxkDoC3V1ln9+yAEej0QbWMIX13/A4tPMCqfXP2mWGg/ua/KKhR3OW5wfeE/lnaZWGotA0sekOD8=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fZCRBQDz; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fZCRBQDz"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 210F8C4CEF7;
	Fri, 20 Mar 2026 14:14:03 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1774016047;
	bh=VLxnhPhI+BqFW3m4AViBRfkcw3Wc1Miamnuz2Hh3MGU=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=fZCRBQDz58LKtCPVHZTbW7ErjfRh11V5lxfl25O6R8S0EtQ7AKIK+vJDIz7TFzRQP
	 +Qa6NGzYHEwZUzmIQ8PItMDv5CTXAK9qovEqUC/TrCARRBPieLUKCKPJY0dbVy2FIm
	 SBeOwFkiysraAFL3GZde2s5KGn3GWO9bQpzr3BnDVyNkjhvnLBrIdJkAKsGacJMgoK
	 i0XKNstZ/K5203taw70NJ2y7Vu1ks5BkxZ8drAsCSKcmGkWsJ69/EtO4lnyaP08E4B
	 JgxJ3we3LrT/e2NwbLaxRZr8gsSxUJbPJ86glZesRYrj5VDj6VhT5oubEXBCA5aApT
	 Fy+I0vUotcoDQ==
Date: Fri, 20 Mar 2026 14:14:02 +0000
From: "Lorenzo Stoakes (Oracle)" <ljs@kernel.org>
To: Kiryl Shutsemau <kirill@shutemov.name>
Cc: Andrew Morton <akpm@linux-foundation.org>, 
	David Hildenbrand <david@kernel.org>, Zi Yan <ziy@nvidia.com>, 
	Baolin Wang <baolin.wang@linux.alibaba.com>, "Liam R . Howlett" <Liam.Howlett@oracle.com>, 
	Nico Pache <npache@redhat.com>, Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>, 
	Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>, 
	Vlastimil Babka <vbabka@kernel.org>, Mike Rapoport <rppt@kernel.org>, 
	Suren Baghdasaryan <surenb@google.com>, Michal Hocko <mhocko@suse.com>, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 7/9] mm/huge_memory: deduplicate zap deposited table
 call
Message-ID: <47ab3f85-28fa-4868-b2a6-f9a33789f8fe@lucifer.local>
References: <cover.1773924928.git.ljs@kernel.org>
 <29fa4129cd560681c67433b4c344b2c9a027d1b4.1773924928.git.ljs@kernel.org>
 <abwr3EmhNZVwOkR3@thinkstation>
 <420f1b11-3b62-46dc-be33-58fbd5a4c8b3@lucifer.local>
 <abxwNW_kKakiYvsp@thinkstation>
 <81116647-1f3c-4ce9-8aea-cbe6214f7c4d@lucifer.local>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <81116647-1f3c-4ce9-8aea-cbe6214f7c4d@lucifer.local>

On Fri, Mar 20, 2026 at 02:00:04PM +0000, Lorenzo Stoakes (Oracle) wrote:
> On Thu, Mar 19, 2026 at 09:56:53PM +0000, Kiryl Shutsemau wrote:
> >
> > 	if (!vma_is_dax(vma))
> > 		has_deposit = true;
> >
> > No need in squeezing it into single line.
>
> Well part of the point here was to avoid ugly:
>
> 	Indent
> 		Indent
> 			Indent

Actually it's not too bad let's do that.

Cheers, Lorenzo