From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E52E7D0C2 for ; Fri, 22 Sep 2023 04:52:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230386AbjIVEwR (ORCPT ); Fri, 22 Sep 2023 00:52:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229737AbjIVEwN (ORCPT ); Fri, 22 Sep 2023 00:52:13 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F3001AA; Thu, 21 Sep 2023 21:52:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=jPkRHugyLd5JNXnKoygyDO0rjavXl5/MuIrj9Kx/yBo=; b=AV5rmBImlt7B6b7fh3c9eoqq0W xnzaV+n1bQ0ZF9qlLfIQHmBJOn7SbOtod6+UWwxd+4AazbgE0i7easbQVx1JzqPPfyRpcb0bHhHiv sPDVOZHH0TfWfhQETrXVdEAFtb2ABQSIVRTQqvn/nF2hFfZqwPpb9Ef2f+mWWJ2OY1/ngrAEk1ZYQ 7RYJOdGTpL3EgwmgajeENIbvxIsixvVzqb0CgSzDHEuveheGLrHpxC+Ck3agpH30IXWNoOiXoRzkj 7ud6JfOkgRToRnd1KyLLOpdDVnIPSWNAifI2vmacg88HuIGixEfI7YA+Y5phTnkTiFpwxdprmN4tu K71S+hrQ==; Received: from [2601:1c2:980:9ec0::9fed] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qjY8s-007qqE-07; Fri, 22 Sep 2023 04:51:50 +0000 Message-ID: <47afe095-0dd9-47bc-a4d1-dcd66f87ac7c@infradead.org> Date: Thu, 21 Sep 2023 21:51:47 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: linux-next: Tree for Sep 20 (ppc32: ADB_CUDA Kconfig warning) Content-Language: en-US To: Michael Ellerman , Stephen Rothwell , Linux Next Mailing List , tanyuan@tinylab.org Cc: Linux Kernel Mailing List , linuxppc-dev , Nicholas Piggin , Christophe Leroy References: <20230920133714.351f83f9@canb.auug.org.au> <87il83m5k0.fsf@mail.lhotse> From: Randy Dunlap In-Reply-To: <87il83m5k0.fsf@mail.lhotse> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/21/23 17:10, Michael Ellerman wrote: > Randy Dunlap writes: >> On 9/19/23 20:37, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20230919: >>> >>> The mm tree lost its boot warning. >>> >>> The drm-misc tree gained a conflict against Linus' tree. >>> >>> Non-merge commits (relative to Linus' tree): 6006 >>> 3996 files changed, 459968 insertions(+), 111742 deletions(-) >>> >>> ---------------------------------------------------------------------------- >> >> 4 out of 10 randconfigs have this warning: >> >> WARNING: unmet direct dependencies detected for ADB_CUDA >> Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n] >> Selected by [y]: >> - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y] >> >> WARNING: unmet direct dependencies detected for ADB_CUDA >> Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n] >> Selected by [y]: >> - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y] >> >> WARNING: unmet direct dependencies detected for ADB_CUDA >> Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n] >> Selected by [y]: >> - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y] > > Crud. Caused by: > > a3ef2fef198c ("powerpc/32: Add dependencies of POWER_RESET for pmac32") > > I was suspicious of that select, I should have been *more* suspicious :) > > I think this is a fix. The PPC32 isn't needed because ADB depends on (PPC_PMAC && PPC32). Yes, that fixes the problem. Thanks. Tested-by: Randy Dunlap Acked-by: Randy Dunlap > > diff --git a/arch/powerpc/platforms/powermac/Kconfig b/arch/powerpc/platforms/powermac/Kconfig > index 8bdae0caf21e..84f101ec53a9 100644 > --- a/arch/powerpc/platforms/powermac/Kconfig > +++ b/arch/powerpc/platforms/powermac/Kconfig > @@ -2,7 +2,7 @@ > config PPC_PMAC > bool "Apple PowerMac based machines" > depends on PPC_BOOK3S && CPU_BIG_ENDIAN > - select ADB_CUDA if POWER_RESET && PPC32 > + select ADB_CUDA if POWER_RESET && ADB > select MPIC > select FORCE_PCI > select PPC_INDIRECT_PCI if PPC32 > > cheers -- ~Randy