From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754221AbdASSY5 (ORCPT ); Thu, 19 Jan 2017 13:24:57 -0500 Received: from smtp-fw-2101.amazon.com ([72.21.196.25]:21744 "EHLO smtp-fw-2101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751622AbdASSYy (ORCPT ); Thu, 19 Jan 2017 13:24:54 -0500 X-IronPort-AV: E=Sophos;i="5.33,254,1477958400"; d="scan'208";a="637128014" Subject: Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM To: David Miller References: <1484771149-12699-1-git-send-email-vineethp@u480fcf3b67f557f68df1.ant.amazon.com> <66b10c64-936a-8001-6855-2ff1ed626642@amazon.com> <20170119.121137.735637643552808729.davem@davemloft.net> CC: , From: Vineeth Remanan Pillai Message-ID: <47b20f33-2fbe-c4f7-68dc-994073dd5105@amazon.com> Date: Thu, 19 Jan 2017 09:17:09 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170119.121137.735637643552808729.davem@davemloft.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.43.160.56] X-ClientProxiedBy: EX13D03UWA002.ant.amazon.com (10.43.160.144) To EX13D08UWC003.ant.amazon.com (10.43.162.21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/19/2017 09:11 AM, David Miller wrote: > From: Vineeth Remanan Pillai > Date: Thu, 19 Jan 2017 08:35:39 -0800 > >> From: Vineeth Remanan Pillai >> >> During an OOM scenario, request slots could not be created as skb >> allocation fails. So the netback cannot pass in packets and netfront >> wrongly assumes that there is no more work to be done and it disables >> polling. This causes Rx to stall. >> >> The issue is with the retry logic which schedules the timer if the >> created slots are less than NET_RX_SLOTS_MIN. The count of new request >> slots to be pushed are calculated as a difference between new req_prod >> and rsp_cons which could be more than the actual slots, if there are >> unconsumed responses. >> >> The fix is to calculate the count of newly created slots as the >> difference between new req_prod and old req_prod. >> >> Signed-off-by: Vineeth Remanan Pillai >> Reviewed-by: Juergen Gross >> --- >> Changes in v2: >> - Removed the old implementation of enabling polling on >> skb allocation error. >> - Corrected the refill timer logic to schedule when newly >> created slots since last push is less than NET_RX_SLOTS_MIN. > Your postings aren't showing up on vger.kernel.org at all. > > Are you getting a bounce message back? I can only assume you are triggering > one of the various content filters we have. > I haven't received any bounce messages till now. The mail showed up in xen-devel after about 8 hours yesterday. Not sure what is happening with vger.kernel.org. My initial patch showed up in all the mailing list. The only difference is, I switched to a machine running a later version of git. Should I try sending it once again? Thanks