From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754950AbdFWTkq (ORCPT ); Fri, 23 Jun 2017 15:40:46 -0400 Received: from resqmta-po-05v.sys.comcast.net ([96.114.154.164]:42990 "EHLO resqmta-po-05v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754814AbdFWTko (ORCPT ); Fri, 23 Jun 2017 15:40:44 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH v2 0/3] rtc: make st-lpc robust against y2038/2106 bug To: Benjamin Gaignard , john.stultz@linaro.org, tglx@linutronix.de, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, patrice.chotard@st.com, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, linux-arm-kernel@lists.infradead.org, rtc-linux@googlegroups.com Cc: linaro-kernel@lists.linaro.org, Shuah Khan References: <1497864982-29284-1-git-send-email-benjamin.gaignard@linaro.org> From: Shuah Khan Message-ID: <47b45b70-91da-ce41-535d-89d92f380274@kernel.org> Date: Fri, 23 Jun 2017 13:40:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1497864982-29284-1-git-send-email-benjamin.gaignard@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfP9pC0VqGo4+S5KLw/oBud2CYOMaX73W0q7RTFBt+cC8NFeWZtd4HJfZ6nQL4AMtUgVakEIZupY7w3e2Ka0ZCkXEvqlwcMw4wSGVDoXOGxs/I2gWwxp+ 4S52atHYTzOs0PQDbnULKY0msKE2/1XW5W0uk7XWc7d//VCp5rMDNaTXIbenfMmkqq15aY+XfAn71kCcH7sGlO4VhPlh3jTqgLkJ5uu7Qo8JqMkS266BmH5t iOcM3Lkd4uM9weAs2RWm1q71KWhGXDPgTI0QTywCrH5sLcgbtWitKi6WL9g+naY5ABzQcdAnCcnYbqoTXy+LECdVUopzKeC76V96fZTCTLplBkC3PKLZVoAp 8QOqonOkXnX8Lve9dJxeYKx61BfDj6vsIQpZUoRhErqdeMqOwwakkWJVVHfKHcT/pCrq+PyJ9arC/2NasAp4qXAdPUz6CbiC+30uAYwZZV6+NpUCYDZtjS+8 ZmWAJCX7KuF/JaZOz94j1bpqcRbLavJ1BrTKTnZKCRqxHVSMbPxRrrqnaJqQ+Q+na5pckBe+1QBRyBFb8KykhsUG8TYjse6TIoge9WX3PkBNTm+3MlHmMxss i+By9/Kf/e5DTJHTHh+hWp6Bla869voBDsrge7RS1VlmYwvHPndFC+MrCZ78EeIO38Y= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/19/2017 03:36 AM, Benjamin Gaignard wrote: > On 32bits platforms "struct timeval" or "time_t" are using u32 to code the > date, this cause tools like "date" or "hwclock" failed even before setting > the RTC device if the date is superior to year 2038 (or 2106). > > To avoid this problem I add one RTC test file which directly use RTC ioctl > to set and read RTC time and alarm values. > rtctest_setdate allow to set any date/time given in the command line. > > On this version 2 I add check of problematics years in rtctest like suggest > by Alexandre. > > Finally that had allowed me to test and fix rtc-st-lpc driver. > > Benjamin Gaignard (3): > tools: timer: add rtctest_setdate > tool: timer: rtctest add check for problematic dates > rtc: st-lpc: make it robust against y2038/2106 bug > > drivers/rtc/rtc-st-lpc.c | 19 ++-- > tools/testing/selftests/timers/Makefile | 2 +- > tools/testing/selftests/timers/rtctest.c | 121 ++++++++++++++++++++++- > tools/testing/selftests/timers/rtctest_setdate.c | 86 ++++++++++++++++ > 4 files changed, 212 insertions(+), 16 deletions(-) > create mode 100644 tools/testing/selftests/timers/rtctest_setdate.c > Hi Thomas/John, I can take the first two patches in this series through linux-kselftest with your or John's Ack. Please review and let me know one way or the other. The third one is a rtc driver patch. Please let me know how do you want to handle this series soon we can get this into 4.13-rc1. thanks, -- Shah