From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbdLIUmT (ORCPT ); Sat, 9 Dec 2017 15:42:19 -0500 Received: from mout.web.de ([212.227.15.4]:50754 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752009AbdLIUmP (ORCPT ); Sat, 9 Dec 2017 15:42:15 -0500 To: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] serial: fsl_lpuart: Delete an error message for a failed memory allocation in lpuart_start_rx_dma() Message-ID: <47b4cd2b-9372-9fec-d594-eed10d1cf515@users.sourceforge.net> Date: Sat, 9 Dec 2017 21:41:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:ZwRDbiD19PAQbr8pyPN8e6vSjDt8qcbgwRysxEuzqrydMTcrZ8l GOwg4HKZqSpBU6fhdhAOYXOrr14DlQnm62F7zcCd4g1M+iWdDJ69t5c7aQ+jts7eaTDqNYV HQZ6sR83Dzyt4Avoi+tChlPCuwICT6JBObjVDFnl/cCS4GeJcGZazNS11yzn63QbOQe4bNW DC/LEzndj8Eumwjm4YPjg== X-UI-Out-Filterresults: notjunk:1;V01:K0:StxHGO+ECdU=:iIIasrM8dlJeMgkLJz6eZK xjRI5TKL+vqVvPMkH0hkkTuarhsqTnmyZgR3sdfDTGyutvmlzmPZQR8yb7IzbLpa9+3X7BCOW SK11q97gG/BBNvflcPbQBe6LR/KZFyff2wumeuyVs3kif85lZzzwiiPOJMxkvIOQ7NxcUga+N LkbougdwvxZ/QhF9+vq+TbyCyhLtEnORFLWwLjD/UzlelqheOb93FVUuwqIwZR+7FAVxn8nTw I3Ix04Kh2+X0BEPNt58KOqXZZf4rG/waU6GzctzjklclyfEZv7m3XxYz2tMKZx6aQ3CpbVdVL L3VC+rFU9aIXEX+qfyNNMiINAQ+1TRO9rnuULUnfF/DzCKneNEoM09DGCKUMB5xR1+2WXqerH Y8Bb1dXzIZIb/cWRndRpYI5OoLRQu1LVzWsZJgVAPSszmKHf3dkdDrU7n3DPSN9BCHiI1RriS ctYOEbPhD189p38ZB2RHzGyw5nZ9+H651lvUEOyULbtRxFt1x3xvihKvZMSrZubunQwnS6iTu BKHvHfJqP2pJ8HlNDY5u+20rYUNJrcHOjQyMeKxRL+/grBwF/HszaZKbadbdgI3VonsNwYMBC JtS91Tb5xIG4303tsTXqhiZ5akheRQ5roDmiujKWC1Dr3sKMC1COXE6da5CvvvqI+8hwLhn4T /DyU1UR8GmdOAFXV2/vSYK77BU+MP96b1AzG7fYeGrTO3wm3InjVNbH7JycIhb1QZkpmxZyLH wILA5kQO2Mbu4qReb0W8Aawv4kj+OnQKvckVUKzEfZqzvZcyTkdKRKLDv0B6pK9Fjo9we3DMW VCOa1qEO8M8neienXVl9ZLZ2h0uOv9QAospUVB2a6xsGdMz0K0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 9 Dec 2017 21:34:23 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/fsl_lpuart.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index c84e6f0db54e..694751ebabf4 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -998,10 +998,8 @@ static inline int lpuart_start_rx_dma(struct lpuart_port *sport) sport->rx_dma_rng_buf_len = 16; ring->buf = kmalloc(sport->rx_dma_rng_buf_len, GFP_ATOMIC); - if (!ring->buf) { - dev_err(sport->port.dev, "Ring buf alloc failed\n"); + if (!ring->buf) return -ENOMEM; - } sg_init_one(&sport->rx_sgl, ring->buf, sport->rx_dma_rng_buf_len); sg_set_buf(&sport->rx_sgl, ring->buf, sport->rx_dma_rng_buf_len); -- 2.15.1