From: Lyude Paul <lyude@redhat.com>
To: Rhys Kidd <rhyskidd@gmail.com>, Ben Skeggs <bskeggs@redhat.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Karol Herbst <kherbst@redhat.com>,
Ilia Mirkin <imirkin@alum.mit.edu>
Subject: Re: [PATCH] drm/nouveau/bios: downgrade absence of tmds table to info from an error
Date: Tue, 04 Jun 2019 14:07:33 -0400 [thread overview]
Message-ID: <47b602c0a07ad5e945ab4bc706b2bf3154ea3196.camel@redhat.com> (raw)
In-Reply-To: <20190602120727.4001-1-rhyskidd@gmail.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
On Sun, 2019-06-02 at 22:07 +1000, Rhys Kidd wrote:
> Absence of a TMDS Info Table is common on Optimus setups where the NVIDIA
> gpu is not connected directly to any outputs.
>
> Reporting an error in this scenario is too harsh. Accordingly, change the
> error message to an info message.
>
> By default the error message also causes a boot flicker for these sytems.
>
> Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_bios.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c
> b/drivers/gpu/drm/nouveau/nouveau_bios.c
> index 66bf2aff4a3e..bdfadc63204a 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> @@ -935,7 +935,7 @@ static int parse_bit_tmds_tbl_entry(struct drm_device
> *dev, struct nvbios *bios,
>
> tmdstableptr = ROM16(bios->data[bitentry->offset]);
> if (!tmdstableptr) {
> - NV_ERROR(drm, "Pointer to TMDS table invalid\n");
> + NV_INFO(drm, "Pointer to TMDS table not found\n");
> return -EINVAL;
> }
>
--
Cheers,
Lyude Paul
prev parent reply other threads:[~2019-06-04 18:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 12:07 Rhys Kidd
2019-06-04 18:07 ` Lyude Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47b602c0a07ad5e945ab4bc706b2bf3154ea3196.camel@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=imirkin@alum.mit.edu \
--cc=kherbst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rhyskidd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®