From: Charan Teja Kalla <charan.kalla@oss.qualcomm.com>
To: robin.murphy@arm.com, will@kernel.org, joro@8bytes.org,
robh@kernel.org, dmitry.baryshkov@oss.qualcomm.com,
konrad.dybcio@oss.qualcomm.com, bjorn.andersson@oss.qualcomm.com,
bod@kernel.org, conor+dt@kernel.org, krzk+dt@kernel.org,
saravanak@google.com, prakash.gupta@oss.qualcomm.com,
vikash.garodia@oss.qualcomm.com
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Charan Teja Kalla <charan.kalla@oss.qualcomm.com>
Subject: [PATCH 2/6] of: introduce wrapper function to query the cell count
Date: Tue, 4 Nov 2025 14:21:01 +0530 [thread overview]
Message-ID: <47bdcf06aacc1fec791577ffd4a4a94034a4d3ed.1762235099.git.charan.kalla@oss.qualcomm.com> (raw)
In-Reply-To: <cover.1762235099.git.charan.kalla@oss.qualcomm.com>
Introduce the wrapper function, of_map_id_cell_count(), to query the
actual cell count that need to be considered by the of_map_id() when
used for translating the <property>-map entries. Accordingly make sure
of_map_id_or_funcid() operates on this returned cell count.
This wrapper function returns cell count as 1 thus no functional
changes.
The subsequent patches improve the logic in wrapper function to detect
the proper cell count.
Signed-off-by: Charan Teja Kalla <charan.kalla@oss.qualcomm.com>
---
drivers/of/base.c | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index ac6b726cd5e3..5e76abcc7940 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -2045,6 +2045,12 @@ int of_find_last_cache_level(unsigned int cpu)
return cache_level;
}
+static int of_map_id_cell_count(const __be32 *map, const char *map_name,
+ int map_len)
+{
+ return 1;
+}
+
/*
* Look at the documentation of of_map_id.
*/
@@ -2053,6 +2059,7 @@ static int of_map_id_or_funcid(const struct device_node *np, u32 id,
struct device_node **target, u32 *id_out)
{
u32 map_mask, masked_id;
+ u32 cell_count, total_cells;
int map_len;
const __be32 *map = NULL;
@@ -2068,7 +2075,13 @@ static int of_map_id_or_funcid(const struct device_node *np, u32 id,
return 0;
}
- if (!map_len || map_len % (4 * sizeof(*map))) {
+ cell_count = of_map_id_cell_count(map, map_name, map_len);
+ if (!cell_count)
+ return -EINVAL;
+
+ total_cells = 2 + cell_count + 1;
+
+ if (!map_len || map_len % (total_cells * sizeof(*map))) {
pr_err("%pOF: Error: Bad %s length: %d\n", np,
map_name, map_len);
return -EINVAL;
@@ -2085,12 +2098,12 @@ static int of_map_id_or_funcid(const struct device_node *np, u32 id,
of_property_read_u32(np, map_mask_name, &map_mask);
masked_id = map_mask & id;
- for ( ; map_len > 0; map_len -= 4 * sizeof(*map), map += 4) {
+ for ( ; map_len > 0; map_len -= total_cells * sizeof(*map), map += total_cells) {
struct device_node *phandle_node;
u32 id_base = be32_to_cpup(map + 0);
u32 phandle = be32_to_cpup(map + 1);
u32 out_base = be32_to_cpup(map + 2);
- u32 id_len = be32_to_cpup(map + 3);
+ u32 id_len = be32_to_cpup(map + total_cells - 1);
if (id_base & ~map_mask) {
pr_err("%pOF: Invalid %s translation - %s-mask (0x%x) ignores id-base (0x%x)\n",
--
2.34.1
next prev parent reply other threads:[~2025-11-04 8:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 8:50 [PATCH 0/6] of: iommu-map parsing for multi-cell IOMMU Charan Teja Kalla
2025-11-04 8:51 ` [PATCH 1/6] of: create a wrapper for of_map_id() Charan Teja Kalla
2025-11-04 8:51 ` Charan Teja Kalla [this message]
2025-11-05 17:35 ` [PATCH 2/6] of: introduce wrapper function to query the cell count Robin Murphy
2025-11-04 8:51 ` [PATCH 3/6] of: parse #<name>-cells property to get " Charan Teja Kalla
2025-11-04 8:51 ` [PATCH 4/6] of: detect and handle legacy iommu-map parsing Charan Teja Kalla
2025-11-04 8:51 ` [PATCH 5/6] of: add infra to parse iommu-map per IOMMU cell count Charan Teja Kalla
2025-11-04 10:46 ` kernel test robot
2025-11-04 10:57 ` Charan Teja Kalla
2025-11-04 13:02 ` kernel test robot
2025-11-06 15:03 ` Dan Carpenter
2025-11-04 8:51 ` [PATCH 6/6] of: use correct iommu-map parsing logic from of_iommu layer Charan Teja Kalla
2025-11-05 18:20 ` Robin Murphy
2025-11-05 17:28 ` [PATCH 0/6] of: iommu-map parsing for multi-cell IOMMU Robin Murphy
2025-11-11 18:27 ` Charan Teja Kalla
2025-11-12 14:42 ` Charan Teja Kalla
2025-11-21 5:54 ` Charan Teja Kalla
2025-11-24 16:42 ` Robin Murphy
2025-11-24 16:51 ` Robin Murphy
2025-11-26 17:30 ` Charan Teja Kalla
2025-11-07 8:07 ` Krzysztof Kozlowski
2025-11-11 18:45 ` Charan Teja Kalla
2025-11-11 20:39 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47bdcf06aacc1fec791577ffd4a4a94034a4d3ed.1762235099.git.charan.kalla@oss.qualcomm.com \
--to=charan.kalla@oss.qualcomm.com \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=bod@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prakash.gupta@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=saravanak@google.com \
--cc=vikash.garodia@oss.qualcomm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®