From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932267AbdJWNee (ORCPT ); Mon, 23 Oct 2017 09:34:34 -0400 Received: from mail-ve1eur01on0107.outbound.protection.outlook.com ([104.47.1.107]:45027 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932185AbdJWNec (ORCPT ); Mon, 23 Oct 2017 09:34:32 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=romain.porte@nokia.com; Subject: Re: [1/2] pmbus: added tps544c20 driver with trimming support To: Guenter Roeck Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171020103916.3309-2-romain.porte@nokia.com> <20171021162048.GA13173@roeck-us.net> From: Romain Porte Message-ID: <47c2dd13-c357-56fa-6886-08ce6e2b9d92@nokia.com> Date: Mon, 23 Oct 2017 15:34:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171021162048.GA13173@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [135.245.212.4] X-ClientProxiedBy: VI1P189CA0018.EURP189.PROD.OUTLOOK.COM (2603:10a6:802:2a::31) To HE1PR07MB3497.eurprd07.prod.outlook.com (2603:10a6:7:2c::28) X-MS-Office365-Filtering-Correlation-Id: 8beed995-8257-4dbc-b183-08d51a1ac940 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199);SRVR:HE1PR07MB3497; X-Microsoft-Exchange-Diagnostics: 1;HE1PR07MB3497;3:dpXWwaPzWphyIbCHkEEvozIMLXL+KPeZPx8nCdlB4mXvz8wFC7U9b46Lf2NChyOHEJ5SImXSuMqVmKtK0eDjzaUd/mGF6YAq5aar2wyJHA1tmFdoHTfBrEZywsNGsNWLzM7243wXgIX96HHh5Yf5GsqkHW0t2dfI1o0kV2YswoGnwOEZU1ppZehtPTxUMJn9Whe27wbZsw9MydeurLp8jOwfwDaMdVqXI9xTC8DVHnqiynUlEhF+C0o6QgP1SmSZ;25:s8K2bXBcKi7EaowwgLj/INvzrOJgXAgqn9+ZTHxpRY4nZ9hx1h0YAfEG+YwvbJvNnbM8nigCSqtjy765ZXagOUXig+3F+DByWrUVvGf/kigZKHwSXQTgAah8O56W5T1FdG+xg/oJyS33+rMNQb6htf0tgMxBIr9fMWojmH2SatrNPh18b8ImWB5WduDfbfQdGXjV70b2ljrGDeRWb66COKyEiZNu3k6ykgI9+aNlfTByZQHuWZCs4JU0tP64ave5dK6xZXPmoTsILta6hVB59oGNQwZabDrXddqQ3k8CNF6RukgYm0yVzo5GfU2zqmQfmgIKcV4PXZIqXAcHijFG0A==;31:gAtwOMCSNCMEm0bLfWr9lzbZYo8QJF3LzIZPzi7KE8caRGPZcn7JsBYwoCBRQwWvKMsyDBp0WXlptkQoB5+n8k6LIALdN4AarvRwmPh7lSBG9XodQ1fRwy0z/ZV1cmHf+nGH7uT1lRx33BErxV80pmyYFfULoGlXTXfOtefKwXi3n2NsBDzaDTcJiXfegUXtoM9M0/0w3yL/1+Z0d40/YAaRuReTOaJuDdjMa7dpV44= X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1PR07MB3497: X-Microsoft-Exchange-Diagnostics: 1;HE1PR07MB3497;20:w43u/SKWplClgq2o5EmrA0dldVaw6v+D7ebuHZv53qArgb2nckJ1UkkBktveyG4tieRJgIbwXlRomZdkKcT/0Z3RFrEbZRMk6JvOPGjE0RSpSn4DAYgamO1jkQXtlKa/NJza9vdaZj6toqS33Ts/LZuwCeMurjchqu2GwOoJ6uvZBg5hAe5dvrLE+BDJF6Aqh5TjAIh+dwZXZKY5RETdSoXYVtJNVdaC/nHXaLyds19Ed3om4B3Q1aSeVHJK5+H+tI2K+2UE7k2cy7e2m2L0ekYu2UxwSZrlvEh8wxPy53VguykQGmihh/mPgWxQwg5DTRylPcRHwQuh9h4bIJYvyR78NpN6UM1FjeaLJrzElQxbqTMMmaUw9vQiKoTI5NWmhHSTEq69tjM1/dXlkdW0MRqyLIYBMtAHOzBQsjaoWGs7KfRkIzRghfiv/ofwCkBrUeAbV+z0bQHUYFni0PbBHtbA3Bb7UTOxxf3jJBYjjY1yb9fze6ZLXpgteubxeDQL;4:R+AgttrB0mqN5tPkrnEJ2ErS3sqvS2TzamSKzX9VBbCTKY6vRFCqMat4RpDQM2DE/Tl0qmKM6eLz4HExWzqGEtKeSCQkAO+zdrbBU68wHZHDCBSMbRG7XdGJmulx+2erCqT3WJoDxw6DgOE1K0CYpUGlq7rs6WrRAkYT7Hh/+J9+GWvGPPq5ezzpkN+PyAgNPbNgN0SO94d9JOxmCS/3vSMabFU3gSHj/QLUD6Dex3mAx6jli0WIFplIj3TBkJmw6w9OjCCuhxkZBLs2SazcNg== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3231020)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123558100)(20161123560025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:HE1PR07MB3497;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:HE1PR07MB3497; X-Forefront-PRVS: 046985391D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(6009001)(376002)(39860400002)(346002)(199003)(189002)(24454002)(2906002)(16576012)(4326008)(316002)(23676002)(53546010)(6116002)(3846002)(58126008)(36756003)(65826007)(31696002)(229853002)(5660300001)(6486002)(230700001)(16526018)(77096006)(83506002)(86362001)(7736002)(47776003)(65956001)(66066001)(65806001)(305945005)(31686004)(53936002)(105586002)(106356001)(68736007)(2950100002)(6916009)(189998001)(33646002)(64126003)(50986999)(97736004)(54356999)(76176999)(8936002)(101416001)(81166006)(6246003)(3260700006)(25786009)(478600001)(81156014)(8676002)(50466002)(6666003);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR07MB3497;H:[172.27.221.132];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA3TUIzNDk3OzIzOmFrY0pGclMwQ2hVaFlYTFpsR0tBM0MxeVpm?= =?utf-8?B?NnNUcm55UmtYOEFCQUxRMXR3NWxhNmJCR1ZDdUFWMDcvTmxPVnV5UXA1bWlV?= =?utf-8?B?SHBGdEphREVMUmRaWVhZU3hXQkxDYml6MjhJQnZ3b1VJN0JoNTBjejIrUGpS?= =?utf-8?B?U2VvT3crbDdNRHVqd1ZzZytoaG9nb1NIRG5CVHVEQWdsQjkrVWFDVzBmZ25H?= =?utf-8?B?bU01L3V3S2VlK3ZrVThaOGV6SEo2bjA5UkhEL095TGpYS1dVdVBKOTErUU5Y?= =?utf-8?B?L1NmYUk5ZE13djJaODRZOUdMMzBVUm83bGsxQW5TNkhFMkt3VCtBTVJrYmlq?= =?utf-8?B?Ny82TkQ4RmZNSGIyc09QZzQ1Z295cjJseUV0a3ArNXpYYVp1UXBvQ3czYnFR?= =?utf-8?B?NXlvK0ZsczVxek9NRnExelZLVVNMSGVrVmtoOUJvOHh3M2I3YmxTQkJCeXo0?= =?utf-8?B?empnQUNETXZmS2txR1B2d1FKOGs4YzdzVVQ3WTBaNXRKczk1VXdTYmNCUjRH?= =?utf-8?B?TnN2ZjgybG9TQitDLzhMVEtkM1BGam1UNzM2bXFva3hlUmlTNE1mUzZqSUJ3?= =?utf-8?B?MTZ4Z1llU0EzV043SDFvZ3kwNTBTcVB6bGFqUWpmNzE3MFdPbTl0STk4c3FH?= =?utf-8?B?M2ZsWXlOZU5qSVVrdEllajNmRjZNcFQ2V0pvVDFGUEZBK0Jsd2RpR0Nac0Nx?= =?utf-8?B?M1FNMHFGMzFDdFNSK0R6RXBSS2dqNEI2MGpDeHRBc0VHaFQxQmtmalhXaGJr?= =?utf-8?B?M01DSmpRRDZHdE9xaW5RUmpHKzYwNmQ2Y0NYTDcxNno2UnhNRmlzeGlHcWhE?= =?utf-8?B?NTliNHJ2cG1WaUFBN2pEMXFYVnVXV1Y3SE9EV2pJRDZlT2pGeW43eFVSOTEy?= =?utf-8?B?NFRPZkxjOHBhaHpndkxHMjZqcExESC9GRzhrVjl5QlRaZ0FmQ0pMY3ZxajNW?= =?utf-8?B?VkUwc01sRzR5WTBLNU1xa3JFNHJiMWtSNW12bGYxMkFzREJUa1VpZEVQY3Vs?= =?utf-8?B?SGJRQ1l4eTNnS3dSakJtWXdwVDBKZSs2L293MVNNclBtNFJCc0RNbEtjVExX?= =?utf-8?B?YTNuMWU0N09oWG1wMnlwVzAwK3NnYVNpZUdYZE5tK3dacUx2d01GeDY5aDNQ?= =?utf-8?B?ZWx2NXA1WHpVSllTaXJZMytvTkpGKzBBc1ZxYVY5K2NsdDlQRXBZY0ZtRmlx?= =?utf-8?B?cmxLdU9kVUVpSjhteS9Gc3dRQkpqWHNxaVZuRlNXcWNaSVlxdDlqVXlKeUR1?= =?utf-8?B?bUFBTVFJMW9ONlFCWnFUMFF5Z0RNaE5hRjFsdmxxV2NFQ2FrWjdDQjFvTWZB?= =?utf-8?B?ZFcrVlJNbkpZbGNoUHdnYTdQbGgrSW5FY3V5UHlqWFNERGNhajVYdGgxOG90?= =?utf-8?B?NEhPaERITXVrREJQNGdYOGdBUUx0cGZIcXYwNTFlK1J0b3JaYS9wSTFDckc2?= =?utf-8?B?WmovL1h1ZVZrc2pKMHVjWE1EcUxyV2FtRnBua0hsUHpIRVQvMW9VbjFWcy9j?= =?utf-8?B?UTNXcmlXOWx5YkxZRUpaNTRuMWhVVk1SL0pTYzd4enM2aWxnTHBUR0xjbFE1?= =?utf-8?B?NmJNT25RcHpNWXhZekdOb0FscC9qU3lDeVNDeitlZldKeG9vdVAzdzBUcEx4?= =?utf-8?B?TjFscC9kUDZvQzZlallzVnFnUmRWcTF4TnFZTXlmZFFtNVMvdDMzVEdrOTds?= =?utf-8?B?ZFVRdWpENjRWWHJZY2hMVU81U2RUYlVlU2JaejFsNGs4K0tQekhlWkwxNXlT?= =?utf-8?B?QjlJaGQveGVBRGdhKzF6YjhFRTZDakxib0ZiSnk4aVBuYXA0VnFrck11SHY5?= =?utf-8?B?ODdycDdkME1KRk9JaWZ2bWJMckRjTEF3ZzBQNjVGVmlxd3c9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR07MB3497;6:Z0OwlhZc4ZzYUs3dKs7TEWfiKNZLngBS6jtDiujuPoubUXo9FNkIabN+jxqh613u3xSPLwh3BUBn+YCSEMafGu4yX24FdItAZSM0K/L5uIyuJvEAb5QiaK+Wo6n6QqZRUyJDloti6e69GfTZ0tsYxfJmJl2ZmRQYYlw6EO1tinoJAEuhXy9yUb8NWhHmDN55h9T+Pbu7XbRb9n+TqSJ6pSRd54j73XoRMNZY2pJ9dRA8vpGS9mkAnivIh+JYNTPLR0Ve8A/oMonuVN4ikPNggQiqu9CErYwtnFUAsrCPkLvVF8CH8uCEW8lQBfBXERW+RUgR5sncQZs/N4+ZdETSYTs1AAxFHrAG7Mn/mIHfjTI=;5:OZMSoSTZiD8J1yBIBB7E5PlyYN9U+UjCAMXyI+QBsTGWFxb6fyjx0zPOOIMnmWQwaTF6FsJVYJjGZBelgf2BGpjWnWa7IoROLZE5OtCuE0AjtHOcAnuh57IQXMcaeDNcmVV7D5JdwuHqUQukBqNAmxjudITBMt7FQ5ILq8wungk=;24:ACbJyT29uSSEonD1u4sBZvLuUWePwZXXeKfLrzjcJILbRfwzwE8u64Fpbf5eHpDeBMzWK5Lf9aUZngBLVC1SLw9gz/9g5+hBwCX1FjuOo7A=;7:Yf/eQYFOBTH0IyrzY8uCsPWGuJzC74b8xQ2RDq9iUqAYsGMmnXjciIIlBmNY2uWLZfSUeKpCtYT7W6AiqI2oeMvNiD1olp+fGChA6F7ZWiFJKQIkUv2FnrKoz60gWYZphounJ0o+4Ssf3DFB1AcCKffBh5DgMWb34VVAYc7iX9womJ2tuCB3jlBNpYVf9gXy/XymMKtd+0X440gl42OOUn3kdKwBHRbbeLQgZpGla46FaMISBVsC8VjGKh67cciA SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2017 13:34:28.7131 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8beed995-8257-4dbc-b183-08d51a1ac940 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB3497 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/10/2017 18:20, Guenter Roeck wrote: > This should be part of device programming in manufacturing, just like, > say, current calibration. It should not be user programmable, even less so > runtime programmable. On top of that, we definitely don't want to make > STORE_USER_ALL available to user space. Both can too easily result in > a bricked device (bad enough that the register values are writable using > i2cset). After some work, I have tested accessing these registers using i2cget and i2cset and I can reproduce all the features I have implemented in this driver. I think am going to re-implement my calibration procedure using i2cget and i2cset in userspace. I thought it could be a good idea to make this accessible by sysfs entries. Since one must read the datasheet for calibrating the component, I guess it is not a big deal to have users to find register addresses/sizes and write to them using userspace commands instead of (over?)simplifying it by providing dedicated sysfs entries. Romain.