From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=fWiu=Y6=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 97FEAC5DF63
	for <linux-kernel@archiver.kernel.org>; Wed,  6 Nov 2019 17:29:48 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 70095217F5
	for <linux-kernel@archiver.kernel.org>; Wed,  6 Nov 2019 17:29:48 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1732377AbfKFR3r (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 6 Nov 2019 12:29:47 -0500
Received: from smtprelay0165.hostedemail.com ([216.40.44.165]:36993 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1728983AbfKFR3q (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 6 Nov 2019 12:29:46 -0500
Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60])
        by smtprelay04.hostedemail.com (Postfix) with ESMTP id 0FBA8180A5AE6;
        Wed,  6 Nov 2019 17:29:45 +0000 (UTC)
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-HE-Tag: leaf04_37d3b9d49d90d
X-Filterd-Recvd-Size: 2273
Received: from XPS-9350.home (unknown [47.151.135.224])
        (Authenticated sender: joe@perches.com)
        by omf12.hostedemail.com (Postfix) with ESMTPA;
        Wed,  6 Nov 2019 17:29:43 +0000 (UTC)
Message-ID: <47c55ab899aafe10898e6581582363aa446b2091.camel@perches.com>
Subject: Re: s390/pkey: Use memdup_user() rather than duplicating its
 implementation
From:   Joe Perches <joe@perches.com>
To:     Markus Elfring <Markus.Elfring@web.de>, linux-s390@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Cc:     Christian =?ISO-8859-1?Q?Borntr=E4ger?= <borntraeger@de.ibm.com>,
        Harald Freudenberger <freude@linux.ibm.com>,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        Ingo Franzki <ifranzki@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        LKML <linux-kernel@vger.kernel.org>
Date:   Wed, 06 Nov 2019 09:29:31 -0800
In-Reply-To: <0f90b278-7b3e-6509-1633-301d16513c5d@web.de>
References: <08422b7e-2071-ee52-049e-c3ac55bc67a9@web.de>
         <6137855bb4170c438c7436cbdb7dfd21639a8855.camel@perches.com>
         <0f90b278-7b3e-6509-1633-301d16513c5d@web.de>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.1-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2019-11-06 at 14:00 +0100, Markus Elfring wrote:
> > > Reuse existing functionality from memdup_user() instead of keeping
> > > duplicate source code.
> > > 
> > > Generated by: scripts/coccinelle/api/memdup_user.cocci
> …
> > > Fixes: f2bbc96e7cfad3891b7bf9bd3e566b9b7ab4553d ("s390/pkey: add CCA AES cipher key support")
> > 
> > This doesn't fix anything
> 
> How would you categorise the proposed source code reduction and software reuse?

As inappropriate for a fixes tag.

The fixes tag is "used to make it easy to determine where a bug
originated, which can help review a bug fix"

There is no bug here.

> Will the development opinions vary between contributors?

Ever had a bikeshed?

> > > +	return !ukey || keylen < MINKEYBLOBSIZE || keylen > KEYBLOBBUFSIZE
> > > +	       ? ERR_PTR(-EINVAL)
> > > +	       : memdup_user(ukey, keylen);
> > 
> > This is a very poor use of ternary ?: code.
> 
> The conditional operator is applied once more in the intended way,
> isn't it?

Please take your development efforts to obfuscated c contests.