From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F198F331A5E for ; Thu, 19 Mar 2026 02:47:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773888470; cv=none; b=keA1f7U9ZsxmIGi2AcPDRVkDLTFAuoxsBjN6YWm71U/Kxj1b0iJcnrU86gsdyS5TvsabQuMC491T36VVmR7Gk14JkgxMASIlAWSB+jIwPLBPYv61g7fRkO9gVer4NL2f6EiX91rUpJXW1eHMu4/lax9aIeQfLMkT9Jng1aDetK0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773888470; c=relaxed/simple; bh=JpRLou5c3IrWT5+/pUhl7GOXvFaDQh/BxYXfAd9bwAw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eX7ApTKYmAYqqqY3oih3Wtx0iyshuDN5dS9cFB/2HCq5jTFLk+zqlPWaXBEL4UdozOzFI5FVzFE0UNPnCePj9qrNxP8w1pX+olUzqDg0tGOYOpZ7EH7TSS1jm38+lWBXBQFrw+ooCvg6necHQHQr+ilb2CYvZr0DH5K4sHS+sMw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NEijA3RK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=S27/tN5K; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NEijA3RK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="S27/tN5K" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62IH10763413658 for ; Thu, 19 Mar 2026 02:47:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nHDyHXOy91HF/6i04YQNHlGpN7N/uSNnlOoEpxM8Ovw=; b=NEijA3RKUt7Ddj4M k7VRXMPj3qeVi8KCkJMOcAM8GZWyc89lsScltB3Q6t72P+DdFw0T/BX1kN2C0p8x Pgde9h8jZ15lkAdp6sneZy9MHBFdiyl8Xw/p+ytrEONokD96Awek+b896LufMemU 3YdCdMIy9KVcCsUOee5kJL3u8pQ0wqFEBEndNLIwLaIpgzIuggfPkjryOzzEAFG/ 4ioHO5I06q2xBUTRzdUXr5paM/LDEcexTGupJ8XwxKRoUntlXczJH5NsQJjtX7Gr Htx4NlqHvuQw8iIQSs1vGV/SZEmhbkLLdpXw+eJxb2RR54bgMaHCuNWmi/HOQXrs ck7u4g== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d0032hm4q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Mar 2026 02:47:47 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b051befbb8so7243665ad.2 for ; Wed, 18 Mar 2026 19:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773888467; x=1774493267; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nHDyHXOy91HF/6i04YQNHlGpN7N/uSNnlOoEpxM8Ovw=; b=S27/tN5Kybiv43S3JJqeyNSNih/dXkjDFokCdhkpGInFgFONrc6Y2hdA+2ioLzlqRx JM7fO551ToBtCzOlbb+jvEK30iPh7ZxCBLLn6eWMRVPkxMGjWpdho65FYqefGRRTSoiC qze9nrE70cxdcE52MHgZ4cGsMKMcqQAczy6JnodT1JbOceQHRvyPA2TI022oQUgBFXZI WAW7GiIlX5oRfqMmXPahLje6c3oMnnynnWbxID+pHqMPHE8ylo0o9IMqBW3KhWHVipOv QRpg9UXA4FhlKGnXGpz+692l8R4wQSAd82l4rNqvTu+LHQBhh1/L6psR+LN7v/Ytap41 at+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773888467; x=1774493267; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nHDyHXOy91HF/6i04YQNHlGpN7N/uSNnlOoEpxM8Ovw=; b=Af4I26wm+Rb+JZd746YuQ+9dfs7yPh2S3v4FYIVdtrwiLBJvdNV4ImvBvGHEAFiR7H Ne4dgjM9ZYGZc1OTJZgqU/7gquLmllQZPM9DgZvqVcGV1JjWIH/JXDHckZrVFxT/+AGf Ik+GPq7vHwEu16p9yR2B4Zkj9l5X9yXpq1kWSDf+61zets5TkZ7rctZ7fMF6ondKYvO8 Ug59kXTKF4h6xQ/2Tt43WhfFEDcw/Ojz0Tx7xBsOtt9/7ZVY0NYzxpclMqu/LWveB/TJ e6W6sBd+GJYa2dsPa3apna2zkzww3dv+nI9PjSb69owk1AdOgcUnKmIuIGpuk20AeTGJ oZsQ== X-Forwarded-Encrypted: i=1; AJvYcCUc59BXLEnc09Hml5hG5Td9YnTMKf2MP6JSmKeOUES4EXsgAQgU/pfowskt/IijqlYZNbNmoa4VNzjr0TU=@vger.kernel.org X-Gm-Message-State: AOJu0YxiYru+pOMgJ6XStUI6MfpJ90xiupjVxfuyguvKbWfwrHOk+lcK uARJHb3N+s5lzSmc8P1JjP65L5WnFbFBpLeeF29VMppmyueOTdd7kBvfMwGBKs2sR497l56/+tZ R1sso0B4sO/y1l/BU0SKbu/vwH/U5/lIIHXRwJJKMtw+mX1qpQ9vLLQNHF90KX0UrAqc= X-Gm-Gg: ATEYQzzNNX0mY/3UBTYS7uLBBbjS/OTMbXvlYm8m/o8G9P2IB3tCM27y9DHxEbio1qB Z3E4GP8clN3CXXo4r+YYxJ2QF2eOwKQ8ZpYCm238EkpKDb9Vs+FuLSj6MGELb2sfHSYAon37OEQ p6aDJs2Xvy5ZTKpQ7aNTVuU3hoFKOBNt/UtNgd281D8TWRYclXkVqeJs3gDC0n/lV9OFmkLnshQ Mgl8KFlf11wve2yjV1tyMca4eBrEvcIh1po0FMvDdxW3+Ku0n/9QNcC9RAvTEKlDn6Hl4v9bnpb ejwRtEg0CLNiWLUgJMGVkBRxy76RgfNp0iVzuCCFQ/yLlTLOzK0C84J/QAsHtSxInae5P9vQd2Y NXX6N+r0KAoFHGAevwI6n0xzj5sAVDr1f0DfbyDGfyAqZwWdI9avD7bJ12fRTRKof9lSvxXEkWV d++MlsVsanHyknrMIptAY= X-Received: by 2002:a17:903:46c7:b0:2b0:643b:41d2 with SMTP id d9443c01a7336-2b06e3fe574mr55296175ad.47.1773888466650; Wed, 18 Mar 2026 19:47:46 -0700 (PDT) X-Received: by 2002:a17:903:46c7:b0:2b0:643b:41d2 with SMTP id d9443c01a7336-2b06e3fe574mr55295965ad.47.1773888466150; Wed, 18 Mar 2026 19:47:46 -0700 (PDT) Received: from [10.133.33.235] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b06e441374sm41024405ad.29.2026.03.18.19.47.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 19:47:45 -0700 (PDT) Message-ID: <47c6626d-14aa-4410-bf75-6720d7673eec@oss.qualcomm.com> Date: Thu, 19 Mar 2026 10:47:40 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath12k: fix channel list copy on big endian To: Alexander Wilhelm , Jeff Johnson Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260317-fix-channel-list-copy-v1-1-5e1e5ae1c5d5@westermo.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260317-fix-channel-list-copy-v1-1-5e1e5ae1c5d5@westermo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 96faKXEXVkFwpmjxSuNiEkIZopGB8UV6 X-Proofpoint-GUID: 96faKXEXVkFwpmjxSuNiEkIZopGB8UV6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE5MDAyMCBTYWx0ZWRfX0knLmGRkNOjy uao9EMvm4iPhJiHUab2PZrnonjOKiZcqvySx7bOM77pTdT0tYpKzzmKwL1QbldxVvkCd/8csoYM eDR2NRxsWxIlAaePKHR2qwyqvsbswH+lRe4463XM0j64LsvZtmxRCF4pDI6Xvo0rUpfy0vPAOAD CKOKmn6M2Dl9FRnIfXivP2C/N8Fzi322nxd581QeV2syqWikLEeQGFtIpxQNL/1IfajVgAM9sdW pFHw2oLM+/JD7MkV0AU4Fm5CmSXLar3Y701TNZO7M690dQPoQ5pVYBaM0bk4PEdLJUBiC2DTyvJ zyBCLy4Oz8z3KAUn4Yc6ZhPCfnywpAG4JLlb5dMBLD3C/trQJWGX752xDzLlMHJBf3+HvQ1ys0f lR0UfrM4rbG1649aTyQuZDOoYtzOnr4A7ELgicS+mEwdJpl5cetKivOIDLCeXwfRuIKm07TGeFw WPuzFxT+YqrQS7Vmv3A== X-Authority-Analysis: v=2.4 cv=WO9yn3sR c=1 sm=1 tr=0 ts=69bb63d3 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=N9GNhs4bAAAA:8 a=EUspDBNiAAAA:8 a=ywX3x0iTvHv4trEmZJsA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=PZhj9NlD-CKO8hVp7yCs:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-18_02,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 clxscore=1015 spamscore=0 malwarescore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603190020 On 3/17/2026 8:54 PM, Alexander Wilhelm wrote: > The ath12k_wmi_scan_req_arg structure defines the channel list in > CPU-native order, while wmi_start_scan_cmd expects the values in > little-endian format. The simple memcpy causes the hardware scan to fail on > big-endian architectures. Set __le32* type for the tmp_ptr and swap channel > values to support both architectures correctly. > > Signed-off-by: Alexander Wilhelm > --- > drivers/net/wireless/ath/ath12k/wmi.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath12k/wmi.c b/drivers/net/wireless/ath/ath12k/wmi.c > index 65a05a9520ff..9e1d3c662852 100644 > --- a/drivers/net/wireless/ath/ath12k/wmi.c > +++ b/drivers/net/wireless/ath/ath12k/wmi.c > @@ -2571,7 +2571,8 @@ int ath12k_wmi_send_scan_start_cmd(struct ath12k *ar, > struct wmi_tlv *tlv; > void *ptr; > int i, ret, len; > - u32 *tmp_ptr, extraie_len_with_pad = 0; > + __le32 *tmp_ptr; > + u32 extraie_len_with_pad = 0; > struct ath12k_wmi_hint_short_ssid_arg *s_ssid = NULL; > struct ath12k_wmi_hint_bssid_arg *hint_bssid = NULL; > > @@ -2656,9 +2657,10 @@ int ath12k_wmi_send_scan_start_cmd(struct ath12k *ar, > tlv = ptr; > tlv->header = ath12k_wmi_tlv_hdr(WMI_TAG_ARRAY_UINT32, len); > ptr += TLV_HDR_SIZE; > - tmp_ptr = (u32 *)ptr; > + tmp_ptr = (__le32 *)ptr; > > - memcpy(tmp_ptr, arg->chan_list, arg->num_chan * 4); > + for (i = 0; i < arg->num_chan; i++) > + tmp_ptr[i] = cpu_to_le32(arg->chan_list[i]); > > ptr += len; > > > --- > base-commit: 702847e8cfd51856836a282db2073defd7cfd80c > change-id: 20260317-fix-channel-list-copy-cef5cad24fb6 > > Best regards, Reviewed-by: Baochen Qiang