From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 732811BE238 for ; Mon, 13 Jan 2025 13:01:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736773303; cv=none; b=aj2FHw3C10MuvckYcOCSjQDxA4jooQWKiqD/rQDvASXdTuRHQrP8n5PC9w3HxVIFOezapqxuHVtDOz6jdyIlUGkv/7RZQUPoTC47tDHhgm7Czw/yq+Kk7rRpAauI1VH1LEzgISg4VG87szOJHA40WGaUVB1iD7pvXYIJctmF5Eo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736773303; c=relaxed/simple; bh=BZ30zG5/9l3ehX+5BS0GX8LCuITKiabaucDBuP0yx50=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RFZ+C/uwWrHCInGIqBGRPmAY9+wnIDE87z0QeeR8FKQBG4HcxlffO0YT1LcdKujlT7dukg1ayW858Dtf8BP2Ivj62koKfwCQFHIqxWLDraW5fBJQVKt53Ao+s/NT+DcDYmtsxd84hwpHJY2bP/sdT1BY3hiWR1/f1HlvuW/U4X4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=He36DaFS; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="He36DaFS" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50D3qqsB002387; Mon, 13 Jan 2025 13:01:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=OdBOo0 sVTlugXUHBN4ZAo1wbIC47mnWk4UiI5g0/XBQ=; b=He36DaFSL9yh9K9uNnlwZx yrf02crvIrGqFj7zDnxnia2V5PR2+YJ8oCxknei8ibBTGXHTagmr7TSUYH2QX1Ki VBv2kPdXnWtm6dEDDJeVlyfTH0S4NlFCdz6cAlScNNwxeXQzyk5fno+Avt9p4qqO gNssKD/wJCvGapUIlmW99aXkbtN9AYcOezLNL6v6u/xLFxCWO+NRK0Eylpt5wt7a SK0xrb0xJF88dcT+pRCaD44LfNtOtujQylLwBgipfwKMT5792YmUE7XWu3/qHTHy a+qIJkCES5gJE8df+zlcFYNCAffc2+VQp9PUbGclG7Fn2uJmQOWQzrELoCjVM25Q == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 444uagt0tj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Jan 2025 13:01:04 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 50DCkbdp028905; Mon, 13 Jan 2025 13:01:03 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 444uagt0tf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Jan 2025 13:01:03 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 50DC1TNI002734; Mon, 13 Jan 2025 13:01:02 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4443bxxb0d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Jan 2025 13:01:02 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 50DD0wxI65012118 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Jan 2025 13:00:58 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B1E5420043; Mon, 13 Jan 2025 13:00:58 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CB95020040; Mon, 13 Jan 2025 13:00:54 +0000 (GMT) Received: from [9.43.28.240] (unknown [9.43.28.240]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 13 Jan 2025 13:00:54 +0000 (GMT) Message-ID: <47c96e26-4b2f-444d-98c8-9855013870c7@linux.ibm.com> Date: Mon, 13 Jan 2025 18:30:53 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fadump: Use str_yes_no() helper in fadump_show_config() To: Thorsten Blum , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Hari Bathini , "Ritesh Harjani (IBM)" , Bjorn Helgaas , "Aneesh Kumar K.V (IBM)" Cc: Baoquan He , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20241230214142.952706-2-thorsten.blum@linux.dev> Content-Language: en-US From: Sourabh Jain In-Reply-To: <20241230214142.952706-2-thorsten.blum@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: uJIANtv1dLC1yjA6ujw7a57JQUfl7zdo X-Proofpoint-GUID: q6QovXDeaaUyqiDXMoJeEWmRvmrXZHP_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 lowpriorityscore=0 clxscore=1011 impostorscore=0 bulkscore=0 spamscore=0 mlxscore=0 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501130109 On 31/12/24 03:11, Thorsten Blum wrote: > Remove hard-coded strings by using the str_yes_no() helper function. > > Signed-off-by: Thorsten Blum > --- > arch/powerpc/kernel/fadump.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c > index 4b371c738213..8c531533dd3e 100644 > --- a/arch/powerpc/kernel/fadump.c > +++ b/arch/powerpc/kernel/fadump.c > @@ -289,10 +289,8 @@ static void __init fadump_show_config(void) > if (!fw_dump.fadump_supported) > return; > > - pr_debug("Fadump enabled : %s\n", > - (fw_dump.fadump_enabled ? "yes" : "no")); > - pr_debug("Dump Active : %s\n", > - (fw_dump.dump_active ? "yes" : "no")); > + pr_debug("Fadump enabled : %s\n", str_yes_no(fw_dump.fadump_enabled)); > + pr_debug("Dump Active : %s\n", str_yes_no(fw_dump.dump_active)); > pr_debug("Dump section sizes:\n"); > pr_debug(" CPU state data size: %lx\n", fw_dump.cpu_state_data_size); > pr_debug(" HPTE region size : %lx\n", fw_dump.hpte_region_size); Yes, it is better to use `str_yes_no()` instead of hard-coded strings. I have also tested your patch, and everything is working fine. Reviewed-by: Sourabh Jain Thanks, Sourabh Jain