From: Thomas Richard <thomas.richard@bootlin.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Dave Penkler <dpenkler@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lee Jones <lee@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: gpib: Fix error handling paths in cb_gpib_probe()
Date: Mon, 28 Oct 2024 10:40:02 +0100 [thread overview]
Message-ID: <47d10f3f-3741-4a84-a1a5-8cd03bc22396@bootlin.com> (raw)
In-Reply-To: <459c267de8c9bf48fcb555364930ae7e3cdc798b.1729940596.git.christophe.jaillet@wanadoo.fr>
Hello Christophe,
On 10/26/24 13:03, Christophe JAILLET wrote:
> If cb_gpib_config() fails, 'info' needs to be freed, as already done in the
> remove function.
>
> While at it, remove a pointless comment related to gpib_attach().
>
> Fixes: 6f1067cfbee7 ("mfd: Add Congatec Board Controller driver")
The Fixes tag is not correct.
I guess you did a wrong copy-paste as you sent a patch for the CGBC MFD
driver few minutes before :)
Regards,
Thomas
prev parent reply other threads:[~2024-10-28 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 11:03 Christophe JAILLET
2024-10-28 9:40 ` Thomas Richard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47d10f3f-3741-4a84-a1a5-8cd03bc22396@bootlin.com \
--to=thomas.richard@bootlin.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®