From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752367AbdANMw0 (ORCPT ); Sat, 14 Jan 2017 07:52:26 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:51321 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752179AbdANMwY (ORCPT ); Sat, 14 Jan 2017 07:52:24 -0500 Subject: Re: [PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching string to "vref" To: David Lechner , devicetree@vger.kernel.org, linux-iio@vger.kernel.org References: <1484157171-15571-1-git-send-email-david@lechnology.com> <1484157171-15571-4-git-send-email-david@lechnology.com> Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org From: Jonathan Cameron Message-ID: <47d15fe8-85c5-6e1c-cd89-71398ad79def@kernel.org> Date: Sat, 14 Jan 2017 12:52:21 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484157171-15571-4-git-send-email-david@lechnology.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/01/17 17:52, David Lechner wrote: > This changes the reference voltage regulator matching string from "refin" > to "vref". This is to be consistent with other A/DC chips that also use > "vref-supply" in their device tree bindings. > > Signed-off-by: David Lechner > --- > drivers/iio/adc/ti-ads7950.c | 6 +++--- Again, we missed this before and it would have been nice to have had it as vref (which is matches the datasheet). The question becomes how do we handle this going forward with no risk of breaking existing device trees. We may have to do an optional get on one name and then a non optional on the second. It's ugly, but would fix this up in a 'safe' way. Jonathan > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/ti-ads7950.c b/drivers/iio/adc/ti-ads7950.c > index b587fa6..16a0663 100644 > --- a/drivers/iio/adc/ti-ads7950.c > +++ b/drivers/iio/adc/ti-ads7950.c > @@ -411,15 +411,15 @@ static int ti_ads7950_probe(struct spi_device *spi) > spi_message_init_with_transfers(&st->scan_single_msg, > st->scan_single_xfer, 3); > > - st->reg = devm_regulator_get(&spi->dev, "refin"); > + st->reg = devm_regulator_get(&spi->dev, "vref"); > if (IS_ERR(st->reg)) { > - dev_err(&spi->dev, "Failed get get regulator \"refin\"\n"); > + dev_err(&spi->dev, "Failed get get regulator \"vref\"\n"); > return PTR_ERR(st->reg); > } > > ret = regulator_enable(st->reg); > if (ret) { > - dev_err(&spi->dev, "Failed to enable regulator \"refin\"\n"); > + dev_err(&spi->dev, "Failed to enable regulator \"vref\"\n"); > return ret; > } > >