From: "Michal Vokáč" <michal.vokac@ysoft.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Vinod Koul <vkoul@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6dl-yapp4: Use rgmii-id phy mode on the cpu port
Date: Fri, 1 Mar 2019 07:29:37 +0100 [thread overview]
Message-ID: <47d36e23-1113-56ff-e285-f9bd274004ff@ysoft.com> (raw)
In-Reply-To: <20190301021344.GK26041@dragon>
On 01. 03. 19 3:13, Shawn Guo wrote:
> On Tue, Feb 19, 2019 at 02:37:00PM +0100, Michal Vokáč wrote:
>> The PHY must add delays to both Tx and Rx clock on the cpu port
>> to work propperly.
>>
>> It worked with the rgmii mode before beacause the qca8k driver
>> (incorrecly) enabled delays in that mode.
>>
>> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
>> ---
>> This imx6dl-yapp4 platform is currently waiting in linux-next.
>>
>> Commit 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode"), now
>> also in linux-next removed the delays from the RGMII mode so the networking
>> stopped working.
>>
>> Recently Koul submitted a patch that implements the rgmii-id mode to fix
>> the issue [1].
>>
>> As the networking is broken at this moment it does not matter which patch
>> goes in first. It is not neccessary to wait until the Koul's patch is
>> applied/merged if that should be the case.
>>
>> [1] http://patchwork.ozlabs.org/patch/1044505/
>
> Can we have such useful info in the commit log in some proper form?
Sure, I will transplant relevant parts of the message into the commit
log. I just thought that most of this info will be outdated immediately
after applying.
BTW the patch[1] from Vinod is already merged.
Michal
>>
>> arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>> index b715ab0fa1ff..091d829f6b05 100644
>> --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>> +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>> @@ -125,7 +125,7 @@
>> ethphy0: port@0 {
>> reg = <0>;
>> label = "cpu";
>> - phy-mode = "rgmii";
>> + phy-mode = "rgmii-id";
>> ethernet = <&fec>;
>>
>> fixed-link {
>> --
>> 2.1.4
>>
prev parent reply other threads:[~2019-03-01 6:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 13:37 Michal Vokáč
2019-03-01 2:13 ` Shawn Guo
2019-03-01 6:29 ` Michal Vokáč [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47d36e23-1113-56ff-e285-f9bd274004ff@ysoft.com \
--to=michal.vokac@ysoft.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®