From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BA163DBD6E for ; Tue, 24 Mar 2026 10:47:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774349266; cv=none; b=Uo7BCrIIaUL6USp9TOU5wKblA5CM3EbV3LuNpzZIaQWjjipgdaPSuz3MVnR/PWOweNJYdDoXRuprwjKRzzrfEmmHOiFPX2pDuhrPscjd2GtwaKYO5S/vXJCc1tTOLZTpYgN/mKObJXAfOqTC2ray+5r2n7xeKjlnpLSmlD/jyeY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774349266; c=relaxed/simple; bh=vm4vFae9KZ5peWjo+7ETJQKYic+heVZYLQ7TwB1BY34=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W9Lum+vGM9N7WDkyJXp3h+Rb37Yf0Pf8WjTmMwC3zJEkfQpAh3DPoSGei4QFDR13CdlsnJPe91N2GDWL8Kz0V1mOXRaJI+wIcH2SfMzwOeY7Y4FqnlhQoPKHC5tiEgAZYa5l1auT/gtWaxUEsf2rJbu5r6vpkujB12ZvQU/yNmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hAfNLS4a; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jCfAgllE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hAfNLS4a"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jCfAgllE" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62O9uiJS1761785 for ; Tue, 24 Mar 2026 10:47:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ONXmRW2mp05oYjjVFdlwD8Q0MPE75jtjxRhE/bOb+IM=; b=hAfNLS4altDF8hya jqkl7yyUCNlgQmwtS6TTY46R4SqlwWUNcs+NR03AwfpJ3+iCwUD+mNoF5rAr+LRB pM6xTJJ2HgU7ReaCDOwk0zQXeItc6gsohTZBQOCEzD4tH1L48MEeMEJTmIncnVz+ WwoHJZ9f8jbb3CTpYzWI2Qu/ab5cJY63MRcYd18QL8KRRDtnRmhLeqNVDqZ+up40 ajw3ySK+wujFj2Raa2wuB5XdjgyK1LA+8WlIwOs8mt9/TZ9EqOP1lKvmpbttYh7L UpwcdD4NM5H+0EjMYFwXY3GT7iQHInRn7dxq3PeMLhS65LI4gQw5lwzsQ8fyG7bn WKHv4A== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d36f0c3n1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Mar 2026 10:47:44 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b079b4a8c3so35508435ad.3 for ; Tue, 24 Mar 2026 03:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774349263; x=1774954063; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ONXmRW2mp05oYjjVFdlwD8Q0MPE75jtjxRhE/bOb+IM=; b=jCfAgllE9+A+DH1Qv98HSkeHYYSwMlslH4Mi1c7sQTNVT1eG8q/kxuCdaXJSXbPcs7 AgwqdKZ2Uo3bi17WzLnEv6+30riyyHnkkiMcwqLLsANb+V0HM1d4/gEciEfzaIYmkCZ+ 2PJthqj3jEuo/5bIOf9ixvv5Lot7RhOxU1ccnmHexOPvgk495WYwGNNpfB+/Zu9/v50M qyNFsO5goSr7z7L4tHcwsufCqEzreQi1LlDYwJT2b8xOpzMrK3ae0gqckIGuV2OvjC60 LM0Fo1UAWPStgTGYeznPTWKLhCVwn4vEFCgw7BEBlNSi1VPfkMz3koqTutKJVJ7fQaTP OpVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774349263; x=1774954063; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ONXmRW2mp05oYjjVFdlwD8Q0MPE75jtjxRhE/bOb+IM=; b=BI3qDI/l8cQziA8c6OhK9WoQcZiF1DCW8kflQF/s11FprMZttdSOCWjWRJKyXFV9z/ lWSmzfoIeq6Fmy6tRn+/oE2xDGSoGqMZYYo995EZ5ls+ZkJ1g8q8shp8nZgoXfgUIYRF elySsh81C2kZ3XcQxVkcZ+L+ZfO76+D3f1wiiAnz/h4pgz8LVHVGPfZTykg2CJ3KCLy4 rB5qSMu2YXhjhiQMQmr7REQkm8ld3Y/yM0JQvhoyCN2mRKqKSRTn/+gY+iiwSNt6x7wQ /w7OGk0Ka3+eRGyhMSZKT/9NFHuvspBWw86z64kIkXwWdErz6/beS58/QuuaCMOro/ap APzQ== X-Forwarded-Encrypted: i=1; AJvYcCWYd8saNk5TY3FvX70QWlAgc7kne64UncMSNjFB2cMyl6cgH9bLwuJB5sYEgCzwL6mVDLY3dPqB12NEktQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzm9kqmOmxJVyAZJF3XTRTUh5PVdt0TR8xQvrCIW++lYmEAgD3N vhbLw9jjHR/RWsnsOzs3NEpvhUqtuwbs/vkvrUsMaEc4CCW4inUTwLDwzwMcD9mGu/H2IMK+SRq vFs2X/rg8wkxl2ZAeMM7aYDwEY/GokhycEM1jyfelzt1sCtvQW7BlcLm4+snGVG2095c= X-Gm-Gg: ATEYQzyxbfcC/9GtLcIIYAIJJY9nXW/5PO4H1nI34ThDt00XsGW50vy+loPrjwq4kWM J7RWbtlmvImM4BAiuu+HcuOcf0rN2nLg83UUXminVmanrv5bJoXfMpzNHLTV3x3cnREf/hTnbjL jqi0ZFyb9igId6tSqwKrEW/nn8qamJ0RPD9ubWDriynDSZ6m+dnb1HV1gy0HNyyF5iejy5Y1o+b b9LQDdoUDEh9WAXzHvAVrsmueXvdnHkYO3+2nREz3Q8b63qZHwvf0Y7RRkUs5qmPI2g9Z5+oxIV 6oDUsGM58kM9+Ja5iV47Evz9lDkHutQrS6joixeHci1o15AuFT3XuXDCEk45pcourp/yOBDycHt KR9BMBfzgu47SchrBu5fqpEj512XONkE5jaPQiWycmEcjxattO6PD X-Received: by 2002:a17:902:d512:b0:2ad:e521:28cd with SMTP id d9443c01a7336-2b0827a92cdmr151443925ad.36.1774349263493; Tue, 24 Mar 2026 03:47:43 -0700 (PDT) X-Received: by 2002:a17:902:d512:b0:2ad:e521:28cd with SMTP id d9443c01a7336-2b0827a92cdmr151443455ad.36.1774349263045; Tue, 24 Mar 2026 03:47:43 -0700 (PDT) Received: from [10.218.44.178] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08351675esm183655315ad.14.2026.03.24.03.47.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 03:47:42 -0700 (PDT) Message-ID: <47d83a5b-78f6-4354-8543-440ea06b8ffd@oss.qualcomm.com> Date: Tue, 24 Mar 2026 16:17:32 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 11/11] arm64: dts: qcom: sm8750: Add power-domain and iface clk for ice node To: Harshal Dev , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Krzysztof Kozlowski References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> <20260323-qcom_ice_power_and_clk_vote-v4-11-e36044bbdfe9@oss.qualcomm.com> Content-Language: en-US From: Kuldeep Singh In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-11-e36044bbdfe9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=b+q/I9Gx c=1 sm=1 tr=0 ts=69c26bd0 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=RcdfdvLsBkETvr5PKcUA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: _mmO5LOnlClIMasF6vd-W6S3i0sThnf8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDA4NiBTYWx0ZWRfX08SnuyYcUeiU sbKyFi0U2wlo3V8iCjo9Bcp45R/Eg9gKq10M7k1fX6cZQ76sGf9v1ezT+3rPuA08AJ10m/KOliB QeyvQ9djIUqCfcrbk0BGVOyl5/q4zlZz6K8vjz3d8SZqDuIUr6YXgbsiTwpc2SPKxiKl+YWwszH yeUFIzR24Mrzc3Sg1tHw+t9vsQgozzEcn+zwksHeh32Lrk9DNNQpHnSss428WQjWeES+cCay/H8 shwihSKMU0dZPra+VDenaRpoa1WP/AUSe2AZBYIN4iV+IONgZAyQAVg1WSfGFJAUffEELscJjxR ar/0GP1K+pF7Xej1qRES69bTfp+QRC3lvt/AGKgAB3HmQPeabIxXszDiy7m0UbBP+fz3We5EkfR wNPBIDS4waJPqyimJbe2enEU1q7aW8eveU2zRD2Q4MlwbD4V/aIAw+qCh7oLQQdae4l/IXi/1Yf PjszsqejSmMtU5WhVkQ== X-Proofpoint-GUID: _mmO5LOnlClIMasF6vd-W6S3i0sThnf8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_02,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240086 On 3/23/2026 2:48 PM, Harshal Dev wrote: > Qualcomm in-line crypto engine (ICE) platform driver specifies and votes > for its own resources. Before accessing ICE hardware during probe, to > avoid potential unclocked register access issues (when clk_ignore_unused > is not passed on the kernel command line), in addition to the 'core' clock > the 'iface' clock should also be turned on by the driver. This can only be > done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the > GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for > sm8750. > > Fixes: b1dac789c650a ("arm64: dts: qcom: sm8750: Add ICE nodes") > Reviewed-by: Konrad Dybcio > Signed-off-by: Harshal Dev Reviewed-by: Kuldeep Singh -- Regards Kuldeep