From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964907AbdKBVSU (ORCPT ); Thu, 2 Nov 2017 17:18:20 -0400 Received: from mout.web.de ([212.227.15.3]:55874 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934407AbdKBVSS (ORCPT ); Thu, 2 Nov 2017 17:18:18 -0400 To: devel@driverdev.osuosl.org, Greg Kroah-Hartman , Thomas Petazzoni Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] staging: fbtft: fb_ra8875: Use common error handling code in write_reg8_bus8() Message-ID: <47dd8732-253b-a640-1c73-2bfe626037b3@users.sourceforge.net> Date: Thu, 2 Nov 2017 22:18:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:le72iiW7JtsvsWjbyXtHc4HGW8LAlhmLHspyip01coNyDjLbaxU RtcNJCCUHeCKFt5yoVignNgzM1Y7YsyNuw2qxyom7VJ8HrsBMlsDyZ+xWu5J2D3/ZlbfqdJ 1KH4Oa9x1nz4xWH4h+ISWh6WNR7IYdINjfMOWwMC4QBlqMazKkYDtQFM/WIf0x5E+c0JXW5 vGA6MKBFm88u/eeAy0y+w== X-UI-Out-Filterresults: notjunk:1;V01:K0:qVtLS1nttb4=:5y62icK8vp2poJ+T+WV4Ol X5bSlUO8RAnA+sgMXg7a0IhXtspUKLBzZneVWdmMebQT9SN+ganW3PW4M99tyZwoeDnAI+opA tL4f6tHGX7cu/kUIG8jgyMo/VeSVUAE3deSuHJ+SKbJIsI/H2dXW1OGok04svardobUiq5dUy a8TUiZDnyKYfBarP4a5jvrHEtsZaF2fZ5SOxArPkWmA+62ofq/475lLiURHbHcrCuu+f26iDF LbmDsCs3Ha2dvRRUeQUsxE1hgE/IJiYBDgF0+S4BlvB6TKYANba4z/YCHXDkXfn9E93agCEb/ QH4VnW3lEzys+D5ZO1GKLYjc4ZPWWyrGEUSj5tKwI8KQ91k7zO3ASPg9ayF6W2pMXnn4/OSxE EzOtnuNoC1Dw2DdES3/wLYJ2Dwn82hmlHmuL3vQ9qSkeG2QlbUmxLMRBb2UGbuZIBfo9Om+hX Tl2gdiFXM2qKNzC3Efmbhek+PIjg+1yro/XooaizOi6DlikDdxKK2QgDFyWYQ7J4IUYzaqRss B1j8yNmRCPpcdpHAyKiOvbk+BCWQC9GhxAiOpLN9oWtseixG/i+rr0LqMeJQbs1NyKdAhYBHl ew+f7Gu+CUd3b6JMZuwurqjoUqixynS23rgf0vYhdUACJbhQMVeahvswKyoN2mlQlx1J+96p/ A1qmrIPZuycRWJPPmNOCvE2lo96HnOsCg9S5bOLJR0hbtZoAceJIFFRRIPuVz8J2viyzVN9kJ bznBmVe3TeRqE7AKeGxaQZxQcvKpgUb5y+a3ABqgQR+waHtriZPaYoeML62xRD1sLN6BR5e04 MHeGLRHBTkkc2yTACTpwPlIINySUPAF/tGt1dlqPXQC3S+BTgw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 2 Nov 2017 22:12:58 +0100 * Add a jump target so that a specific error message is stored only once at the end of this function implementation. * Replace two calls of the function "dev_err" by goto statements. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/fbtft/fb_ra8875.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/staging/fbtft/fb_ra8875.c b/drivers/staging/fbtft/fb_ra8875.c index 6d1cad85957b..6a94b5810a31 100644 --- a/drivers/staging/fbtft/fb_ra8875.c +++ b/drivers/staging/fbtft/fb_ra8875.c @@ -218,12 +218,9 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...) *buf++ = 0x80; *buf = (u8)va_arg(args, unsigned int); ret = par->fbtftops.write(par, par->buf, 2); - if (ret < 0) { - va_end(args); - dev_err(par->info->device, "write() failed and returned %dn", - ret); - return; - } + if (ret < 0) + goto end_va; + len--; udelay(100); @@ -236,18 +233,19 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...) *buf++ = (u8)va_arg(args, unsigned int); ret = par->fbtftops.write(par, par->buf, len + 1); - if (ret < 0) { - va_end(args); - dev_err(par->info->device, - "write() failed and returned %dn", ret); - return; - } + if (ret < 0) + goto end_va; } va_end(args); /* restore user spi-speed */ par->fbtftops.write = fbtft_write_spi; udelay(100); + return; + +end_va: + va_end(args); + dev_err(par->info->device, "write() failed and returned %dn", ret); } static int write_vmem16_bus8(struct fbtft_par *par, size_t offset, size_t len) -- 2.15.0