From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFD8E1FF7CC for ; Fri, 21 Feb 2025 20:09:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740168555; cv=none; b=RNdzSNV/0cFsh050RsimRy5fUwj3Ye0QuofwYOyvlcu3Si9kvFXG7bNsnE+MMXzJrn4eVEXeWqmThiGPO/ouba5uVCMrjfCpLDwJFwQyym28g9Ju3WIajm4Auj7dFbD8+5VzJxVFNq67JTGVNUHbLVyAr6TPQ+XWGj/IvwUNui0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740168555; c=relaxed/simple; bh=F4ZxpWiPpVGVIIx6Y5UzKKxpUZ2iM962XiXBPB3ONhY=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=XfjcHjUs2pS8kB19yRCkDpVsDA99ds427mu802QG01w4STAmVmzKezgipu1Ypx9/aJj90Ue6afVYoTwD7tZrIlEomDgnabTYf5YZnOn0E2YS3B9ss9DPMwtPAAQ1GquTxA+PkQNVCfybjVnuzfWU4/HWRGaFR+hGhIg8KVqYy8A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=aBgdtEA3; arc=none smtp.client-ip=209.85.160.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="aBgdtEA3" Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-2bc5212b2easo1316493fac.1 for ; Fri, 21 Feb 2025 12:09:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1740168553; x=1740773353; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=W1lUGQu2HwadOSJWdDUBLoMmirB+DmWjdW3wr4b1Cj4=; b=aBgdtEA3kLKwwHLbVev9Bo9OMIcz4k//w/DjxQM6fmy5b/nlt9lfEznATVIvhIsePc KsQiVF7RBM1h/bbA6+L2g64L/gfIA+EgxosoYDieRZHDXd7fHyv8w+R9wZ7FYTg4lyn4 YoyXZTQooopJEHdnPolQ1lrrQE+eA8OefNFLc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740168553; x=1740773353; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W1lUGQu2HwadOSJWdDUBLoMmirB+DmWjdW3wr4b1Cj4=; b=HJ11UGSGxIb4Y3NobRbIdP8PCXmgwP1hS8zKUPJs/h9UxQ6jggnFIMz3BkASiT80qz vVLcDUNXwp1QBQXUy3LgYVPen0w9Qfs+6t7r2rLnpFK0ovG0/utIjE69E79Fxw89ZYGV 2dyuR5FVHlon5xwYH/pcXCOPuPdlkK2tQ5ZrP6+H3biW0pUozAcNGYQR56bRl2JZUel8 CkpZVyTZUC4/hiKcOsj1jb4xFe/WUiGO3FHHA7wcQ3r7ezJRHOhaObuy4gD5vgXEtFu3 rT6wU3PaCNF0XV61zxYSzbguyJVBE8MvxRqHyV/uHr4bbw9Lr501F1BetuqGch6cRlyw GATw== X-Forwarded-Encrypted: i=1; AJvYcCXLUQJoNRU/yMFfA/ZMeDZITRtqgV6nUVPltuqRMjCBGYmbxfyLol+q9rvqIOQpqLUm2ZSqsoAbbg6Vd/0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywst9JYtKQMT4yzrlV8bftd98dS8iQ55LJzQtyVlCEliUK1PvBM Y80RaNosjkbCHd7ya2WGvy6wY64rwpSLXv1iR09cEss9WdOJFrZEgGe5uY01hQ== X-Gm-Gg: ASbGncvnFlObEq/DN+Rw8O/SrWqHLCwCSAziMTadNC6bVyVEJXpzKPdz+KjKXPWec6K vl7Mx8uN7cKOtCxT4Q8/sMUJSPV4RHohRiuvs0dRhhC6Ie570ClKYHrTRpgzHoSi3jMf0fSyAxh dfUKgQxs9CrzoVBBIzYAjM5/84dq/0OalYZN4qbqYgdv96TLQ3Eao4QwjMzu/Od2I4xYkB3q/FM fb28zVuOcGkqtLkS9mk3ny52zAUYANXFemLVp+Ori52VE6RFZTCUf2aKd3uD9Iz3I3cZi9TCCrM 87lXezVI6XubItUDzriKXIVj0BtGADutyHt+hEPOVuqLUc8XZrxw02HIJc3hYlv4yg== X-Google-Smtp-Source: AGHT+IHSa8f4sqShohgGPtu37G2TvzvQIIJNhmNCM0Znb6JovHA4q8y5Xak/spLsgW1qS4w7BMynGQ== X-Received: by 2002:a05:6870:4191:b0:2bc:8c86:ea31 with SMTP id 586e51a60fabf-2bd50d808cbmr3370127fac.20.1740168552765; Fri, 21 Feb 2025 12:09:12 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-72728fba70asm2632841a34.50.2025.02.21.12.09.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Feb 2025 12:09:11 -0800 (PST) Message-ID: <47e20ea6-e5fb-44cf-810c-5fbe8d26abcb@broadcom.com> Date: Fri, 21 Feb 2025 12:09:09 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Florian Fainelli Subject: Re: [PATCH v2 0/5] net: phy: bcm63xx: Enable internal GPHY on BCM63268 To: Kyle Hendry , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heiner Kallweit , Russell King , Broadcom internal kernel review list , =?UTF-8?Q?Fern=C3=A1ndez_Rojas?= , Jonas Gorski Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20250218013653.229234-1-kylehendrydev@gmail.com> Content-Language: en-US Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20250218013653.229234-1-kylehendrydev@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/17/2025 5:36 PM, Kyle Hendry wrote: > Some BCM63268 bootloaders do not enable the internal PHYs by default. > This patch series adds a phy driver to set the registers required > for the gigabit PHY to work. > > Currently the PHY can't be detected until the b53 switch is initialized, > but this should be solvable through the device tree. I'm currently > investigating whether the the PHY needs the whole switch to be set up > or just specific clocks, etc. > > v2 changes: > - Remove changes to b53 dsa code and rework fix as a PHY driver > - Use a regmap for accessing GPHY control register > - Add documentaion for device tree changes I really preferred v1 to v2 which conveyed the special intent better than going through layers and layers of abstraction here with limited re-usability. At least with v2, the logic to toggle the IDDQ enable/disable remains within the PHY driver which is a better location. -- Florian