mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hao Wei Tee <angelsl@angelsl.xyz>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Platform Driver <platform-driver-x86@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andy Shevchenko <andy@infradead.org>,
	Darren Hart <dvhart@infradead.org>,
	Ike Panhc <ike.pan@canonical.com>
Subject: Re: [PATCH] platform/x86: ideapad-laptop: Expose conservation mode switch
Date: Sun, 11 Jun 2017 13:07:07 +0800	[thread overview]
Message-ID: <47e2af96-1b97-6654-e65c-eea570383abb@angelsl.xyz> (raw)
In-Reply-To: <7ba76865-7fb2-615a-8bcd-35e14b862a8e@angelsl.xyz>

On 5/30/17 10:05 PM, Hao Wei Tee wrote:
> On 5/30/17 9:22 PM, Andy Shevchenko wrote:
>> On Sun, May 28, 2017 at 4:47 PM, Hao Wei Tee <angelsl@angelsl.xyz> wrote:
>>> On 5/27/17 3:31 PM, Hao Wei Tee wrote:
>>>> This exposes the battery conservation mode present on some (?) IdeaPads.
>>>> The mode is set by calling ACPI method SBMC with argument 3 (on) or
>>>> 5 (off). Status is reported in bit 5 of the return value of ACPI method
>>>> GBMD.
>>>>
>>>> This patch was written based on an IdeaPad U430p. I'm not sure if the ACPI
>>>> methods are the same across all IdeaPads, so it would be great if this got more
>>>> testing across other models before it's merged.
>>>
>>> I got someone to test on an IdeaPad Y510p. It works on that too.
>>
>> Do we have any other option that expose something via sysfs?
>>
> 
> Sorry, not sure what you meant.
> 
> If you meant
> 
>> Do we have any other options than expose something via sysfs?
> 
> I'm not sure, maybe an ioctl? That wouldn't be very convenient though.
> 
> The tp_smapi module (not in mainline) that exposes the battery threshold
> functionality for ThinkPads also uses sysfs.
> 
> If you meant
> 
>> Do we have any other options that expose something via sysfs?
> 
> yes, camera_power, fan_mode, touchpad and conservation_mode.

Any thoughts on this?

-- 
Hao Wei

  reply	other threads:[~2017-06-11  5:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-27  7:31 Hao Wei Tee
2017-05-28 13:47 ` Hao Wei Tee
2017-05-30 13:22   ` Andy Shevchenko
2017-05-30 14:05     ` Hao Wei Tee
2017-06-11  5:07       ` Hao Wei Tee [this message]
2017-08-05 15:18     ` Hao Wei Tee
2017-08-06 18:35       ` Andy Shevchenko
2017-08-07 13:20         ` Hao Wei Tee
2017-08-13 12:15 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47e2af96-1b97-6654-e65c-eea570383abb@angelsl.xyz \
    --to=angelsl@angelsl.xyz \
    --cc=andy.shevchenko@gmail.com \
    --cc=andy@infradead.org \
    --cc=dvhart@infradead.org \
    --cc=ike.pan@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®