From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06362CA0FFD for ; Tue, 5 Sep 2023 16:57:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245301AbjIEQzI (ORCPT ); Tue, 5 Sep 2023 12:55:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354005AbjIEJKk (ORCPT ); Tue, 5 Sep 2023 05:10:40 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B776FDA for ; Tue, 5 Sep 2023 02:10:36 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2bb9a063f26so34452821fa.2 for ; Tue, 05 Sep 2023 02:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693905035; x=1694509835; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ezWE+bRS8Wk4jpjdVoE0OX6tkD+1ncG7U6Faqey9Iec=; b=o0n8z//ZmPqMBWjAzFPkfhGwOhtntpqbkhStLcf4MjohsALQEzFUfT29kcU5wMOq1m we/OK3ZKmI/9Dha6Ce32/aHGHsBH+gA/qlW2MQtdPrbALBqf0m2kAkCKk9+4+Itk4JEu iYmrFBEIjKRrE5wDGuA5Ig61NbaxtfNmCD9EGxuGcfui2V6VoidQ1TWVEVM9rbRk018B PVt9hEg6Inz+LMQJQB4O+mERwpPDYsWmWA01HVKsrNJj84mhHrZ2BRu71ADJhdrtvyY/ 8Y2Zkc76F3NqEQi72qYfp2LvbvJCcpy2uyetHLuG531zeGyfAqkEbGWfmEeSUMPJ/sUv VgAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693905035; x=1694509835; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ezWE+bRS8Wk4jpjdVoE0OX6tkD+1ncG7U6Faqey9Iec=; b=JZuCsxTB288Wf/PBIa1SG97n8od+VtoZXUa+KyheTlXG5u4gVbO4fHFShSA716x0D5 AgG4JvG0cDSEpD83xs3EOP3f65YmBZwwz9732sErg/w5YTAueTJ/3zmlmZ2WkJRnbC7S SwFi7I4ieD5uHCaTUy+GPn7nqhYbntjF0MtWa8pmsh5Clr5ecvSgT1vAj7Vd/ka+qaF+ +QE4lVUzu+RGs9HlD0jUkEQXlNscvt3mW8a6GS+B4TALDIpFU4pPMvcBdQBjV0dkE9Km sOzz55VT0ZJU7bp18DD7Ugc2//+p+6ryUKJqUxuaMHyTHLRmd0me1DQjtzhpCNgD827x O+sA== X-Gm-Message-State: AOJu0YyUSYqfQ0D67NrZ6XxxO8ZT0Hh8cLWIZCBgCUM+0r6syoh+mXor yic8XKhqXzw2d0NuNGU101WN+w== X-Google-Smtp-Source: AGHT+IG/8Hg4BQMrH3+6aAoIu20KNzzz3XovcTafQIcQqq0cptHRxvTbfy4fQLNbmvLJnypcjovVXw== X-Received: by 2002:a2e:8e8b:0:b0:2b6:e2e4:7d9a with SMTP id z11-20020a2e8e8b000000b002b6e2e47d9amr8925009ljk.38.1693905034899; Tue, 05 Sep 2023 02:10:34 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id t25-20020a7bc3d9000000b003fed4fa0c19sm19551513wmj.5.2023.09.05.02.10.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 02:10:34 -0700 (PDT) Date: Tue, 5 Sep 2023 12:10:31 +0300 From: Dan Carpenter To: Harshit Mogalapalli Cc: dmitry.baryshkov@linaro.org, Loic Poulain , Robert Foss , Andi Shyti , Liao Chang , Todor Tomov , Bjorn Andersson , Vinod Koul , Wolfram Sang , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, error27@gmail.com, vegard.nossum@oracle.com Subject: Re: [PATCH next] i2c: qcom-cci: Fix error checking in cci_probe() Message-ID: <47e3acac-7d4f-43bd-bd55-5ae9ab993f2d@kadam.mountain> References: <20230823194202.2280957-1-harshit.m.mogalapalli@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230823194202.2280957-1-harshit.m.mogalapalli@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 23, 2023 at 12:42:02PM -0700, Harshit Mogalapalli wrote: > devm_clk_bulk_get_all() can return zero when no clocks are obtained. > Passing zero to dev_err_probe() is a success which is incorrect. > > Fixes: 605efbf43813 ("i2c: qcom-cci: Use dev_err_probe in probe function") > Signed-off-by: Harshit Mogalapalli > --- > Only compile tested, found by static analysis with smatch. > > https://lore.kernel.org/all/CAA8EJprTOjbOy7N5+8NiJaNNhK+_btdUUFcpHKPkMuCZj5umMA@mail.gmail.com/ > ^^ I reported initially here, Dmitry suggested we need to fix it in a > different patch. > > the Fixes commit used above pointed this bug, but the real fixes tag is this: > Fixes: e517526195de ("i2c: Add Qualcomm CCI I2C driver") This has already been applied but, for future reference, you should have gone with the real fixes tag instead of where the static checker started complaining. regards, dan carpenter