From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f53.google.com (mail-dl1-f53.google.com [74.125.82.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97257378826 for ; Mon, 23 Feb 2026 22:20:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771885224; cv=none; b=QySA0vWuq5hSkIud4FHNd9YBTylJHBrZ8A3uDxSzYIEFeucHh3m5YYGk3TNAMyKMDDyCdkR/d9gv3Aig4aYIMswKqlLq5dkvxxBeFbf9rIhcvwGqKVTKN8X43cJTMUctAKwZAMQ5mThaPE4Bq/0tCyWQ+PMqgUpb03vYuXAn2W0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771885224; c=relaxed/simple; bh=XRd3VA7wRyKsEasRx46x6zX9uXlSiuYouuXHt3cldf4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sEYHHgnA9lyLr5cN0Xw6IWQp2hMETtfapr8ByZiQDdUKat9FC1zn8sXXSJrK0jN0a43GdbzlFXoFD4fhn/3aT6pAoM70Q1BBplQIprwOZRJ6DkxwhUXjXKJ1+nUALI36VsdH1TB7+VSO1om3JPtXS0noNc5+1AxbSjiBgEce3Uc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ky5OKX6K; arc=none smtp.client-ip=74.125.82.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ky5OKX6K" Received: by mail-dl1-f53.google.com with SMTP id a92af1059eb24-124afd03fd1so6651203c88.0 for ; Mon, 23 Feb 2026 14:20:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771885223; x=1772490023; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mj9k1WXkCt0XplOOQNM1a6yqi/IjFpj42u/vWNAn/kg=; b=ky5OKX6K9aZuyGyTzVz56XCjBC0MJZJYUP0tEaoB7S6drDMcKSSeQ0jy8UMePZJN91 7qWtMV8XOSZT/HzTKLsME50wRO96OmNH1UqtI//zpidM4us3cnyAbFHJpZNN7ZPms+1V XogHIQk4fRHihAdyZC0KKnufKT664e9OiI700N61PV4FnijKdU/dAkfYPD7U14Kl0v/E HMW64PhyaimuN5l/PQNlAqaGzaI2Hv3nPPvnjEyvqMkWrTPQH/4YQuiGZHoM/C9BxgZu G17huVSHukNq+39yIg6I3wAojmabuGYwNquhFaGBa0o6WiNcHfMk03HGgzEkoSYNi5hv rv+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771885223; x=1772490023; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mj9k1WXkCt0XplOOQNM1a6yqi/IjFpj42u/vWNAn/kg=; b=ekmXWQqq2Yq1BK6tKzQ0aIGHr5smF5irpszMlRYUXYyH8pl0zRqlDW8BSqm28y5cyL tZqr7+3s/xxscwisr/L4VebIuXtOjPA9b3YPTRFkoaAgRpml1WfyfQN2xudGkEJlfSh1 NUbai/TaisgZlQNv2WUDjw3vFy9PuCrPJl68PJTnusTVoPD1WCU2FhJTSuPRcmx4Dx+E +v6AU+5tWz0mD1G5vgn2OPIWqw58ZWtyxJvql7MvpDddWjp2ekgJZt/Uv9Cywzob4PQR aZTVoNS8R37TvRmPGO1D2t0dmboqebBBPS9PCcO4EjXmCCrzA9955/NhYWGhkjBc0vwX KbyQ== X-Forwarded-Encrypted: i=1; AJvYcCW5eTo+lZZRJ86h/xCZ7XUoRdq1zwBTTnUj/UfvjOlO87VpMxsT0UA8M1pw53jKCKC8cZBkz5Mqf/wJKpQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxuxQ6yrzaSoZQ34eD7TXgH5RANGT67yvOXB1YTeklgoHS/axEe vellvDI1nYYfSJ49zygKD6348Y21DzJK7ldfqRE9/k2TrQraDMdlNt8j X-Gm-Gg: AZuq6aKopTzCViUehv7vbHEfNzpg7R1u/5ybSQ2cNrEIs9N04GAWCUxMoXXJ6GIDDi0 6r9ukbJ1wvWjcuGvt70ZbdRXYVLYzrukW3cqhspUcN13Ixl7zl2Txew9QfAGNQFWFDdi349zc8l 4lSZ1rGP5nBwXoOraQP/jgu6+g/qRW+JXqDmzlYpnXBPWKmNIhGUjcivzfaJar3Jc2qb3qtOOwC ayZ30Nq8PdE3hOF424fZaFG5j8posGsGBBD9TM72Irt0/eoTtsPoMwszIJ+pBsFNjXDKeOfL44w Nus9GMrfLs5jwHOYZatCrzbSnJQypVmu6Ton8L6fZJvSxgGPU/GLgOfNExU2b1ANTSFbmK/c4rI TrpxQ9ypFD2JZGcw83YPMqKJimTFewNB2ulHTDmzazyes/dFu16UFnYXviGL4H/SwTWCYMR/pnk 0q6gbsjjmCxBU35JaetgjlM58c6ijU30vtgBeIt9gkjzJMAFIWp/k14W82eLHrxbZB1xwU6X/z7 ahTAMpluG4rl9jZIUVcqysREpHHn0r6dBuRiNpsaPbE8/EYaiiADKiNh8BL3fzRkDzXM8By931q ELYf4gXINQFcP+Y= X-Received: by 2002:a05:7022:10a:b0:119:e56b:91d1 with SMTP id a92af1059eb24-1276acb7d9emr2904720c88.2.1771885222592; Mon, 23 Feb 2026 14:20:22 -0800 (PST) Received: from ?IPV6:2a00:79e0:2e7c:8:b343:b0de:3e59:4e65? ([2a00:79e0:2e7c:8:b343:b0de:3e59:4e65]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bd7da3eec5sm5583565eec.4.2026.02.23.14.20.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Feb 2026 14:20:22 -0800 (PST) Message-ID: <47e4b9af-8a0a-459a-95a0-c931af351310@gmail.com> Date: Mon, 23 Feb 2026 14:20:20 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/62] drm/pagemap: Unlock cache->lock before freeing it To: Matthew Brost , Bart Van Assche Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= References: <20260223220102.2158611-1-bart.vanassche@linux.dev> <20260223220102.2158611-12-bart.vanassche@linux.dev> Content-Language: en-US From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/23/26 2:14 PM, Matthew Brost wrote: > On Mon, Feb 23, 2026 at 02:00:11PM -0800, Bart Van Assche wrote: >> From: Bart Van Assche >> >> Although freeing a spinlock without unlocking it is fine, this confuses > > Fine, but pretty bad practice. > >> static analyzers. Hence this patch. >> >> Cc: Maarten Lankhorst >> Cc: Maxime Ripard >> Cc: Thomas Zimmermann >> Cc: Thomas Hellström >> Cc: Matthew Brost > > With that: > Reviewed-by: Matthew Brost > > We can apply this to the DRM branches and propagate this up to Linus > during 7.0 cycle if that works for you? Or if you have other plans to > merge, let us know. Peter asked me to split this series into one series per maintainer and to send the patches directly to the respective maintainers. Feel free to queue this patch in a DRM branch. Thanks, Bart.