From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034841AbdD0TrK (ORCPT ); Thu, 27 Apr 2017 15:47:10 -0400 Received: from mout.web.de ([212.227.15.14]:61045 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939018AbdD0TrD (ORCPT ); Thu, 27 Apr 2017 15:47:03 -0400 Subject: [PATCH 1/2] coresight-stm: Use devm_kcalloc() in stm_probe() From: SF Markus Elfring To: linux-arm-kernel@lists.infradead.org, Chunyan Zhang , Mathieu Poirier , Mike Leach , Pratik Patel , "Suzuki K. Poulose" Cc: LKML , kernel-janitors@vger.kernel.org References: <52619d05-65c4-149d-f355-cf9c037a0c9b@users.sourceforge.net> Message-ID: <47e6431f-1093-3a58-3ca4-406284c081aa@users.sourceforge.net> Date: Thu, 27 Apr 2017 21:46:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <52619d05-65c4-149d-f355-cf9c037a0c9b@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:rwd16eAeJd2mi1ycLgzjraW1bccPPbzYzdx+r2L6ZfKcKGVGWfp m7arzpiOQ9q7zVaRlyARaPc9dNUGxcrLvfAl0Y7SXNz9JRduI3OJAxHh79jtsRsQCvqzYxY XW4AsPnxm25w7mRo2aeopMyj9hs1Zc4bRr4FCOByJUGYTZo6NBapmv08+M6fPvaki96zTf0 sXw3p4UyFqpOl47fyRjPg== X-UI-Out-Filterresults: notjunk:1;V01:K0:bsuEHZJXig4=:84OxTuacLxkkUkL0jzd0/z gcfXwI0QHFH8NssflGtd2D5COvkJP6uL8rYPOiz0GMeeprsD5OqfCZ9IAJ7geEbOUvIBTXfBm ngvWbCb+VDni/gd/P2mCT/2Xogyf6C7WRyUwHmttVHhKKyU9dej/gZyXizdJbvJP9tfeGCEGN niutyIRXAkxie34gzAJD5B1jfAfvZfEUP08+Amzdc3xx/RwoewWImH/Bs1nphMCwBxPjHqqXg Lz38yvs0AZ6D0sDGbWBeDYyZL5SeWA8VqK8WTfLTWj4yn3HVicxagWv9MFN2q3Q321o790Wl/ L7ItkBdjRq/s0uQOq0vOeqE4Jxb6sYjqYlkEwl7oEvkQKXbB04dB3zNgZt76EVHjJjJEynH6O HGCluig77Jv+Gp+TU2aUVFE1YkIO+v6FRPgJPP4D93zptShRBWIWB30dwZuQklSlqA7ySxPH1 WIw9mVGi8WnZMlUnnFQ1rKCOBUJ63tv/EA1DZEzbWDDYM1JFqJbMDAZyJrXWC1Sor08Jll+br PPNX2LfG3HwUHOfwBGpNDoWhx/pOce21y0u0vHwoqp82CqfW95/ZtZHkkOD9qsCnB68O+ANzj ax/D0B1OO5al+W9lgAX7ZdiFy+xvQjFmdv7YhMMKcurXieh24zpNx83cNA7DxT7TSJqEVANke dZ9A9egaobJfxfWbaO38/XcKfgd08aZpTglMbboCtaGC+Zt8OXPTB44Up/r+h1EL1yl52CPx4 4nPWoWb17bPtT4fgcJU0gFad9Q/M8aWV+Rjh3HY+520CMdSOf28CakFn9ubebbCQ6TvpARz9a GUM1kvK Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 27 Apr 2017 21:18:57 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kcalloc". This issue was detected by using the Coccinelle software. * Delete the local variable "bitmap_size" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- drivers/hwtracing/coresight/coresight-stm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c index 93fc26f01bab..bbb5275bf0d2 100644 --- a/drivers/hwtracing/coresight/coresight-stm.c +++ b/drivers/hwtracing/coresight/coresight-stm.c @@ -799,7 +799,7 @@ static int stm_probe(struct amba_device *adev, const struct amba_id *id) struct stm_drvdata *drvdata; struct resource *res = &adev->res; struct resource ch_res; - size_t res_size, bitmap_size; + size_t res_size; struct coresight_desc desc = { 0 }; struct device_node *np = adev->dev.of_node; @@ -848,9 +848,9 @@ static int stm_probe(struct amba_device *adev, const struct amba_id *id) res_size = min((resource_size_t)(drvdata->numsp * BYTES_PER_CHANNEL), resource_size(res)); } - bitmap_size = BITS_TO_LONGS(drvdata->numsp) * sizeof(long); - guaranteed = devm_kzalloc(dev, bitmap_size, GFP_KERNEL); + guaranteed = devm_kcalloc(dev, BITS_TO_LONGS(drvdata->numsp), + sizeof(long), GFP_KERNEL); if (!guaranteed) return -ENOMEM; drvdata->chs.guaranteed = guaranteed; -- 2.12.2