From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 288D1C7618E for ; Mon, 24 Apr 2023 07:01:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231164AbjDXHBt (ORCPT ); Mon, 24 Apr 2023 03:01:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231168AbjDXHBm (ORCPT ); Mon, 24 Apr 2023 03:01:42 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23FBA11A for ; Mon, 24 Apr 2023 00:01:41 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-94a34a14a54so731924966b.1 for ; Mon, 24 Apr 2023 00:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682319699; x=1684911699; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cAMolMF/0A91B5GkAOKhgDLGZThujf5CyOxv40ltXw0=; b=J5lj6XRZGCkvCTcF7VnaYV56c40TbbkAkmFxrRXNDwdfZPsZuisqBUZWPmwZD6af3B Y8pe+xTQ2L2nYJrYpAzJ4ZZlWHEWlWHtGUUhe3g3mLjohIUfDEpieOkWGk+WrqpYnvbR uaf0M2ON09K6KIbkhzo4NJ7C9KQKaPB984mpJpUI+uLiQu7qFdadX3uij+4ktKkWs7Sq FhxILPn7Tcx28lko6wnyYKkO4r6Zb0JLLpcqwsjVoCdPbdG4x8UbV7eLy11Ty6KUnDv7 +rq8q6NTyiyUGMdECysXQrhuGip8YzkeAgzZGf4nrHd9rgEDPdaSDTLTS5SCiTdAp+dZ e+hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682319699; x=1684911699; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cAMolMF/0A91B5GkAOKhgDLGZThujf5CyOxv40ltXw0=; b=Eos/rf/q/Z723KBlX6gQD/dUS0C7fRFTx/DilD89R6iJhK7tWjxN3c0qShev8fWdAV 80rwwvlFedM95MzvU++hYuufik20SWFuCOtGKhr3Mhg/Bau1WMnM4nCEBtp/hiuDev5M gW7WgHwgC/4E3f9FE6hLq8EgSokUirF3c5AZWHKQmtO3TMcWHb31BYrnF78vJQ6hSKmd kz07vNxgfs+kxtGO8/IeLAR65E+AQfB2hcSk1+WN3vMmeJ4bgpoxC17xUBBP74chP5q+ PBm2Gd5S7ovOcMX7WWZJ47bfDQ12aXQBhVWZROaLDZUYKSffa73jLRNnHVTbDtcqpLxo 6q4A== X-Gm-Message-State: AAQBX9fAjbYCsPV4ujteujmBanS5B4GHV8uWDVpchdCN/nGUNfacQ8VN VScSsnz1m3SGl4aeCZkKmEfrHA== X-Google-Smtp-Source: AKy350aDLD/mZWyW4UWiZOr+Tv9jOTXgUlnhG5JdEneUkzO4rI9t9amSpsZLJGzNXSZ6V4sTbrorkw== X-Received: by 2002:a17:906:5904:b0:94f:928a:af0f with SMTP id h4-20020a170906590400b0094f928aaf0fmr8529727ejq.47.1682319699600; Mon, 24 Apr 2023 00:01:39 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:fcdb:bf53:d053:3a52? ([2a02:810d:15c0:828:fcdb:bf53:d053:3a52]) by smtp.gmail.com with ESMTPSA id qp24-20020a170907207800b00882f9130eafsm5159020ejb.26.2023.04.24.00.01.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Apr 2023 00:01:39 -0700 (PDT) Message-ID: <47e8113d-39ad-cf18-a763-89ee883da233@linaro.org> Date: Mon, 24 Apr 2023 09:01:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] drivers: nfc: nfcsim: remove return value check of `dev_dir` Content-Language: en-US To: Jianuo Kuang , Thierry Escande , Samuel Ortiz Cc: hust-os-kernel-patches@googlegroups.com, Dongliang Mu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230424024140.34607-1-u202110722@hust.edu.cn> From: Krzysztof Kozlowski In-Reply-To: <20230424024140.34607-1-u202110722@hust.edu.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/04/2023 04:41, Jianuo Kuang wrote: > Smatch complains that: > nfcsim_debugfs_init_dev() warn: 'dev_dir' is an error pointer or valid > > According to the documentation of the debugfs_create_dir() function, > there is no need to check the return value of this function. > Just delete the dead code. > > Fixes: f9ac6273e5b8 ("NFC: nfcsim: Add support for sysfs control entry") > Signed-off-by: Jianuo Kuang > Reviewed-by: Dongliang Mu > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof