From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F5682045AD for ; Mon, 1 Dec 2025 21:04:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764623088; cv=none; b=JqYFKs/KWAUTTXeeY6uKm1PXMxJCGhh7oaM+x1liP/pjNv1I0NpmXuqCfJ93PFSvsseBWERacmYKP5fGAmupRhFa8DM8pvNQroZYS2XHyXFfxgH58UTEjR8ujoctpI3S19BcYj+ZO1k8Ba7KPkhGhT8NrdxG3TqmorzzH00qA5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764623088; c=relaxed/simple; bh=RCsVhoMziLTlsWEXutjwzN/H9l/9RoDXtZVKvXMTT8Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=T/MkD7fLEKKf7qJJFR6wYdYgTjyMBxWS7euxY+NiBpEkfMLW4/JbvwV026XkYCZFtYpBl/f9VT64SGuvrkmi/T63lbbCUvxOuiw5aEX28rH6KxSSjePbd8zRx7TyiVd8N6/DMmjyGuUgsHfwEfJOotbnFWuEqGtxg0nnTDmbphQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OBOLxtsq; arc=none smtp.client-ip=209.85.210.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OBOLxtsq" Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-7c52fa75cd3so3568760a34.3 for ; Mon, 01 Dec 2025 13:04:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764623084; x=1765227884; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QwOlm/EYAEjlVOmwG4107usguWk7Wsz8CJGeHU7XeLA=; b=OBOLxtsqJVPSKW+aHIpA8zwjV8HyHRBAh1BGfHFRU1JV+Sgc2GA66rRqiRzgA5Qh3i Yb2voglyzTCb5ScMJBo2TZA0Rny586Os2wbxSABYSJFO819mJTFeYGz2ktc5hU6K4gOr jBqzCav7Y9P5Sp1jrLE6/8GYzEGwJaKM66ws1uy3LKUkjY6oXRQmiF7Pu/6Fc1RLglWR L+AlvRj8ioZXTqHVDw437sB0seRPXc1meRz23GQbKL2QmxS4xkDPNyAOgzqNpeBublYB WeXpxZP3BO6hKGPC7kW6oSsaHQ2/hQd144T9S2hG87B1nxu+HwkJV/Ob09w5scnEwvR5 RO7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764623084; x=1765227884; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QwOlm/EYAEjlVOmwG4107usguWk7Wsz8CJGeHU7XeLA=; b=R1nKbZDxrDiiWLHY1JpvTONuF8yTpTsDLdyqLEG7Zj//2jxxoE7V/fXBWUHCbZulVA eSL1NSxB4TGgaIZ5x3fHaKfuFZhnt+FWvuZE5TtxGg6hyIDORJs8UetvD9+nhr1O8DHL hbK7WYOhp7ZP77xFwADicNssWAumktc0EFCLdKLJWnOxADD2UdRnW28KlUUqE5Q5yr4/ UbefjPxgtkGAccy908BHMo2mK5oZ6jQzRuJD0gkGoLYAZeXLb4dM50mu6GJeBJQFSwTL 3PbsiwfiRCbOyPPF/DLn0jqbed9JOw/VrsVc/1WhCeVNz/oAQ6CTKGOEy+RKOaTozj5S 8pYQ== X-Gm-Message-State: AOJu0Ywb/Ka6ZSX7lqJj5N8+AEYl79yrA0LedX67H4Xvl4KQzV7iYuHt yfw644SVdu3rgAtmDGRxVFr2NvhBXea51zDwQgQV8tk2zbshGvx9k2Ha X-Gm-Gg: ASbGncviLGBpVWU8F1YfaVPNeYYuVx1AZ5wJXKuHU4S0U5PjwCoKhEOud+CYnkj5jxC fwxOcCW+MQf+CvC07hPVRpCfAg8e/VRQig8EDtq8rvZqdX5Pmvr3Wp2MzSSl8yoRio5dcI2FYGT pik2ts/Alr2IzDWh+QYxYFZ2YkBmynBIAZH11WB5vfTSRI6h2YcKZR0COFxX8Kmj9CJekXPE9Hi mUI+/8EfkpwCUIcepG+RarWXkBBwalkD1s1+rwfTSex5w/HXNp3g+4tdo5qsMJSYZGcK8lG/o/V JDJLPY9UvyojSnU5tb1GM8WeegLEHlP7x3gZYDk7zLbkfody3xchjjr+NFFFhe6VOZwdubgq7oQ 4S8nQd6BvidQlCfsyfY2H/q2vd4GUf/hdvl+KtG6YyZr9E4YcU0aC7XZDLhhZGntgxVcAWcAY3I cNIqRL3hOO8FRfXsZEnVBX6V6GdLSgDJUFaC1H/NkLQ315FioCz866hvaXxmcbs0bCyZCMVvdm0 dKj2JAJkz7bY6rhMjv+Za25qdCnMANH4w== X-Google-Smtp-Source: AGHT+IFiFedp/ndsw4dL4kyumPRb+RsFpIkJnX2Tsf9N0bw5HOBbzoF37M3d37e7AG8acuTRmJi7/w== X-Received: by 2002:a9d:6143:0:b0:7bc:f443:fa3c with SMTP id 46e09a7af769-7c798de468amr17127045a34.25.1764623084473; Mon, 01 Dec 2025 13:04:44 -0800 (PST) Received: from [192.168.7.203] (c-98-57-15-22.hsd1.tx.comcast.net. [98.57.15.22]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7c90fe15847sm5167781a34.25.2025.12.01.13.04.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Dec 2025 13:04:43 -0800 (PST) Message-ID: <47f6bed6-4d21-4e11-ade5-b3314d026502@gmail.com> Date: Mon, 1 Dec 2025 15:04:42 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] remoteproc: qcom_q6v5_wcss: use optional reset for wcss_q6_bcr_reset To: Konrad Dybcio , andersson@kernel.org, mathieu.poirier@linaro.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, Philipp Zabel Cc: linux-kernel@vger.kernel.org References: <20251129013207.3981517-1-mr.nuke.me@gmail.com> <20251129013207.3981517-2-mr.nuke.me@gmail.com> <1ba66817-42e2-4c63-8a94-d2e5c9cb8c34@oss.qualcomm.com> Content-Language: en-US From: mr.nuke.me@gmail.com In-Reply-To: <1ba66817-42e2-4c63-8a94-d2e5c9cb8c34@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/1/25 5:21 AM, Konrad Dybcio wrote: > On 11/29/25 2:32 AM, Alexandru Gagniuc wrote: >> The "wcss_q6_bcr_reset" is not used on IPQ8074, and IPQ6018. Use >> devm_reset_control_get_optional_exclusive() for this reset so that >> probe() does not fail on platforms where it is not used. >> >> Signed-off-by: Alexandru Gagniuc >> --- > > This reset is not even used (or documented anywhere).. the closest > I can find is "wcss_q6_reset" in qcom,q6v5.txt, initially documented > in: > > Fixes: 3a3d4163e0bf ("remoteproc: qcom: Introduce Hexagon V5 based WCSS driver") > > which claims it was made for.. IPQ8074 > > Peeking at the GCC driver, this reset is most likely present as > GCC_WCSS_Q6_BCR The downstream kernel uses GCC_WCSS_Q6_BCR for ipq8074 [1] and ipq6018 [2]. They only use of ->wcss_q6_bcr_reset in the QCN404 path, which does not use ->wcss_q6_reset. So maybe we can get away with calling it "wcss_q6_reset", store the pointer in ->wcss_q6_reset, and drop '.wcss_q6_reset_required' Which path do you think is the most appropriate? Alex [1] https://git.codelinaro.org/clo/qsdk/oss/kernel/linux-ipq-5.4/-/blob/NHSS.QSDK.12.5.r5/arch/arm64/boot/dts/qcom/ipq8074.dtsi?ref_type=heads#L1060 [2] https://git.codelinaro.org/clo/qsdk/oss/kernel/linux-ipq-5.4/-/blob/NHSS.QSDK.12.5.r5/arch/arm64/boot/dts/qcom/ipq6018.dtsi?ref_type=heads#L1440 [3] https://git.codelinaro.org/clo/qsdk/oss/kernel/linux-ipq-5.4/-/blob/NHSS.QSDK.12.5.r5/drivers/remoteproc/qcom_q6v5_wcss.c#L967