From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B932CCA479 for ; Thu, 2 Jun 2022 07:40:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231883AbiFBHkS (ORCPT ); Thu, 2 Jun 2022 03:40:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231871AbiFBHkM (ORCPT ); Thu, 2 Jun 2022 03:40:12 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3DAFDD4A; Thu, 2 Jun 2022 00:40:10 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 76CAD1063; Thu, 2 Jun 2022 00:40:10 -0700 (PDT) Received: from [10.57.38.114] (unknown [10.57.38.114]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 29B353F66F; Thu, 2 Jun 2022 00:40:09 -0700 (PDT) Message-ID: <47f72a91-6af1-d82f-8e4a-b8929725ff19@arm.com> Date: Thu, 2 Jun 2022 08:40:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] memory: samsung: exynos5422-dmc: Fix refcount leak in of_get_dram_timings Content-Language: en-US To: Miaoqian Lin References: <20220602041721.64348-1-linmq006@gmail.com> Cc: Krzysztof Kozlowski , linux-pm@vger.kernel.org, Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org From: Lukasz Luba In-Reply-To: <20220602041721.64348-1-linmq006@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/2/22 05:17, Miaoqian Lin wrote: > of_parse_phandle() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > This function doesn't call of_node_put() in some error paths. > To unify the structure, Add put_node label and goto it on errors. > > Fixes: 6e7674c3c6df ("memory: Add DMC driver for Exynos5422") > Signed-off-by: Miaoqian Lin Thanks for the patch, LGTM. Reviewed-by: Lukasz Luba