From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCHv2 01/12] dt-bindings: power: supply: adc-battery: add binding
Date: Wed, 15 Mar 2023 07:43:07 +0200 [thread overview]
Message-ID: <47f9e288-6c1b-6205-8538-303b65ff160d@gmail.com> (raw)
In-Reply-To: <20230314225535.1321736-2-sre@kernel.org>
On 3/15/23 00:55, Sebastian Reichel wrote:
> Add binding for a battery that is only monitored via ADC
> channels and simple status GPIOs.
>
> Signed-off-by: Sebastian Reichel <sre@kernel.org>
> ---
> .../bindings/power/supply/adc-battery.yaml | 70 +++++++++++++++++++
> 1 file changed, 70 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/adc-battery.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/adc-battery.yaml b/Documentation/devicetree/bindings/power/supply/adc-battery.yaml
> new file mode 100644
> index 000000000000..ed9702caedff
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/adc-battery.yaml
> @@ -0,0 +1,70 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/supply/adc-battery.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ADC battery
> +
> +maintainers:
> + - Sebastian Reichel <sre@kernel.org>
> +
> +description:
> + Basic battery capacity meter, which only reports basic battery data
> + via ADC channels and optionally indicate that the battery is full by
> + polling a GPIO line.
> +
> + The voltage is expected to be measured between the battery terminals
> + and mandatory. The optional current/power channel is expected to
> + monitor the current/power flowing out of the battery. Last but not
> + least the temperature channel is supposed to measure the battery
> + temperature.
This looks very good to me. Even I fell under the illusion I know what
these bindings mean and how the hardware looks like ;)
I am terrible with the bindings syntax so this is not worth much but:
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
Yours,
-- Matti
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
next prev parent reply other threads:[~2023-03-15 5:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 22:55 [PATCHv2 00/12] Add DT support for generic ADC battery Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 01/12] dt-bindings: power: supply: adc-battery: add binding Sebastian Reichel
2023-03-15 5:43 ` Matti Vaittinen [this message]
2023-03-15 6:43 ` Krzysztof Kozlowski
2023-03-15 7:51 ` Linus Walleij
2023-03-14 22:55 ` [PATCHv2 02/12] power: supply: core: auto-exposure of simple-battery data Sebastian Reichel
2023-03-15 7:01 ` Matti Vaittinen
2023-03-16 0:41 ` Sebastian Reichel
2023-03-16 7:10 ` Matti Vaittinen
2023-03-16 7:13 ` Matti Vaittinen
2023-03-17 22:34 ` Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 03/12] power: supply: generic-adc-battery: convert to managed resources Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 04/12] power: supply: generic-adc-battery: fix unit scaling Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 05/12] power: supply: generic-adc-battery: drop jitter delay support Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 06/12] power: supply: generic-adc-battery: drop charge now support Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 07/12] power: supply: generic-adc-battery: drop memory alloc error message Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 08/12] power: supply: generic-adc-battery: use simple-battery API Sebastian Reichel
2023-03-16 7:38 ` Matti Vaittinen
2023-03-17 21:58 ` Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 09/12] power: supply: generic-adc-battery: simplify read_channel logic Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 10/12] power: supply: generic-adc-battery: add temperature support Sebastian Reichel
2023-03-15 7:04 ` Matti Vaittinen
2023-03-15 8:04 ` Linus Walleij
2023-03-15 13:08 ` Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 11/12] power: supply: generic-adc-battery: add DT support Sebastian Reichel
2023-03-14 22:55 ` [PATCHv2 12/12] power: supply: generic-adc-battery: update copyright info Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47f9e288-6c1b-6205-8538-303b65ff160d@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®