From: Robert Abel <rabel@robertabel.eu>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Willy Tarreau <w@1wt.eu>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH 3/4] auxdisplay: charlcd: fix x/y address commands
Date: Mon, 26 Feb 2018 23:38:54 +0100 [thread overview]
Message-ID: <48023798-595d-2a09-6f0c-2834ebefdd68@robertabel.eu> (raw)
In-Reply-To: <CAHp75Vcrx2rLDsJduWx75Wa57yTRqtQ1dqZMkCGv64K0bOYLiQ@mail.gmail.com>
Hi Andy, Hi Miguel,
On 26 Feb 2018 12:44, Andy Shevchenko wrote:
> Can we avoid yoda style of programming?
On 26 Feb 2018 17:49, Miguel Ojeda wrote:
> Please do not change the style of the code w.r.t to the rest of the
> file, which writes tests with the non-lvalue on the right-hand side
> and do not compare against '\0'. Same for the rest.
I am actually a fan of yoda-style programming, although its value is
diminished with modern IDEs, which we all use, right?
On 26 Feb 2018 17:54, Miguel Ojeda wrote:
> On Mon, Feb 26, 2018 at 12:44 PM, Andy Shevchenko
>> Perhaps instead of dancing around kstrtox() better to switch to
>> simple_strtoul() ?
>
> It seems deprecated:
>
> /* Obsolete, do not use. Use kstrto<foo> instead */
> extern unsigned long simple_strtoul(const char *,char **,unsigned int);
I thought the whole point was that simple_strtoul is deprecated and on
the kill list? Isn't that kind of against the whole argument of
re-inventing the wheel?
If using simple_strtoul is an option, it might be best to bring it back
and not touch the buffer at all.
Regards,
Robert
next prev parent reply other threads:[~2018-02-26 22:39 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 23:50 [PATCH 0/3] auxdisplay: charlcd: miscellaneous patches Robert Abel
2018-02-09 23:50 ` [PATCH 1/3] auxdisplay: charlcd: fix hex literal ranges for graphics command Robert Abel
2018-02-09 23:50 ` [PATCH 2/3] auxdisplay: charlcd: use null character instead of zero literal to terminate strings Robert Abel
2018-02-09 23:50 ` [PATCH 3/3] auxdisplay: charlcd: replace octal literal with form-feed escape sequence Robert Abel
2018-02-10 9:43 ` Miguel Ojeda
2018-02-10 9:29 ` [PATCH 2/3] auxdisplay: charlcd: use null character instead of zero literal to terminate strings Miguel Ojeda
2018-02-10 8:58 ` [PATCH 1/3] auxdisplay: charlcd: fix hex literal ranges for graphics command Miguel Ojeda
2018-02-10 9:20 ` Willy Tarreau
2018-02-10 9:41 ` Miguel Ojeda
2018-02-12 13:56 ` Miguel Ojeda
2018-02-13 13:36 ` Andy Shevchenko
2018-02-13 19:15 ` Willy Tarreau
2018-02-14 23:17 ` Robert Abel
2018-02-15 10:57 ` Andy Shevchenko
2018-02-25 23:34 ` Robert Abel
2018-02-25 23:52 ` Robert Abel
2018-02-25 23:54 ` Robert Abel
2018-02-25 23:54 ` [PATCH 1/4] auxdisplay: charlcd: fix two-line command ^[[LN not marked as processed Robert Abel
2018-02-25 23:54 ` [PATCH 2/4] auxdisplay: charlcd: name x/y address struct Robert Abel
2018-02-25 23:54 ` [PATCH 3/4] auxdisplay: charlcd: fix x/y address commands Robert Abel
2018-02-25 23:54 ` [PATCH 4/4] auxdisplay: charlcd: make home command unshift display Robert Abel
2018-02-26 17:16 ` Miguel Ojeda
2018-02-26 8:46 ` [PATCH 3/4] auxdisplay: charlcd: fix x/y address commands Geert Uytterhoeven
2018-02-26 22:29 ` Robert Abel
2018-02-26 11:44 ` Andy Shevchenko
2018-02-26 16:54 ` Miguel Ojeda
2018-02-26 17:09 ` Andy Shevchenko
2018-02-26 17:26 ` Miguel Ojeda
2018-02-26 17:56 ` Andy Shevchenko
2018-02-26 23:00 ` Robert Abel
2018-02-26 22:38 ` Robert Abel [this message]
2018-02-26 23:06 ` Miguel Ojeda
2018-02-26 16:49 ` Miguel Ojeda
2018-02-26 16:57 ` Miguel Ojeda
2018-02-26 22:43 ` Robert Abel
2018-02-27 5:19 ` Willy Tarreau
2018-02-27 19:31 ` Miguel Ojeda
2018-02-27 23:29 ` Robert Abel
2018-02-28 0:05 ` [PATCH RFC 0/2] auxdisplay: charlcd: fix movement and home commands Robert Abel
2018-02-28 0:05 ` [PATCH 1/2] auxdisplay: charlcd: fix x/y address commands Robert Abel
2018-02-28 0:05 ` [PATCH 2/2] auxdisplay: charlcd: make home command unshift display Robert Abel
2018-02-28 4:21 ` [PATCH 3/4] auxdisplay: charlcd: fix x/y address commands Willy Tarreau
2018-02-26 23:05 ` Robert Abel
2018-02-27 5:20 ` Willy Tarreau
2018-02-26 8:35 ` [PATCH 2/4] auxdisplay: charlcd: name x/y address struct Geert Uytterhoeven
2018-02-26 15:59 ` Miguel Ojeda
2018-02-26 8:34 ` [PATCH 1/4] auxdisplay: charlcd: fix two-line command ^[[LN not marked as processed Geert Uytterhoeven
2018-02-26 15:53 ` Miguel Ojeda
2018-02-26 23:08 ` [PATCH 1/3] auxdisplay: charlcd: fix hex literal ranges for graphics command Robert Abel
2018-02-10 18:31 ` Geert Uytterhoeven
2018-02-10 18:58 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48023798-595d-2a09-6f0c-2834ebefdd68@robertabel.eu \
--to=rabel@robertabel.eu \
--cc=andy.shevchenko@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®